-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Filename and Tooltip to Download #4871
Download Filename and Tooltip to Download #4871
Conversation
NOTE: This PR should be Cp'ed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Thanks for merging. IS it deployed immediately? or we'll update the label? |
@akshayasalvi The label got applied after the PR was merged so I'll have to get it CPed manually |
Download Filename and Tooltip to Download (cherry picked from commit e04a689)
🚀 Cherry-picked to staging by @AndrewGable in version: 1.0.88-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
@thienlnam Can you please review this?
Details
Fixed Issues
$ #4601
$ #4870
$ #4868
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android