Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autocomplete issue in VBA flow #4862

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Fix autocomplete issue in VBA flow #4862

merged 4 commits into from
Aug 26, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 26, 2021 •
edited
Loading

cc @kevinksullivan @iwiznia

Details

This PR fixes a regression from #4471 that caused an issue that was undone in #4765. Original issue is https://github.com/Expensify/Expensify/issues/173177.

Tests/QA

  1. Sign into an account on chrome and save the password in chrome when prompted
  2. Sign into an account, tap on the profile icon to go to settings, and then click on a workspace
  3. Click on Get Started for the Expensify Card
  4. Select Connect Manually and enter 123123123 for both fields
  5. On the autoComplete section, confirm no values are pre-filled for Industry Classification Code
  6. Confirm the same happens on all platforms (you won't be able to save password on the others)
  7. Confirm that on Android, you can view the Company Information page without the app throwing an error
  8. Confirm that on iOS, you can view the Company Information page without the app throwing an error

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

@Jag96 Jag96 requested a review from a team as a code owner August 26, 2021 18:02
@Jag96 Jag96 self-assigned this Aug 26, 2021
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team August 26, 2021 18:02
luacmartins
luacmartins requested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well. Just left a small suggestion. Great work!

src/components/ExpensiTextInput/index.ios.js Outdated Show resolved Hide resolved
@Jag96
Copy link
Contributor Author

Jag96 commented Aug 26, 2021

Good catch, updated!

luacmartins
luacmartins approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@Jag96 Jag96 merged commit c1bc5bc into main Aug 26, 2021
@Jag96 Jag96 deleted the joe-fix-android-autocomplete branch August 26, 2021 20:27
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 27, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jag96 @OSBotify @luacmartins