Update the HTML entity parsing #4859
Conversation
parasharrajat
changed the title
|
cc: @Beamanator as you already reviewed this PR on e-common. |
There was a problem hiding this comment.
Note: The original post in slack (here) noted that newlines were stripped too -> should that be fixed in this issue or did you purposefully leave it out?
I can't record this behavior as...
Are you sure? :D What about something like this?
Screen.Recording.2021-08-27.at.9.30.01.AM.mov
|
Yeah. Thanks, I will add a video like this. I didn't think it through 🤭 . |
|
Haha feel free to steal my video for web testing (if you want) |
|
Let me check the newline issue. |
|
Ok. I looked at it. It seems p tag is used for newlines which I think is correct as P(paragraph) is a block element. <meta charset="utf-8">
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;"
id="docs-internal-guid-7a434b3d-7fff-25be-ecb1-113f970fc0f6"><span
style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">Test
a big </span></p><br />
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;"><span
style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">Sdsad
nowe lines</span></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;"><span
style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">Sef</span>
</p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;"><span
style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">As</span>
</p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt;"><span
style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">Dsa</span>
</p>So this is not part of this PR or issue but I can add that if you want. I think to solve this we should add a parsing rule for the p tag. I am sure that it will work great. But a good amount of testing is needed to make sure. I also found p's creating an issue while parsing from Mac Note.app. let me know, what do you want me to do @Beamanator ? |
|
@parasharrajat thanks for researching that! I would agree that this "special entities" fix is different from "parsing P tags" so I think a separate issue & job would make sense, maybe even a discussion in #expensify-open-source about how we want to handle copy / pasting many empty lines (some apps keep all empty lines, some condense them to one) |
|
@Beamanator I think this is a small PR and Another set of eyes is probably not needed. So my suggestion is if you are happy with the changes we move to merge.
|
|
True, and @tgolen has lots of other shenanigans going on this week probs :D |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Beamanator in version: 1.0.88-3 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
|
Whoops, we missed the notification here as the issue wasn't exported. My fault. |
|
Will update the issue manually now. |
Details
Fixed Issues
$ #4759
Tests | QA Steps
Tested On
Screenshots
WEB | Desktop
Screen.Recording.2021-08-27.at.9.30.01.AM.mov