Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onSubmitEditing if submit button disabled #4858

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

aldo-expensify
Copy link
Contributor

Details

Don't pass this.submit callback as a prop if the form submit button is disabled

Fixed Issues

$ #4748

Tests

  • Navigate to /bank-account/company. (Web)
  • The submit button at the end of the form should be disabled
  • Click the Password field at the end to bring it into focus
  • Press Enter key (Web) / Press the submit check in the virtual keyboard (Android, IOS?)

Android:

QA Steps

  1. Navigate to /bank-account/company. (Web)
  2. The submit button at the end of the form should be disabled
  3. Click the Password field at the end to bring it into focus
  4. Press Enter key (Web) / Press the submit check in the virtual keyboard (Android, not sure how it looks in IOS)

Nothing should happen, no form submitted because the submit form button 'Save & Continue' is disabled

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@aldo-expensify aldo-expensify requested a review from a team as a code owner August 26, 2021 17:35
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team August 26, 2021 17:36
@aldo-expensify aldo-expensify requested a review from a team August 26, 2021 17:37
@MelvinBot MelvinBot removed the request for review from a team August 26, 2021 17:37
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well! Good job @aldo-expensify 🎉

@luacmartins luacmartins merged commit 7ddfae4 into main Aug 26, 2021
@luacmartins luacmartins deleted the aldo_disable-submit-button-disabled branch August 26, 2021 18:26
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aldo-expensify
Copy link
Contributor Author

LGTM and tests well! Good job @aldo-expensify 🎉

Thanks @luacmartins ! 😊

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.0.88-3 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants