Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the free trial badge to display Start a free trial badge when we create a workspace for a user #48512
Update the free trial badge to display Start a free trial badge when we create a workspace for a user #48512
Changes from 14 commits
ac12ad3
b1822c0
f6b9286
b54212e
6174fec
5be3131
7a681c1
e2db201
ce9e069
7af63e8
71b3d2e
15f6dba
fc76adf
d877cf4
7535793
c4b3d73
413c149
348f7bb
5a4fe7c
bee4bec
8810a65
4d5ce8e
e45328e
40ef823
b8dcfe8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we use this pattern of passing the Onyx data directly into the function as parameters and, at the same time, initializing the function with the same Onyx data. Instead, would it not be neater to use
effect
andstate
to achieve the same as follows?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was concerned that there might be a delay between the data being updated in
useOynx
and the data fetched from the globaloynx.connect
used in the function.So, I decided to pass it as a function argument, thinking that could be the reason for the delayed transition from 'Start a free trial' to 'Your free trial has ended.'
But I will try this approach.