Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing period to preferences page #4806

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

alex-mechler
Copy link
Contributor

Details

Adds a missing period

Fixed Issues

$ #4772

Tests

  1. Open Preference page
  2. Set your notification mode to Most Recent
  3. Verify there is a period at the end of the sentence

QA Steps

  1. Open Preference page
  2. Set your notification mode to Most Recent
  3. Verify there is a period at the end of the sentence

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Also tested Spanish translation
image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@alex-mechler alex-mechler requested a review from a team August 24, 2021 18:54
@alex-mechler alex-mechler self-assigned this Aug 24, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team August 24, 2021 18:54
@stitesExpensify stitesExpensify merged commit 8aafdb8 into main Aug 24, 2021
@stitesExpensify stitesExpensify deleted the amechler-add-period branch August 24, 2021 19:48
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants