Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the note of cards from the settings menu to only leave domains #47119

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Remove the note of cards from the settings menu to only leave domains #47119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492ac2a
Remove the note of cards from the settings
mountiny Aug 8, 2024
4e7461e
Use globe icon for the domains row
mountiny Aug 8, 2024
6e64eec
Remove unused icon
mountiny Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ export default {
},
allSettingsScreen: {
subscription: 'Subscription',
cardsAndDomains: 'Cards & Domains',
domains: 'Domains',
},
tabSelector: {
chat: 'Chat',
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ export default {
},
allSettingsScreen: {
subscription: 'Suscripcion',
cardsAndDomains: 'Tarjetas y Dominios',
domains: 'Dominios',
},
tabSelector: {
chat: 'Chat',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/sidebar/AllSettingsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function AllSettingsScreen({policies}: AllSettingsScreenProps) {
]
: []),
{
translationKey: 'allSettingsScreen.cardsAndDomains',
translationKey: 'allSettingsScreen.domains',
icon: Expensicons.CardsAndDomains,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename the icon? Or does it still have "cards" in it? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha yeah it has a card in it
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change the icon later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah minteresting, yeah i would assume we'd want a different icon IFF we don't want to associate this item with cards anymore :D

Copy link
Contributor

@srikarparsi srikarparsi Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeahh, up to you Vit, feel free to self-merge from my side if you wanna address the icon later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I have asked about it here #45021 (comment) before, but opened this up for a review earlier as I considered it NAB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed using the globe icon
image

action: () => {
Link.openOldDotLink(CONST.OLDDOT_URLS.ADMIN_DOMAINS_URL);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/InitialSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ function InitialSettingsPage({session, userWallet, bankAccountList, fundList, wa
brickRoadIndicator: hasGlobalWorkspaceSettingsRBR(policies) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
},
{
translationKey: 'allSettingsScreen.cardsAndDomains',
translationKey: 'allSettingsScreen.domains',
icon: Expensicons.CardsAndDomains,
action: () => {
Link.openOldDotLink(CONST.OLDDOT_URLS.ADMIN_DOMAINS_URL);
Expand Down
Loading