Fix crash for missing report #46867

luacmartins · 2024-08-06T10:19:07Z

Details

Fixes a crash when report is missing. We're still investigating why the report is missing, but in the meantime we'll fix the crash

Fixed Issues

$ #46516

Tests

Run this snippet to set bad data

Onyx.mergeCollection('snapshot_', {
    "snapshot_213345373": {
        "search": {
            "isLoading": false,
            "columnsToShow": {
                "shouldShowCategoryColumn": true,
                "shouldShowTagColumn": true,
                "shouldShowTaxColumn": true
            },
            "hasMoreResults": true,
            "offset": 0,
            "statusToShow": {
                "expense": {
                    "all": true,
                    "approved": true,
                    "drafts": true,
                    "outstanding": true,
                    "paid": true
                }
            },
            "type": "report"
        },
        "data": {
            "personalDetailsList": {
            },
            "transactions_8868377321799703": {
                "accountID": 623727,
                "action": "view",
                "amount": -1048,
                "canDelete": false,
                "canHold": false,
                "category": "Other",
                "comment": {
                    "comment": ""
                },
                "created": "2013-09-09",
                "currency": "USD",
                "hasEReceipt": false,
                "isFromSingleExpenseReport": false,
                "managerID": 623727,
                "merchant": "FOREIGN FEE",
                "modifiedAmount": 0,
                "modifiedCreated": "",
                "modifiedCurrency": "",
                "modifiedMerchant": "",
                "parentTransactionID": "",
                "policyID": "A4DBA28EDC7234F3",
                "reportID": "2884699",
                "reportType": "",
                "tag": "",
                "transactionID": "8868377321799703",
                "transactionThreadReportID": "0",
                "transactionType": "card"
            }
        }
    }
})

Open the Shared search page
Verify there's no crash and you see an empty result page

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-08-06T10:21:24Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-08-06T10:55:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Before:

Screen.Recording.2024-08-06.at.12.30.03.PM.mov

After:

Screen.Recording.2024-08-06.at.12.30.46.PM.mov

rayane-djouah · 2024-08-06T12:04:50Z

@luacmartins - I think we should update shouldShowEmptyState here

App/src/components/Search/index.tsx

Line 219 in 412fc60

    
           const shouldShowEmptyState = !isDataLoaded || SearchUtils.isSearchResultsEmpty(searchResults);

to be true when data is an empty array:

App/src/components/Search/index.tsx

Line 266 in 412fc60

    
           const data = SearchUtils.getSections(searchResults?.data ?? {}, searchResults?.search ?? {}, type);

Otherwise, the search page can show an empty view instead of the empty state component if getSections returns an empty array.

Screen.Recording.2024-08-06.at.1.09.20.PM.mov

luacmartins · 2024-08-06T14:32:13Z

Do you know which flow is returning an empty array? The results should always be an object

rayane-djouah · 2024-08-06T14:37:25Z

getReportSections can return an empty array here:

App/src/libs/SearchUtils.ts

Line 229 in 412fc60

return Object.values(reportIDToTransactions);

rayane-djouah · 2024-08-06T14:42:09Z

shouldShowEmptyState can be false when we have bad data only because SearchUtils.isSearchResultsEmpty(searchResults) will be false in this case, because searchResults has transactions:

App/src/components/Search/index.tsx

Line 219 in 412fc60

    
           const shouldShowEmptyState = !isDataLoaded || SearchUtils.isSearchResultsEmpty(searchResults);

App/src/libs/SearchUtils.ts

Lines 321 to 324 in 412fc60

    
           function isSearchResultsEmpty(searchResults: SearchResults) { 
        
               return !Object.keys(searchResults?.data).some((key) => key.startsWith(ONYXKEYS.COLLECTION.TRANSACTION)); 
        
           }

luacmartins · 2024-08-06T15:00:42Z

Ah I see, that happens after we get the reportSections and only when we have a single transaction with bad data. I can look into a solution for this tomorrow.

luacmartins · 2024-08-07T07:34:36Z

Updated!

rayane-djouah · 2024-08-07T08:24:23Z

Fixed 🚀

Screen.Recording.2024-08-07.at.9.21.11.AM.mov

rayane-djouah

LGTM and tests well

melvin-bot · 2024-08-07T08:25:09Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-08-07T08:28:46Z

The reviewer checklist is complete

luacmartins · 2024-08-07T15:54:27Z

Sorry, had to resolve conflicts. Please review again!

melvin-bot · 2024-08-07T17:13:29Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-08-07T21:47:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-07T22:13:30Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.18-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-12T10:04:44Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix crash for missing report

f3a621e

luacmartins self-assigned this Aug 6, 2024

luacmartins marked this pull request as ready for review August 6, 2024 10:21

luacmartins requested a review from a team as a code owner August 6, 2024 10:21

melvin-bot bot requested a review from rayane-djouah August 6, 2024 10:21

melvin-bot bot removed the request for review from a team August 6, 2024 10:21

fix empty state

a27acf1

rayane-djouah approved these changes Aug 7, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli August 7, 2024 08:25

carlosmiceli previously approved these changes Aug 7, 2024

View reviewed changes

resolve conflicts

d8ce455

luacmartins dismissed carlosmiceli’s stale review via d8ce455 August 7, 2024 15:53

luacmartins requested a review from carlosmiceli August 7, 2024 17:10

rayane-djouah approved these changes Aug 7, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich August 7, 2024 17:13

carlosmiceli approved these changes Aug 7, 2024

View reviewed changes

carlosmiceli merged commit 0d3e172 into main Aug 7, 2024
17 checks passed

carlosmiceli deleted the cmartins-fixCrashMissingReport branch August 7, 2024 21:36

github-actions bot mentioned this pull request Aug 7, 2024

Deploy Checklist: New Expensify 2024-08-07 #47006

Closed

88 tasks

melvin-bot bot mentioned this pull request Aug 12, 2024

[HOLD for payment 2024-08-19] [Search v1] Scrolling through old historical expenses in "Shared" crashes the app #46516

Closed

6 tasks

rayane-djouah mentioned this pull request Aug 19, 2024

correct logic of from and to for narrow layout in Shared in Search #44658

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash for missing report #46867

Fix crash for missing report #46867

luacmartins commented Aug 6, 2024 •

edited

Loading

melvin-bot bot commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024 •

edited

Loading

rayane-djouah commented Aug 6, 2024 •

edited

Loading

luacmartins commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024 •

edited

Loading

luacmartins commented Aug 6, 2024

luacmartins commented Aug 7, 2024

rayane-djouah commented Aug 7, 2024

rayane-djouah left a comment

melvin-bot bot commented Aug 7, 2024

rayane-djouah commented Aug 7, 2024

luacmartins commented Aug 7, 2024

melvin-bot bot commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

Fix crash for missing report #46867

Fix crash for missing report #46867

Conversation

luacmartins commented Aug 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Before:

After:

rayane-djouah commented Aug 6, 2024 • edited Loading

luacmartins commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024

rayane-djouah commented Aug 6, 2024 • edited Loading

luacmartins commented Aug 6, 2024

luacmartins commented Aug 7, 2024

rayane-djouah commented Aug 7, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 7, 2024

rayane-djouah commented Aug 7, 2024

luacmartins commented Aug 7, 2024

melvin-bot bot commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

luacmartins commented Aug 6, 2024 •

edited

Loading

rayane-djouah commented Aug 6, 2024 •

edited

Loading

rayane-djouah commented Aug 6, 2024 •

edited

Loading

rayane-djouah commented Aug 6, 2024 •

edited

Loading