Enabling Invoices as a feature #46567

rezkiy37 · 2024-07-31T10:38:18Z

Details

The PR introduces enabling invoices as a feature. This feature allows users to enable invoicing for their workspaces by adding a toggle in the workspace.

Fixed Issues

$ #45168
PROPOSAL: N/A

Tests

There was a decision (#46567 (comment)) to comment out some crucial changes to avoid blocking the invoice creation for the users. Please revert this commit (4acdd47) to test.

Open the workspace More Features page.
Verify that there is a new section "Earn" with a toggle "Invoicing".
Click on the toggler.
Verify that the user can disable and enable it.
Verify if:
1. Enabled: the user can send invoices from the particular workspace.
2. Disabled: the user cannot send invoices from the particular workspace. All previously created invoice rooms and outstanding invoices will remain unaffected and continue to exist. The "Send Invoice" option will no longer appear in the invoice room create menu. Also, the "Send Invoice" option is not in the FAB until at least one workspace has enabled invoicing.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rezkiy37 · 2024-07-31T10:38:55Z

I've asked for translations here.

…ture/45168-enabling-invoices-feature

VickyStash · 2024-08-01T10:52:04Z

src/libs/PolicyUtils.ts

-    return getActiveAdminWorkspaces(policies).length > 0;
+    return getActiveAdminWorkspaces(policies).some((policy) => policy?.areInvoicesEnabled);


The check is correct, but maybe we should update it later and leave a TODO for now?
Cause invoicing settings screen isn't ready yet, and this update will block users from invoice creation.
It relates to other places where we check for areInvoicesEnabled as well.
Maybe we should confirm it

I got you. Let me clarify.

Yeah that makes sense, let's put it as a todo and update it when the invoices screen is ready

I've commented out some changes to prevent the invoice creation from being blocked.

Commit - 4acdd47.

Video

Flow.mp4

cc @madmax330 @VickyStash

Can I open the PR for review?

@rezkiy37 let's add a link to the blocking issue in TODOs #45175, then it's fine

Done - c79964d.

src/types/onyx/Policy.ts

…https://github.com/rezkiy37/Expensify into feature/45168-enabling-invoices-feature

…ture/45168-enabling-invoices-feature

madmax330

Looks good, I think we can get a c+ on it.
Just some small comments

src/libs/actions/Policy/Policy.ts

src/libs/API/types.ts

src/libs/API/parameters/index.ts

src/libs/API/parameters/EnablePolicyInvoicesParams.ts

…ture/45168-enabling-invoices-feature

melvin-bot · 2024-08-06T10:42:13Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-08-07T03:44:40Z

LGTM

dukenv0307 · 2024-08-07T03:45:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

web-resize.mp4

Android: mWeb Chrome

web-resize.mp4

iOS: Native

web-resize.mp4

iOS: mWeb Safari

web-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

web-resize.mp4

OSBotify · 2024-08-07T09:03:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-07T22:12:33Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.18-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-12T10:03:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rezkiy37 added 4 commits July 31, 2024 12:35

add texts

167efba

implement enablePolicyInvoices

c1adffc

extend canSendInvoice

a911d3e

integrate invoice enabling in WorkspaceMoreFeaturesPage

4283e24

rezkiy37 added 4 commits July 31, 2024 12:56

restrict sending invoice when disabled

64f6420

check enabled workspaces

1b2ff88

translate files

be700df

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

25e7656

…ture/45168-enabling-invoices-feature

VickyStash reviewed Aug 1, 2024

View reviewed changes

rezkiy37 added 8 commits August 1, 2024 13:53

filter disabled workspaces for invoices

2e079b5

filter disabled invoices rooms

73cf208

fix comment

49eb3f9

Merge branches 'main' and 'feature/45168-enabling-invoices-feature' of …

a1440c6

…https://github.com/rezkiy37/Expensify into feature/45168-enabling-invoices-feature

rename and improve getInvoicePrimaryWorkspace

fb8ea48

use canSendInvoiceFromWorkspace

f541571

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

219386f

…ture/45168-enabling-invoices-feature

comment some changes out

4acdd47

rezkiy37 requested review from madmax330 and VickyStash August 5, 2024 13:34

link issue to todos

c79964d

VickyStash approved these changes Aug 5, 2024

View reviewed changes

madmax330 reviewed Aug 5, 2024

View reviewed changes

rezkiy37 added 2 commits August 6, 2024 12:31

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

5c155d2

…ture/45168-enabling-invoices-feature

rename invoicing

5bdf617

rezkiy37 changed the title ~~[WIP] Enabling Invoices as a feature~~ Enabling Invoices as a feature Aug 6, 2024

rezkiy37 requested a review from madmax330 August 6, 2024 10:40

rezkiy37 marked this pull request as ready for review August 6, 2024 10:42

rezkiy37 requested a review from a team as a code owner August 6, 2024 10:42

melvin-bot bot requested a review from dukenv0307 August 6, 2024 10:42

melvin-bot bot removed the request for review from a team August 6, 2024 10:42

dukenv0307 approved these changes Aug 7, 2024

View reviewed changes

madmax330 approved these changes Aug 7, 2024

View reviewed changes

madmax330 merged commit 2c60fc9 into Expensify:main Aug 7, 2024
17 of 23 checks passed

github-actions bot mentioned this pull request Aug 7, 2024

Deploy Checklist: New Expensify 2024-08-07 #47006

Closed

88 tasks

m-natarajan mentioned this pull request Aug 8, 2024

Invoice - Send invoice option is present when the workspace has not enabled Invoices feature #47023

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 12, 2024

[HOLD for payment 2024-08-19] Enabling Invoices as a feature on the workspace #45168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabling Invoices as a feature #46567

Enabling Invoices as a feature #46567

rezkiy37 commented Jul 31, 2024 •

edited

Loading

rezkiy37 commented Jul 31, 2024

VickyStash Aug 1, 2024

rezkiy37 Aug 1, 2024

madmax330 Aug 5, 2024

rezkiy37 Aug 5, 2024

rezkiy37 Aug 5, 2024

VickyStash Aug 5, 2024

rezkiy37 Aug 5, 2024

madmax330 left a comment

melvin-bot bot commented Aug 6, 2024

dukenv0307 commented Aug 7, 2024

dukenv0307 commented Aug 7, 2024 •

edited

Loading

OSBotify commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

		return getActiveAdminWorkspaces(policies).length > 0;
		return getActiveAdminWorkspaces(policies).some((policy) => policy?.areInvoicesEnabled);

Enabling Invoices as a feature #46567

Enabling Invoices as a feature #46567

Conversation

rezkiy37 commented Jul 31, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Jul 31, 2024

VickyStash Aug 1, 2024

Choose a reason for hiding this comment

rezkiy37 Aug 1, 2024

Choose a reason for hiding this comment

madmax330 Aug 5, 2024

Choose a reason for hiding this comment

rezkiy37 Aug 5, 2024

Choose a reason for hiding this comment

rezkiy37 Aug 5, 2024

Choose a reason for hiding this comment

VickyStash Aug 5, 2024

Choose a reason for hiding this comment

rezkiy37 Aug 5, 2024

Choose a reason for hiding this comment

madmax330 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 6, 2024

dukenv0307 commented Aug 7, 2024

dukenv0307 commented Aug 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Aug 7, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 12, 2024

rezkiy37 commented Jul 31, 2024 •

edited

Loading

dukenv0307 commented Aug 7, 2024 •

edited

Loading