fix: System message for clearing room description #45986

nkdengineer · 2024-07-23T04:05:46Z

Details

Fixed Issues

$ #45522
PROPOSAL: #45522 (comment)

Tests

Create a room
Click on the report header
Click Room description
Enter description and save it
Click Room description again
Clear description and save it
Go back to room chat
Right click on "cleared the room description" system message > Copy to clipboard
Paste the content in the composer
Verify that: The copied content should be consistent with the room description system message

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a room
Click on the report header
Click Room description
Enter description and save it
Click Room description again
Clear description and save it
Go back to room chat
Right click on "cleared the room description" system message > Copy to clipboard
Paste the content in the composer
Verify that: The copied content should be consistent with the room description system message

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

melvin-bot · 2024-07-23T09:24:52Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-07-23T09:26:18Z

src/languages/es.ts

@@ -4748,5 +4748,6 @@ export default {
    },
    roomChangeLog: {
        updateRoomDescription: 'establece la descripción de la sala a:',
+        clearRoomDescription: 'borrar la descripción de la habitación',


Can you please post this to #expensify-open-source to confirm?

hungvu193 · 2024-07-24T11:23:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

chrome.mov

MacOS: Desktop

desk.mov

nkdengineer · 2024-07-25T02:58:38Z

@hungvu193 please check again

hungvu193

Thanks. LGTM 🎉

OSBotify · 2024-07-25T15:59:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-26T05:38:11Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-07-26T21:45:01Z

Still failing with #45522 in all the platforms.
https://platform.applause.com/services/links/v1/external/7ed706ce4cd380562ae4b3b97d12037d548d25837287154773ddc747e6031126
https://platform.applause.com/services/links/v1/external/d786277811bafcd447aba28fb3d866d5357c996322b99d54929150f09a4b47e9
https://platform.applause.com/services/links/v1/external/a8576d360db5560b1530178b02019acb850909355e69597891b2970f3e030646
https://platform.applause.com/services/links/v1/external/8546158ff781c7f575f766538807337723f30bc2837c90aab4ce525a32e723b9
https://platform.applause.com/services/links/v1/external/338bc38c360b295ba7f93982daf53a4beb961f6cece628b9fd71d7e38c422bb2

hungvu193 · 2024-07-27T00:35:10Z

@kavimuru can you post video directly here? Ty

Cc @nkdengineer

nkdengineer · 2024-07-27T03:59:09Z

@hungvu193 Looks like there was an error while merging the main, we have a follow up PR here

Screen.Recording.2024-07-27.at.10.58.39.mov

hungvu193 · 2024-07-27T04:05:09Z

Thanks. 🙏 I'll take a look today

OSBotify · 2024-07-29T18:40:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

Julesssss · 2024-07-30T11:35:35Z

This PR introduced a minor regression to setting the room description name. @nkdengineer could you please submit a follow-up PR. There is a proposal here that looks promising.

nkdengineer added 2 commits July 23, 2024 11:04

fix: System message for clearing room description

7ca5f7a

fix lint

c5f44e2

nkdengineer marked this pull request as ready for review July 23, 2024 09:24

nkdengineer requested a review from a team as a code owner July 23, 2024 09:24

melvin-bot bot requested review from hungvu193 and removed request for a team July 23, 2024 09:24

hungvu193 reviewed Jul 23, 2024

View reviewed changes

merge main

846b94a

hungvu193 approved these changes Jul 25, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli July 25, 2024 03:23

carlosmiceli approved these changes Jul 25, 2024

View reviewed changes

carlosmiceli merged commit 73f9959 into Expensify:main Jul 25, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 26, 2024

Deploy Checklist: New Expensify 2024-07-26 #46264

Closed

48 tasks

melvin-bot bot mentioned this pull request Jul 29, 2024

[$250] [HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] Room - System message for clearing room description is copied differently #45522

Closed

6 tasks

gijoe0295 mentioned this pull request Jul 30, 2024

[HOLD for payment 2024-08-09] Room - System message shows code when adding emoji and mark down to room description #46486

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: System message for clearing room description #45986

fix: System message for clearing room description #45986

nkdengineer commented Jul 23, 2024 •

edited

Loading

melvin-bot bot commented Jul 23, 2024

hungvu193 Jul 23, 2024

hungvu193 commented Jul 24, 2024 •

edited

Loading

nkdengineer commented Jul 25, 2024

hungvu193 left a comment

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

kavimuru commented Jul 26, 2024

hungvu193 commented Jul 27, 2024

nkdengineer commented Jul 27, 2024

hungvu193 commented Jul 27, 2024

OSBotify commented Jul 29, 2024

Julesssss commented Jul 30, 2024

fix: System message for clearing room description #45986

fix: System message for clearing room description #45986

Conversation

nkdengineer commented Jul 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 23, 2024

hungvu193 Jul 23, 2024

Choose a reason for hiding this comment

hungvu193 commented Jul 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

nkdengineer commented Jul 25, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 25, 2024

OSBotify commented Jul 26, 2024

kavimuru commented Jul 26, 2024

hungvu193 commented Jul 27, 2024

nkdengineer commented Jul 27, 2024

hungvu193 commented Jul 27, 2024

OSBotify commented Jul 29, 2024

Julesssss commented Jul 30, 2024

nkdengineer commented Jul 23, 2024 •

edited

Loading

hungvu193 commented Jul 24, 2024 •

edited

Loading