-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: System message for clearing room description #45986
Conversation
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/languages/es.ts
Outdated
@@ -4748,5 +4748,6 @@ export default { | |||
}, | |||
roomChangeLog: { | |||
updateRoomDescription: 'establece la descripción de la sala a:', | |||
clearRoomDescription: 'borrar la descripción de la habitación', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please post this to #expensify-open-source to confirm?
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safarichrome.movMacOS: Desktopdesk.mov |
@hungvu193 please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 🎉
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.13-0 🚀
|
@kavimuru can you post video directly here? Ty Cc @nkdengineer |
@hungvu193 Looks like there was an error while merging the main, we have a follow up PR here Screen.Recording.2024-07-27.at.10.58.39.mov |
Thanks. 🙏 I'll take a look today |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀
|
This PR introduced a minor regression to setting the room description name. @nkdengineer could you please submit a follow-up PR. There is a proposal here that looks promising. |
Details
Fixed Issues
$ #45522
PROPOSAL: #45522 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop