Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Onyx Key #45320

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Rename Onyx Key #45320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7e212
Rename Onyx Key
srikarparsi Jul 12, 2024
1418fad
disable lint next line
srikarparsi Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@ function isClosedExpenseReportWithNoExpenses(report: OnyxEntry<Report>): boolean
*/
function isArchivedRoom(report: OnyxInputOrEntry<Report>, reportNameValuePairs?: OnyxInputOrEntry<ReportNameValuePairs>): boolean {
if (reportNameValuePairs) {
return reportNameValuePairs.isArchived;
return reportNameValuePairs.private_isArchived;
}

return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && report?.stateNum === CONST.REPORT.STATE_NUM.APPROVED;
Expand Down
3 changes: 2 additions & 1 deletion src/types/onyx/ReportNameValuePairs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import type * as OnyxCommon from './OnyxCommon';
/** Model of additional report details */
type ReportNameValuePairs = OnyxCommon.OnyxValueWithOfflineFeedback<{
/** Whether the report is an archived room */
isArchived: boolean;
// eslint-disable-next-line @typescript-eslint/naming-convention
private_isArchived: boolean;
}>;

export default ReportNameValuePairs;
Loading