Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] [Search v2] [App] Create Search input parser #45161

Merged
merged 18 commits into from
Jul 11, 2024
Merged

[No QA] [Search v2] [App] Create Search input parser #45161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bcb7ca7
add peggy to package.json
adamgrzybowski Jul 10, 2024
885b47b
add search parser grammar
adamgrzybowski Jul 10, 2024
177824f
handle generating parser
adamgrzybowski Jul 10, 2024
4cd1b8b
create buildJSONQuery function
adamgrzybowski Jul 10, 2024
c18d234
fix new line in searchParser.peggy
adamgrzybowski Jul 10, 2024
065c8ab
fix eslint
adamgrzybowski Jul 10, 2024
8804112
fix new line in .gitignore
adamgrzybowski Jul 10, 2024
f89daf4
fix eslint
adamgrzybowski Jul 10, 2024
73bffd6
add type for result in SearchUtils
adamgrzybowski Jul 10, 2024
3aabbc6
add searchParser.js to repo
adamgrzybowski Jul 10, 2024
3821ecc
update grammar for searchParser
adamgrzybowski Jul 10, 2024
1127527
add generated parser to prettier ignore
adamgrzybowski Jul 10, 2024
a821de9
Merge branch 'main' into adamgrzybowski/create-search-input-parser
adamgrzybowski Jul 10, 2024
05c0548
add new line in prettier ignore
adamgrzybowski Jul 10, 2024
cd6abef
Add fixes to Search parser peggy grammar
Kicu Jul 11, 2024
7f52839
Move Search Parser to a dedicated dir and ignore it for typecheck GH …
Kicu Jul 11, 2024
5991da1
fix eslintignore and prettierignore
Kicu Jul 11, 2024
c4587d3
Fix typecheck github action
Kicu Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ docs/vendor/**
docs/assets/**
web/gtm.js
**/.expo/**
src/libs/SearchParser/searchParser.js
2 changes: 1 addition & 1 deletion .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
# - git diff is used to see the files that were added on this branch
# - gh pr view is used to list files touched by this PR. Git diff may give false positives if the branch isn't up-to-date with main
# - wc counts the words in the result of the intersection
count_new_js=$(comm -1 -2 <(git diff --name-only --diff-filter=A origin/main HEAD -- 'src/*.js' '__mocks__/*.js' '.storybook/*.js' 'assets/*.js' 'config/*.js' 'desktop/*.js' 'jest/*.js' 'scripts/*.js' 'tests/*.js' 'workflow_tests/*.js' '.github/libs/*.js' '.github/scripts/*.js') <(gh pr view ${{ github.event.pull_request.number }} --json files | jq -r '.files | map(.path) | .[]') | wc -l)
count_new_js=$(comm -1 -2 <(git diff --name-only --diff-filter=A origin/main HEAD -- 'src/*.js' '__mocks__/*.js' '.storybook/*.js' 'assets/*.js' 'config/*.js' 'desktop/*.js' 'jest/*.js' 'scripts/*.js' 'tests/*.js' 'workflow_tests/*.js' '.github/libs/*.js' '.github/scripts/*.js' ':!src/libs/SearchParser/*.js') <(gh pr view ${{ github.event.pull_request.number }} --json files | jq -r '.files | map(.path) | .[]') | wc -l)
if [ "$count_new_js" -gt "0" ]; then
echo "ERROR: Found new JavaScript files in the project; use TypeScript instead."
exit 1
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ package-lock.json
src/libs/E2E/reactNativeLaunchingTest.ts
# Temporary while we keep react-compiler in our repo
lib/**

# Automatically generated files
src/libs/SearchParser/searchParser.js
63 changes: 63 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"workflow-test:generate": "ts-node workflow_tests/utils/preGenerateTest.ts",
"setup-https": "mkcert -install && mkcert -cert-file config/webpack/certificate.pem -key-file config/webpack/key.pem dev.new.expensify.com localhost 127.0.0.1",
"e2e-test-runner-build": "ncc build tests/e2e/testRunner.ts -o tests/e2e/dist/",
"react-compiler-healthcheck": "react-compiler-healthcheck --verbose"
"react-compiler-healthcheck": "react-compiler-healthcheck --verbose",
"generate-search-parser": "peggy --format es -o src/libs/SearchParser/searchParser.js src/libs/SearchParser/searchParser.peggy "
},
"dependencies": {
"@babel/plugin-proposal-private-methods": "^7.18.6",
Expand Down Expand Up @@ -287,6 +288,7 @@
"memfs": "^4.6.0",
"onchange": "^7.1.0",
"patch-package": "^8.0.0",
"peggy": "^4.0.3",
"portfinder": "^1.0.28",
"prettier": "^2.8.8",
"pusher-js-mock": "^0.3.3",
Expand Down
Loading
Loading