[No QA] Create new Card Details page #45155

VickyStash · 2024-07-10T13:47:56Z

Details

Creates a new Card Details page

Fixed Issues

$ #44325
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Pre-step:
Comment out the feature check in the WorkspaceExpensifyCardDetailsPage file, so you can access the screen.

Steps:

Open any workspace.
Update the URL to end with /expensify-card/1, for example: https://dev.new.expensify.com:8082/settings/workspaces/YOUR_POLICY_ID/expensify-card/1.
Make sure the Card Details page looks like expected. Card preview, cardholder, card number and remaining limit info should be displayed.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-07-10T14:28:41Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-07-10T15:24:06Z

@allgandalf what is your ETA for the review?

allgandalf · 2024-07-10T15:25:14Z

logging off for dinner, should be back in 1.30 hours

github-actions · 2024-07-10T15:50:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45155/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45155/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45155/NewExpensify.dmg	https://45155.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-10T15:56:47Z

@mountiny what is the best way for me to test this using the adhoc build? Do I need any betas enabled or anything?

mountiny · 2024-07-10T16:18:27Z

Pre-step:
Comment out the feature check in the WorkspaceExpensifyCardDetailsPage file, so you can access the screen.

Ah maybe it would be a bit tricky to test on the adhoc build, you need to have a policy that has the cards feature enabled already

Is it ok for you to check the design from the recordings?

I think the page looks much similar to the one we have for the exisitng card you own

allgandalf · 2024-07-10T17:58:28Z

Starting Review now 🔁 🟢

allgandalf · 2024-07-10T18:13:12Z

@VickyStash in the design doc there are 2 more fields Card Limit Limit Type and Card Name, were they left out for later implementation or were they missed?

Design Doc	Current Implementation

I think we should also just put in a Deactivate card button here with no functionality, were they left out on purpose ?

allgandalf

Code is almost good, but waiting for some of the comments to be addressed, I will be quick tomorrow to test the changes as soon as @VickyStash updates it

src/libs/Navigation/types.ts

allgandalf · 2024-07-10T18:36:02Z

Oh also on small screen the offline indicator isn't at the bottom of the screen:

VickyStash · 2024-07-11T06:43:17Z

@VickyStash in the design doc there are 2 more fields Card Limit Limit Type and Card Name, were they left out for later implementation or were they missed?

@allgandalf I've skipped it on purpose since there are other issues with implementing this functionality. But I'm okay to add UI elements to the Card Details screen in this ticket.
I'll ping you when it is done.

VickyStash · 2024-07-11T08:05:31Z

@allgandalf I've applied updates and updated recordings, please take a look

allgandalf · 2024-07-11T12:27:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf

Looks good on all platforms, all yours @mountiny

allgandalf

Come on melvin ask vit for a review!!

mountiny · 2024-07-12T22:56:57Z

@allgandalf @VickyStash There are conflicts now, sorry for not merging it soon enough

# Conflicts: # src/languages/en.ts # src/languages/es.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts # src/libs/Navigation/linkingConfig/config.ts # src/libs/Navigation/types.ts

VickyStash · 2024-07-15T09:10:18Z

@mountiny conflicts resolved, take a look, please

mountiny

Thanks

OSBotify · 2024-07-15T18:40:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:07:08Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:15:52Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:24:07Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:52:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 2 commits July 10, 2024 15:44

Implement Card Details page

fae3285

Minor improvements

c0b3fd9

VickyStash changed the title ~~[WIP] [No QA] Create new Card Details page~~ [No QA] Create new Card Details page Jul 10, 2024

VickyStash marked this pull request as ready for review July 10, 2024 14:28

VickyStash requested review from a team as code owners July 10, 2024 14:28

melvin-bot bot requested review from ikevin127 and removed request for a team July 10, 2024 14:28

VickyStash mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-24] [Workspace Feeds] [External] Create new Card Details page #44325

Closed

mountiny requested review from allgandalf and removed request for ikevin127 July 10, 2024 15:16

mountiny assigned VickyStash Jul 10, 2024

mountiny added the Ready To Build label Jul 10, 2024

mountiny self-requested a review July 10, 2024 15:24

allgandalf reviewed Jul 10, 2024

View reviewed changes

src/libs/Navigation/types.ts Show resolved Hide resolved

VickyStash added 2 commits July 11, 2024 09:41

Add additional Menu Items for Card limit and name

2e2e731

Minor code improvements

674c2f0

allgandalf approved these changes Jul 11, 2024

View reviewed changes

allgandalf approved these changes Jul 12, 2024

View reviewed changes

mountiny approved these changes Jul 15, 2024

View reviewed changes

mountiny merged commit cf34d87 into Expensify:main Jul 15, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Create new Card Details page #45155

[No QA] Create new Card Details page #45155

VickyStash commented Jul 10, 2024 •

edited

Loading

melvin-bot bot commented Jul 10, 2024

mountiny commented Jul 10, 2024

allgandalf commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

shawnborton commented Jul 10, 2024

mountiny commented Jul 10, 2024

allgandalf commented Jul 10, 2024

allgandalf commented Jul 10, 2024 •

edited

Loading

allgandalf left a comment

allgandalf commented Jul 10, 2024

VickyStash commented Jul 11, 2024

VickyStash commented Jul 11, 2024

allgandalf commented Jul 11, 2024 •

edited

Loading

allgandalf left a comment

allgandalf left a comment

mountiny commented Jul 12, 2024

VickyStash commented Jul 15, 2024

mountiny left a comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

[No QA] Create new Card Details page #45155

[No QA] Create new Card Details page #45155

Conversation

VickyStash commented Jul 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 10, 2024

mountiny commented Jul 10, 2024

allgandalf commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

shawnborton commented Jul 10, 2024

mountiny commented Jul 10, 2024

allgandalf commented Jul 10, 2024

allgandalf commented Jul 10, 2024 • edited Loading

allgandalf left a comment

Choose a reason for hiding this comment

allgandalf commented Jul 10, 2024

VickyStash commented Jul 11, 2024

VickyStash commented Jul 11, 2024

allgandalf commented Jul 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

allgandalf left a comment

Choose a reason for hiding this comment

mountiny commented Jul 12, 2024

VickyStash commented Jul 15, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

VickyStash commented Jul 10, 2024 •

edited

Loading

allgandalf commented Jul 10, 2024 •

edited

Loading

allgandalf commented Jul 11, 2024 •

edited

Loading