[No QA] Issue New Card Bank Accounts Logic #45069

koko57 · 2024-07-09T13:02:38Z

Details

Fixed Issues

$ #44305
PROPOSAL: -

Tests

NOTE: you should have canUseWorkspaceFeeds permission enabled. If you cannot access the Expensify Card Page you can go force offline.

Go to Workspaces, choose a workspace.
Go to more features, enable Expensify Card (on the web/desktop click on Expensify Card item in the left option list to go to Expensify Card Page)
On the Expensify Card Page press "Issue new card" button.
If you have an account Choose Bank Account Page should be displayed otherwise, you should be redirected VBBA flow
Choose a bank - you should be redirected to the Issue New Card flow
If you choose Add bank account you will be redirected to the VBBA flow
On the Expensify Catd Page: If your bankAccount is in VALIDATING, VERIFYING or SETUP state the button text should be "Finish setup" and redirect you to the VBBA flow

Verify that no errors appear in the JS console

Offline tests

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-10.at.12.32.07.mp4

Android: mWeb Chrome

Screen.Recording.2024-07-10.at.14.15.45.mp4

iOS: Native

Screen.Recording.2024-07-10.at.15.07.48.mp4

iOS: mWeb Safari

Screen.Recording.2024-07-10.at.15.05.25.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-10.at.10.20.48.mp4

MacOS: Desktop

Screen.Recording.2024-07-10.at.10.23.54.mp4

melvin-bot · 2024-07-10T13:16:38Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-07-11T09:44:57Z

@koko57 Bug: Click "Finish Step", App navigates to WORKSPACE_EXPENSIFY_CARD_BANK_ACCOUNT

Screen.Recording.2024-07-11.at.16.40.56.mov

I believe we should include a condition to check if bankAccountList is empty (isEmptyObject(bankAccountList)) in the getTranslationForCta function, alongside the switch case.

DylanDylann · 2024-07-11T09:46:24Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

+    const styles = useThemeStyles();
+    const [bankAccountsList] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST);
+
+    const policyID = route.params.policyID ?? '-1';


Suggested change

const policyID = route.params.policyID ?? '-1';

const policyID = route?.params?.policyID ?? '-1';

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

DylanDylann · 2024-07-11T10:34:54Z

@koko57 As I understand, we only display "Finish Setup" button if there are no bank account and VBBA in the state of SETUP, VERIFYING, or VALIDATING.

koko57 · 2024-07-11T10:40:19Z

@DylanDylann fixed

DylanDylann · 2024-07-11T11:12:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-11.at.18.03.11.mov

Android: mWeb Chrome

Screen.Recording.2024-07-11.at.17.59.45.mov

iOS: Native

Screen.Recording.2024-07-11.at.18.02.09.mov

iOS: mWeb Safari

Screen.Recording.2024-07-11.at.17.58.56.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-11.at.17.53.25.mov

MacOS: Desktop

Screen.Recording.2024-07-11.at.18.11.43.mov

DylanDylann

LGTM

mountiny

couple comments but we do not have to block on that I think

mountiny · 2024-07-12T16:27:27Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

+        // const eligibleBankAccounts = Object.values(bankAccountsList).filter((bankAccount) => bankAccount.accountData.allowDebit || bankAccount.accountData.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS);
+        const eligibleBankAccounts = Object.values(bankAccountsList);


Why did we omit this check, we could have added it to the mock data if needed

will be held in #46564

mountiny · 2024-07-12T16:28:26Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPageEmptyState.tsx

+        (reimbursementAccountStatus === CONST.BANK_ACCOUNT.STATE.VERIFYING ||
+            reimbursementAccountStatus === CONST.BANK_ACCOUNT.STATE.SETUP ||
+            reimbursementAccountStatus === CONST.BANK_ACCOUNT.STATE.VALIDATING);


I think you can instead check if the status is defined and its not OPEN

will be held in #46564

OSBotify · 2024-07-12T16:40:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:06:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:15:01Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:22:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:51:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

koko57 added 4 commits July 9, 2024 09:22

feat: setup route for choosing bank account

528646b

feat: create page content

1d21217

feat: render proper bank info

78490f4

chore: cleanup

3e64e94

koko57 mentioned this pull request Jul 9, 2024

[$250] [Workspace Feeds] [External] Create Issue new card logic - existing bank accounts #44305

Closed

koko57 added 2 commits July 10, 2024 09:13

fix: resolve conflicts

1d6e3cf

fix: minor improvements

3ba56cb

koko57 changed the title ~~Issue New Card Bank Accounts Logic~~ [No QA] Issue New Card Bank Accounts Logic Jul 10, 2024

fix: minor improvements

8b1f0f0

koko57 marked this pull request as ready for review July 10, 2024 13:16

koko57 requested a review from a team as a code owner July 10, 2024 13:16

melvin-bot bot requested review from DylanDylann and removed request for a team July 10, 2024 13:16

mountiny assigned koko57 Jul 10, 2024

mountiny self-requested a review July 10, 2024 16:46

DylanDylann reviewed Jul 11, 2024

View reviewed changes

koko57 added 2 commits July 11, 2024 12:20

Merge branch 'main' into feature/44305-existing-bank-accounts-logic

77545b7

fix: apply requested changes

b7ce53c

koko57 requested a review from DylanDylann July 11, 2024 10:30

fix: fix condition

52faa21

DylanDylann approved these changes Jul 11, 2024

View reviewed changes

mountiny approved these changes Jul 12, 2024

View reviewed changes

mountiny merged commit 40b7a28 into Expensify:main Jul 12, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Issue New Card Bank Accounts Logic #45069

[No QA] Issue New Card Bank Accounts Logic #45069

koko57 commented Jul 9, 2024 •

edited by github-actions bot

Loading

melvin-bot bot commented Jul 10, 2024

DylanDylann commented Jul 11, 2024

DylanDylann Jul 11, 2024

DylanDylann commented Jul 11, 2024 •

edited

Loading

koko57 commented Jul 11, 2024

DylanDylann commented Jul 11, 2024 •

edited

Loading

DylanDylann left a comment

mountiny left a comment

mountiny Jul 12, 2024

koko57 Aug 9, 2024

mountiny Jul 12, 2024

koko57 Aug 9, 2024

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

	const policyID = route.params.policyID ?? '-1';
	const policyID = route?.params?.policyID ?? '-1';

		// const eligibleBankAccounts = Object.values(bankAccountsList).filter((bankAccount) => bankAccount.accountData.allowDebit \|\| bankAccount.accountData.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS);
		const eligibleBankAccounts = Object.values(bankAccountsList);

[No QA] Issue New Card Bank Accounts Logic #45069

[No QA] Issue New Card Bank Accounts Logic #45069

Conversation

koko57 commented Jul 9, 2024 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 10, 2024

DylanDylann commented Jul 11, 2024

DylanDylann Jul 11, 2024

Choose a reason for hiding this comment

DylanDylann commented Jul 11, 2024 • edited Loading

koko57 commented Jul 11, 2024

DylanDylann commented Jul 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jul 12, 2024

Choose a reason for hiding this comment

koko57 Aug 9, 2024

Choose a reason for hiding this comment

mountiny Jul 12, 2024

Choose a reason for hiding this comment

koko57 Aug 9, 2024

Choose a reason for hiding this comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

koko57 commented Jul 9, 2024 •

edited by github-actions bot

Loading

DylanDylann commented Jul 11, 2024 •

edited

Loading

DylanDylann commented Jul 11, 2024 •

edited

Loading