[NO-QA]: Add Card reconciliation account setting #44968

narefyev91 · 2024-07-08T13:57:29Z

Details

Add card reconciliation account setting

Fixed Issues

$ #44315
$ #44314
PROPOSAL:

Tests

Enable accounting for workspace
Sync for any of products (xero, quick online, etc)
Verify that new menu item - Card reconciliation appears
Click on menu item
Verify that new empty page will be opened in the right stack

Verify that no errors appear in the JS console

Offline tests

Enable accounting for workspace
Sync for any of products (xero, quick online, etc)
Verify that new menu item - Card reconciliation appears
Click on menu item
Verify that new empty page will be opened in the right stack

QA Steps

Enable accounting for workspace
Sync for any of products (xero, quick online, etc)
Verify that new menu item - Card reconciliation appears
Click on menu item
Verify that new empty page will be opened in the right stack

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-08T13:57:34Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

koko57 · 2024-07-10T15:40:24Z

Conflicts resolved. This PR also includes changes from this issue #44314

DylanDylann · 2024-07-10T16:08:35Z

I will take over this PR

mountiny · 2024-07-10T16:38:07Z

src/ROUTES.ts

+    POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_CARD_RECONCILIATION: {
+        route: 'settings/workspaces/:policyID/accounting/quickbooks-online/card-reconciliation',
+        getRoute: (policyID: string) => `settings/workspaces/${policyID}/accounting/quickbooks-online/card-reconciliation` as const,
+    },
    POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_COMPANY_CARD_EXPENSE_ACCOUNT: {


I believe we have created the routes in this PR https://github.com/Expensify/App/pull/45047/files in more generic way cc @koko57 @VickyStash

@mountiny done!

DylanDylann · 2024-07-11T10:07:22Z

src/pages/workspace/accounting/PolicyAccountingPage.tsx

@@ -300,7 +307,7 @@ function PolicyAccountingPage({policy, connectionSyncProgress}: PolicyAccounting
                      },
                  ]
                : []),
-            ...(isEmptyObject(policy?.connections) || shouldShowSynchronizationError
+            ...(!isEmptyObject(policy?.connections) || shouldShowSynchronizationError


@narefyev91 Why do we change this line?

DylanDylann · 2024-07-11T10:12:21Z

@narefyev91 The Reconciliation Account Settings page is created in this PR #45047 . Please merge the latest main

DylanDylann · 2024-07-11T10:19:41Z

@narefyev91 The linked issue #44315 is creating Card Reconciliation page not Card reconciliation account setting. Card reconciliation account setting is created in another PR

koko57 · 2024-07-11T12:03:54Z

@DylanDylann - @narefyev91 is ooo, I'm taking over this PR

koko57 · 2024-07-11T12:11:28Z

@narefyev91 The linked issue #44315 is creating Card Reconciliation page not Card reconciliation account setting. Card reconciliation account setting is created in another PR

yes, and this PR adds a correct page. There is some misunderstading with the routes - #45047 this PR should actually lead to /settings/workspaces/YOUR_POLICY_ID/accounting/CONNECTION/card-reconciliation/account not to /settings/workspaces/YOUR_POLICY_ID/accounting/CONNECTION/card-reconciliation. I need to add another route (/settings/workspaces/YOUR_POLICY_ID/accounting/CONNECTION/card-reconciliation/account) and change the pages

koko57 · 2024-07-11T12:12:35Z

@narefyev91 The Reconciliation Account Settings page is created in this PR #45047 . Please merge the latest main

already merged with these changes

koko57 · 2024-07-11T12:56:26Z

@mountiny @DylanDylann looks like this PR should be linked to #44314. The code here misses the switch and logic for this page. I just fixed the problem with routes. Maybe we can merge this one the way it is, I will take care of the Card Reconciliation Page in another PR, when I'm back (tomorrow, I'm ooo and I need to skedaddle now)

mountiny

Thanks!

mountiny · 2024-07-12T15:59:21Z

src/pages/workspace/accounting/PolicyAccountingPage.tsx

+                          wrapperStyle: [styles.sectionMenuItemTopDescription],
+                          onPress: integrationData?.onCardReconciliationPagePress,
+                      },
+


Suggested change

DylanDylann · 2024-07-12T16:06:09Z

I am working on this PR. Trying to complete the checklist today

DylanDylann · 2024-07-12T17:26:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-13.at.00.31.43.mov

Android: mWeb Chrome

Screen.Recording.2024-07-13.at.00.29.38.mov

iOS: Native

Screen.Recording.2024-07-13.at.00.32.02.mov

iOS: mWeb Safari

Screen.Recording.2024-07-13.at.00.28.57.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-13.at.00.27.40.mov

MacOS: Desktop

Screen.Recording.2024-07-13.at.00.30.52.mov

DylanDylann

LGTM

mountiny

Thanks

OSBotify · 2024-07-12T23:10:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:05:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:14:43Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:22:04Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

koko57 · 2024-07-17T14:21:22Z

The code here misses the switch and logic for this page

@mountiny @DylanDylann the UI is done in #45452

OSBotify · 2024-07-18T13:51:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add Card reconciliation account setting

046a024

narefyev91 requested a review from a team as a code owner July 8, 2024 13:57

melvin-bot bot requested review from eVoloshchak and removed request for a team July 8, 2024 13:57

clean up

328f974

VickyStash mentioned this pull request Jul 9, 2024

[Workspace Feeds] [External] Disable card reconciliation when auto-sync not enabled #44318

Closed

fix: resolve conflicts

a603e9d

mountiny requested review from DylanDylann and removed request for eVoloshchak July 10, 2024 16:09

mountiny assigned koko57 and narefyev91 Jul 10, 2024

mountiny self-requested a review July 10, 2024 16:09

mountiny requested changes Jul 10, 2024

View reviewed changes

koko57 added 3 commits July 11, 2024 09:42

fix: resolve conflicts

7cb646b

remove doubled reconciliation routes

3df3a95

remove doubled reconciliation routes

33f6997

DylanDylann reviewed Jul 11, 2024

View reviewed changes

koko57 added 2 commits July 11, 2024 14:51

fix: cleanup routes

bd84c39

fix: navigate to proper route

9976561

mountiny approved these changes Jul 12, 2024

View reviewed changes

DylanDylann approved these changes Jul 12, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 12, 2024 17:33

mountiny approved these changes Jul 12, 2024

View reviewed changes

mountiny merged commit ba2a923 into Expensify:main Jul 12, 2024
17 of 18 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

This was referenced Jul 17, 2024

[HOLD for payment 2024-07-24] [Workspace Feeds] [External] Create new Card Reconciliation page #44315

Closed

[Workspace Feeds] [External] Add a new object to connectionsMenuItems #44314

Closed

koko57 mentioned this pull request Jul 17, 2024

[No QA] Card reconciliation page #45606

Closed

61 tasks

DylanDylann mentioned this pull request Nov 18, 2024

[HOLD for payment 2024-12-09] [$250] QBO - "Reconciliation account" disappears after selecting it #52548

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO-QA]: Add Card reconciliation account setting #44968

[NO-QA]: Add Card reconciliation account setting #44968

narefyev91 commented Jul 8, 2024 •

edited by mountiny

Loading

melvin-bot bot commented Jul 8, 2024

koko57 commented Jul 10, 2024

DylanDylann commented Jul 10, 2024

mountiny Jul 10, 2024

koko57 Jul 11, 2024

DylanDylann Jul 11, 2024

DylanDylann commented Jul 11, 2024

DylanDylann commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

mountiny left a comment

mountiny Jul 12, 2024

DylanDylann commented Jul 12, 2024

DylanDylann commented Jul 12, 2024 •

edited

Loading

DylanDylann left a comment

mountiny left a comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

koko57 commented Jul 17, 2024

OSBotify commented Jul 18, 2024

[NO-QA]: Add Card reconciliation account setting #44968

[NO-QA]: Add Card reconciliation account setting #44968

Conversation

narefyev91 commented Jul 8, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 8, 2024

koko57 commented Jul 10, 2024

DylanDylann commented Jul 10, 2024

mountiny Jul 10, 2024

Choose a reason for hiding this comment

koko57 Jul 11, 2024

Choose a reason for hiding this comment

DylanDylann Jul 11, 2024

Choose a reason for hiding this comment

DylanDylann commented Jul 11, 2024

DylanDylann commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

koko57 commented Jul 11, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jul 12, 2024

Choose a reason for hiding this comment

DylanDylann commented Jul 12, 2024

DylanDylann commented Jul 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

koko57 commented Jul 17, 2024

OSBotify commented Jul 18, 2024

narefyev91 commented Jul 8, 2024 •

edited by mountiny

Loading

DylanDylann commented Jul 12, 2024 •

edited

Loading