prevent initial focus trap while has a focused element. #44932

suneox · 2024-07-06T08:26:34Z

Details

Fixed Issues

$ #43662
$ #44956
$ #44745
PROPOSAL: #43662 (comment)

Tests

Same QA Steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Issue 43662:

Go to staging.new.expensify.com
Go to chat
Go to + > Submit expense > Manual
Enter amount
Hit Enter
Verify the back icon on RHP will not have blue border selection

Issue 44745:

Open app
From global menu click on 'Fab' > start chat
From the bottom of the page click on the referral banner
Verify Animation should correct when RHP page for referral is opened

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Issue 43662:

Screen.Recording.2024-07-06.at.15.04.51.mov

Issue 44745:

Screen.Recording.2024-07-11.at.21.28.23.mov

MacOS: Desktop

Screen.Recording.2024-07-06.at.14.50.31.mov

Android: Native

Screen.Recording.2024-07-06.at.14.56.49.mov

Android: mWeb Chrome

Screen.Recording.2024-07-06.at.14.55.29.mov

iOS: Native

Screen.Recording.2024-07-06.at.14.52.27.mov

iOS: mWeb Safari

Screen.Recording.2024-07-06.at.14.49.23.mov

melvin-bot · 2024-07-06T08:26:39Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

s77rt · 2024-07-06T14:13:14Z

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

+                delayInitialFocus: CONST.ANIMATED_TRANSITION,
+                // We don’t want to override autofocus while there is a focused element.
+                initialFocus: (containers) => {
+                    const hasFocusedElement = containers?.some((container) => container.contains(document.activeElement));


Suggested change

const hasFocusedElement = containers?.some((container) => container.contains(document.activeElement));

const isFocusedElementWithinFocusTrapContainer = containers?.some((container) => container.contains(document.activeElement));

i've updated

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

s77rt · 2024-07-06T14:15:29Z

patches/focus-trap+7.5.4.patch

+-var delay = function delay(fn) {
+-  return setTimeout(fn, 0);
+var delay = function delay(fn, delayTime = 0) {
+  return setTimeout(fn, delayTime);


I think we need to keep the extra setTimeout here and add our timeout. After testing I found out that document.activeElement does not return the correct focused element.

Suggested change

+ return setTimeout(fn, delayTime);

+ return setTimeout(() => setTimeout(fn, delayTime), 0);

After the component unmounts, the focus trap will deactivate, so the default active element becomes the document. So I don't think we need to add another timeout inside the existing timeout

Can you please elaborate what does this has to do with focus deactivation? What I am referring to is the fact that if you log document.activeElement you will not get the correct focused element as we are doing this too early

Screen.Recording.2024-07-08.at.4.42.36.PM.mov

We have a missing delayInitialFocus time; it should equal CONST.ANIMATED_TRANSITION + CONST.ANIMATION_IN_TIMING. I’ll update it with the timing animation in accordingly.

Screen.Recording.2024-07-08.at.23.18.32.mov

Updated timing animation

The correct timing is 300ms (CONST.ANIMATED_TRANSITION). CONST.ANIMATION_IN_TIMING is not related to the screen transition.

The correct timing is 300ms (CONST.ANIMATED_TRANSITION). CONST.ANIMATION_IN_TIMING is not related to the screen transition.

About this change, we need to extend ANIMATION_IN_TIMING. This is because useAutoFocus also runs after ANIMATED_TRANSITION. In that case, input focusing and getting initial focus from the focus trap will run simultaneously, so sometimes the focused element is not correct

Given that this already had it's own setTimeout even when no timeout is actually required, we should just add another setTimeout. The former is to fix whatever the library was trying to fix and the later is for our actual wanted delay.

I'll try your suggestion

i have updated

patches/focus-trap+7.5.4.patch

…al-focus-trap

s77rt · 2024-07-08T15:46:25Z

patches/focus-trap+7.5.4.patch

+-var delay = function delay(fn) {
+-  return setTimeout(fn, 0);
+var delay = function delay(fn, delayTime = 0) {
+  return setTimeout(fn, delayTime);


Can you please elaborate what does this has to do with focus deactivation? What I am referring to is the fact that if you log document.activeElement you will not get the correct focused element as we are doing this too early

Screen.Recording.2024-07-08.at.4.42.36.PM.mov

patches/focus-trap+7.5.4.patch

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

src/components/MoneyRequestConfirmationList.tsx

mountiny · 2024-07-08T20:56:11Z

@suneox @s77rt can you please confirm this PR should fix this issue as well? #44956 if yes, please add it to the PR description and add the necessary test steps to the coverage, thank you!

s77rt · 2024-07-08T23:07:05Z

@mountiny Yes it will fix that issue

src/components/MoneyRequestConfirmationList.tsx

s77rt · 2024-07-08T23:17:59Z

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

-                    }
-                    return undefined;
-                },
-                setReturnFocus: (element) => {


We should not return focus to the initial screen if we already have a focused element, e.g. in ReportScreen after closing RHP the Composer should remain focused

Screen.Recording.2024-07-09.at.12.17.06.AM.mov

@s77rt I’m still working on setReturnFocus. Do you mean your suggestion also checks if there’s a focused element to skip setReturnFocus?

When a component using focus-trap-react unmounts, it calls deactivateTrap, which triggers focusTrap.deactivate. This subsequently calls getReturnFocusNode in focus-trap. Therefore, we can’t get the containers for the next screen because when Screen B unmounts (after navigating from Screen A to Screen B), it sets the return focus node from Screen B’s context.

As a result, we can’t retrieve the containers for Screen A when Screen B unmounts. Instead, we can check if the active element is the default (document body). If it is, we can return false to ensure the focus trap does not interfere with the focus transition to Screen A. Otherwise, we keep the current focused element.

I have updated the code, and it covers the issue you mentioned above.

Works for me but let's also check if document.activeElement is null. In that case we want to return the focus as well

src/components/FocusTrap/FocusTrapForScreen/FocusTrapProps.ts

s77rt · 2024-07-08T23:36:07Z

patches/focus-trap+7.5.4.patch

+-var delay = function delay(fn) {
+-  return setTimeout(fn, 0);
+var delay = function delay(fn, delayTime = 0) {
+  return setTimeout(fn, delayTime);


The correct timing is 300ms (CONST.ANIMATED_TRANSITION). CONST.ANIMATION_IN_TIMING is not related to the screen transition.

…al-focus-trap

patches/focus-trap+7.5.4.patch

s77rt · 2024-07-13T12:14:28Z

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

-                // We don't want to ovverride autofocus on these screens.
-                initialFocus: () => {
-                    if (screensWithAutofocus.includes(activeRouteName)) {
+                delayInitialFocus: CONST.ANIMATED_TRANSITION + CONST.ANIMATION_IN_TIMING,


Suggested change

delayInitialFocus: CONST.ANIMATED_TRANSITION + CONST.ANIMATION_IN_TIMING,

delayInitialFocus: CONST.ANIMATED_TRANSITION,

s77rt · 2024-07-13T12:17:37Z

src/components/MoneyRequestConfirmationList.tsx

+                buttonRef={(ref) => {
+                    inputCallbackRef(ref);
+                }}


Suggested change

buttonRef={(ref) => {

inputCallbackRef(ref);

}}

buttonRef={inputCallbackRef}

s77rt · 2024-07-14T17:55:44Z

src/hooks/useAutoFocusInput.ts

 import {InteractionManager} from 'react-native';
 import CONST from '@src/CONST';
 import * as Expensify from '@src/Expensify';

+type FocusRef = View | TextInput | null;


Suggested change

type FocusRef = View | TextInput | null;

type FocusElement = View | TextInput | null;

NAB

s77rt · 2024-07-14T18:20:09Z

src/components/FocusTrap/FocusTrapForScreen/index.web.tsx

-                    if (screensWithAutofocus.includes(activeRouteName)) {
+                delayInitialFocus: CONST.ANIMATED_TRANSITION,
+                initialFocus: (focusTrapContainers) => {
+                    const hasFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));


Suggested change

const hasFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));

const isFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));

NAB

s77rt · 2024-07-14T18:27:06Z

Bug: After pressing Enter selecting the participant, the back button is focused initially

Screen.Recording.2024-07-14.at.7.23.33.PM.mov

suneox · 2024-07-15T09:47:04Z

Bug: After pressing Enter selecting the participant, the back button is focused initially

Screen.Recording.2024-07-14.at.7.23.33.PM.mov

@s77rt At the useAutoFocusInput hook, after the timeout for ANIMATED_TRANSITION finishes, we have logic to runAfterInteractions before triggering focus. This is the reason we should add more ANIMATION_IN_TIMING to delayInitialFocus from my previous change. So I think we need to extend the time for delayInitialFocus and leave a mention for this change to ensure the logic works correctly.

s77rt · 2024-07-15T15:40:30Z

@suneox We can't use ANIMATION_IN_TIMING as it's unrelated to screen transition it's for the popover opening duration. We need to figure out another solution for this

suneox · 2024-07-15T16:12:06Z

@suneox We can't use ANIMATION_IN_TIMING as it's unrelated to screen transition it's for the popover opening duration. We need to figure out another solution for this

@s77rt If we don't extend ANIMATION_IN_TIMING we need to create new promise function checkInitialFocus based on my alternative solution due to useAutoFocusInput using runAfterInteractions after delay with ANIMATED_TRANSITION and the function checkInitialFocus also must be applied runAfterInteractions, implementation look like that

                checkInitialFocus: (focusTrapContainers) => {
                    return new Promise((resolve) => {
                        InteractionManager.runAfterInteractions(() => {
                            const hasFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));
                            resolve(!hasFocusedElementInsideContainer);
                        });
                    });
                }

s77rt · 2024-07-15T19:53:54Z

@suneox How this works with the search input? Let's follow the same approach there

Screen.Recording.2024-07-15.at.8.53.16.PM.mov

suneox · 2024-07-16T09:26:14Z

@suneox How this works with the search input? Let's follow the same approach there

Screen.Recording.2024-07-15.at.8.53.16.PM.mov

@s77rt The text input from BaseSelectionList also focus after timeout ANIMATED_TRANSITION so my alternative solution can cover this case.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 540 to 552 in fb9ce79

    
           useFocusEffect( 
        
               useCallback(() => { 
        
                   if (textInputAutoFocus && shouldShowTextInput) { 
        
                       if (shouldDelayFocus) { 
        
                           focusTimeoutRef.current = setTimeout(focusTextInput, CONST.ANIMATED_TRANSITION); 
        
                       } else { 
        
                           focusTextInput(); 
        
                       } 
        
                   } 
        
                   return () => focusTimeoutRef.current && clearTimeout(focusTimeoutRef.current); 
        
               }, [shouldShowTextInput, textInputAutoFocus, shouldDelayFocus, focusTextInput]), 
        
           );

So, do you agree to implement my alternative solution to create a promise function and revert the current change, or should we just extend the delay time for the current code and leave a note explaining the reason for it?

s77rt · 2024-07-16T12:06:07Z

@suneox What I meant is to use the same focus approach used in the participants selection and use it in the confirmation page (do not use useAutoFocusInput)

…al-focus-trap

suneox · 2024-07-16T16:12:35Z

@suneox What I meant is to use the same focus approach used in the participants selection and use it in the confirmation page (do not use useAutoFocusInput)

I got it, that is the reason my initial change use useFocusEffect & useCallback to trigger focus, I will update asap

s77rt · 2024-07-16T17:47:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Build issue

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

chiragsalian

LGTM

OSBotify · 2024-07-16T19:22:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:20Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss · 2024-07-17T10:18:35Z

Hey @s77rt @suneox @chiragsalian, I think this PR might have introduced this issue (focus is skipping the login input field on the homepage).

It's not a blocker, but could you please take a look? Thanks

suneox · 2024-07-17T11:31:31Z

Hey @s77rt @suneox @chiragsalian, I think this PR might have introduced this issue (focus is skipping the login input field on the homepage).

It's not a blocker, but could you please take a look? Thanks

@Julesssss I'd like to confirm issue #45571 occurs by this PR because the input on BaseLoginForm doesn’t focus due to the condition canFocusInputOnScreenFocus, i'll update PR to fix in few hours

OSBotify · 2024-07-17T15:49:40Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-18T13:51:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T19:36:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

akinwale · 2024-08-05T18:47:27Z

This PR caused a regression.

The button has the pressOnEnter prop set to true, so manual focus is not required.

prevent initial focus trap while has a focused element.

a1587bb

suneox requested a review from a team as a code owner July 6, 2024 08:26

melvin-bot bot requested review from s77rt and removed request for a team July 6, 2024 08:26

suneox mentioned this pull request Jul 6, 2024

[HOLD for payment 2024-08-02] [HOLD for payment 2024-07-25] [$500] Web - Expense - Blue border selection on back icon RHP after hitting enter on BNP #43662

Closed

6 tasks

fix typecheck

21f134f

s77rt suggested changes Jul 6, 2024

View reviewed changes

suneox added 3 commits July 8, 2024 22:21

update code review

ecdc861

Merge remote-tracking branch 'upstream/main' into 43662-prevent-initi…

38e473d

…al-focus-trap

update delay time by constant

25ab7fd

s77rt suggested changes Jul 8, 2024

View reviewed changes

Clean up redundant code

08c6f03

Krishna2323 mentioned this pull request Jul 8, 2024

[HOLD for payment 2024-07-25] [$250] When pressing Enter in the amount page in submit expense flow the focus is on back button instead of on Submit button #44956

Closed

6 tasks

s77rt suggested changes Jul 8, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 43662-prevent-initi…

59496ce

…al-focus-trap

mountiny assigned suneox Jul 9, 2024

suneox added 2 commits July 11, 2024 01:46

handle set return focus

dc87814

Merge remote-tracking branch 'upstream/main' into 43662-prevent-initi…

8081861

…al-focus-trap

Ollyws mentioned this pull request Jul 10, 2024

fix: incorrect animation when accessing Referral detail page #45133

Closed

50 tasks

suneox added 4 commits July 11, 2024 14:03

remove debug log

bb24cd9

update code review

1e590d4

fix typecheck

c6e1bb6

update code review

3106ce8

s77rt suggested changes Jul 13, 2024

View reviewed changes

update code review

bd4a935

hoangzinh mentioned this pull request Jul 14, 2024

[HOLD for payment 2024-08-01] [$250] mWeb – Chat – Workspace switcher is with blue border after login #43713

Closed

6 tasks

s77rt reviewed Jul 14, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 43662-prevent-initi…

9686926

…al-focus-trap

update the submit button focusing behavior

367e62f

s77rt approved these changes Jul 16, 2024

View reviewed changes

melvin-bot bot requested a review from chiragsalian July 16, 2024 17:48

chiragsalian approved these changes Jul 16, 2024

View reviewed changes

chiragsalian merged commit 5991b8b into Expensify:main Jul 16, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

Julesssss mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-08-02] [$250] Login - Focus is shown on login field briefly and scrolled down #45571

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-07-25] [$250] Incorrect animation when accessing Referral information page #44745

Closed

6 tasks

akinwale mentioned this pull request Aug 5, 2024

[HOLD for payment 2024-08-05] [$250] Track Expense - Blue Border Appears on the Track Expense Button #45570

Closed

6 tasks

bernhardoj mentioned this pull request Jan 24, 2025

Update focus trap #55285

Merged

50 tasks

	const hasFocusedElement = containers?.some((container) => container.contains(document.activeElement));
	const isFocusedElementWithinFocusTrapContainer = containers?.some((container) => container.contains(document.activeElement));

	+ return setTimeout(fn, delayTime);
	+ return setTimeout(() => setTimeout(fn, delayTime), 0);

	delayInitialFocus: CONST.ANIMATED_TRANSITION + CONST.ANIMATION_IN_TIMING,
	delayInitialFocus: CONST.ANIMATED_TRANSITION,

	type FocusRef = View \| TextInput \| null;
	type FocusElement = View \| TextInput \| null;

	const hasFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));
	const isFocusedElementInsideContainer = focusTrapContainers?.some((container) => container.contains(document.activeElement));

prevent initial focus trap while has a focused element. #44932

prevent initial focus trap while has a focused element. #44932

Conversation

suneox commented Jul 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

suneox Jul 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountiny commented Jul 8, 2024

s77rt commented Jul 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented Jul 14, 2024

suneox commented Jul 15, 2024

s77rt commented Jul 15, 2024

suneox commented Jul 15, 2024 • edited Loading

s77rt commented Jul 15, 2024

suneox commented Jul 16, 2024

s77rt commented Jul 16, 2024

suneox commented Jul 16, 2024

s77rt commented Jul 16, 2024

Reviewer Checklist

Screenshots/Videos

chiragsalian left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 16, 2024

OSBotify commented Jul 17, 2024

Julesssss commented Jul 17, 2024

suneox commented Jul 17, 2024 • edited Loading

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

akinwale commented Aug 5, 2024

suneox commented Jul 6, 2024 •

edited

Loading

suneox Jul 12, 2024 •

edited

Loading

suneox commented Jul 15, 2024 •

edited

Loading

suneox commented Jul 17, 2024 •

edited

Loading