fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416

Krishna2323 · 2024-06-25T22:25:13Z

Details

Fixed Issues

$ #43945
PROPOSAL: #43945 (comment)

Tests

Tap fab -- submit expense
Select JOD currency
Enter an amount with 2 decimal place eg: 56788.56
Try to enter in 3rd decimal place, and note user not allowed to enter
Tap next and select a workspace
Verify that the amount in IOU confirmation page has 2 decimal places

Verify that no errors appear in the JS console

Offline tests

Tap fab -- submit expense
Select JOD currency
Enter an amount with 2 decimal place eg: 56788.56
Try to enter in 3rd decimal place, and note user not allowed to enter
Tap next and select a workspace
Verify that the amount in IOU confirmation page has 2 decimal places

QA Steps

Tap fab -- submit expense
Select JOD currency
Enter an amount with 2 decimal place eg: 56788.56
Try to enter in 3rd decimal place, and note user not allowed to enter
Tap next and select a workspace
Verify that the amount in IOU confirmation page has 2 decimal places

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…n IOU confirmation page. Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-06-25T22:25:17Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-06-25T23:17:55Z

src/libs/CurrencyUtils.ts

@@ -125,7 +125,8 @@ function convertToDisplayString(amountInCents = 0, currency: string = CONST.CURR

        // We are forcing the number of decimals because we override the default number of decimals in the backend for RSD
        // See: https://github.com/Expensify/PHP-Libs/pull/834
-        minimumFractionDigits: currency === 'RSD' ? getCurrencyDecimals(currency) : undefined,
+        minimumFractionDigits: getCurrencyDecimals(currency),


@rayane-djouah, we also need to set minimumFractionDigits, passing maximumFractionDigits without minimumFractionDigits crashes the app on android native. I believe we can simply use getCurrencyDecimals(currency), since it returns the correct value for currencies and the max is 2.

Hmm, test is failing, I will check for other solutions tomorrow.

Is there any reason for the crash on Android native? What error are you getting?

@rayane-djouah, no error is shown, the app just closes without providing minimumFractionDigits.

Can you try to see in Android studios Logcat what error causes the app to crash?

@rayane-djouah, sorry for delay, I tried but couldn't find Android studios Logcat, I haven't used it till now, can you pls tell me where I can find it?

Select View > Tool Windows > Logcat from the menu bar.

https://developer.android.com/studio/debug/logcat
https://developer.android.com/studio/debug/stacktraces

I tried debugging the crash, but I saw no error.
Looks like this was faced before here: #43128 (comment)

Based on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat#minimumfractiondigits :

the default for currency formatting is the larger of minimumFractionDigits and the number of minor unit digits provided by the ISO 4217 currency code list (2 if the list doesn't provide that information)

So it has the same behavior as getCurrencyDecimals 👍 We should be safe to use it instead of undefined

rayane-djouah

Please apply the same fix here also :

App/src/libs/CurrencyUtils.ts

Lines 167 to 184 in 51dd814

    
           /** 
        
            * Acts the same as `convertAmountToDisplayString` but the result string does not contain currency 
        
            */ 
        
           function convertToDisplayStringWithoutCurrency(amountInCents: number, currency: string = CONST.CURRENCY.USD) { 
        
               const convertedAmount = convertToFrontendAmountAsInteger(amountInCents); 
        
               return NumberFormatUtils.formatToParts(BaseLocaleListener.getPreferredLocale(), convertedAmount, { 
        
                   style: 'currency', 
        
                   currency, 
        
                   // We are forcing the number of decimals because we override the default number of decimals in the backend for RSD 
        
                   // See: https://github.com/Expensify/PHP-Libs/pull/834 
        
                   minimumFractionDigits: currency === 'RSD' ? getCurrencyDecimals(currency) : undefined, 
        
               }) 
        
                   .filter((x) => x.type !== 'currency') 
        
                   .filter((x) => x.type !== 'literal' || x.value.trim().length !== 0) 
        
                   .map((x) => x.value) 
        
                   .join(''); 
        
           }

src/libs/CurrencyUtils.ts

rayane-djouah

Please update the test case for BHD to fix the failing test

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-07-09T23:23:18Z

Please apply the same fix here also :
Please update the test case for BHD to fix the failing test

@rayane-djouah, applied the fix for convertToDisplayStringWithoutCurrency and test case updated.

rayane-djouah · 2024-07-09T23:31:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-09.at.10.40.13.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-09.at.10.43.48.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-09.at.22.31.21.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-09.at.22.27.24.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-09.at.10.23.37.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-09.at.10.44.39.PM.mov

rayane-djouah

Looks good!

OSBotify · 2024-07-10T17:21:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:04:17Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:13:01Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:18:46Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:49:38Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: IOU - On entering amount with decimals, 3rd decimal 0 is added i…

98ebb2b

…n IOU confirmation page. Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner June 25, 2024 22:25

melvin-bot bot removed the request for review from a team June 25, 2024 22:25

melvin-bot bot requested a review from rayane-djouah June 25, 2024 22:25

Krishna2323 added 2 commits June 26, 2024 04:40

fix for android native.

d8054b9

Signed-off-by: Krishna Gupta <[email protected]>

fix for android native.

96d38de

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 commented Jun 25, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/43945

5c09225

rayane-djouah suggested changes Jul 9, 2024

View reviewed changes

src/libs/CurrencyUtils.ts Outdated Show resolved Hide resolved

src/libs/CurrencyUtils.ts Show resolved Hide resolved

rayane-djouah suggested changes Jul 9, 2024

View reviewed changes

Krishna2323 added 2 commits July 10, 2024 04:44

Merge branch 'Expensify:main' into krishna2323/issue/43945

189c3a3

fix tests.

0747007

Signed-off-by: krishna2323 <[email protected]>

rayane-djouah approved these changes Jul 9, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam July 9, 2024 23:32

thienlnam approved these changes Jul 10, 2024

View reviewed changes

thienlnam merged commit 2b2a2e0 into Expensify:main Jul 10, 2024
15 of 17 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

melvin-bot bot mentioned this pull request Jul 17, 2024

[C+ Checklist Needs Completion] [$250] IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page #43945

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416

fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416

Krishna2323 commented Jun 25, 2024 •

edited

Loading

melvin-bot bot commented Jun 25, 2024

Krishna2323 Jun 25, 2024

Krishna2323 Jun 25, 2024

rayane-djouah Jun 26, 2024

Krishna2323 Jun 26, 2024

rayane-djouah Jun 26, 2024

Krishna2323 Jul 1, 2024

rayane-djouah Jul 8, 2024

rayane-djouah Jul 9, 2024

rayane-djouah left a comment

rayane-djouah left a comment •

edited

Loading

Krishna2323 commented Jul 9, 2024

rayane-djouah commented Jul 9, 2024

rayane-djouah left a comment

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

	/**
	* Acts the same as `convertAmountToDisplayString` but the result string does not contain currency
	*/
	function convertToDisplayStringWithoutCurrency(amountInCents: number, currency: string = CONST.CURRENCY.USD) {
	const convertedAmount = convertToFrontendAmountAsInteger(amountInCents);
	return NumberFormatUtils.formatToParts(BaseLocaleListener.getPreferredLocale(), convertedAmount, {
	style: 'currency',
	currency,

	// We are forcing the number of decimals because we override the default number of decimals in the backend for RSD
	// See: https://github.com/Expensify/PHP-Libs/pull/834
	minimumFractionDigits: currency === 'RSD' ? getCurrencyDecimals(currency) : undefined,
	})
	.filter((x) => x.type !== 'currency')
	.filter((x) => x.type !== 'literal' \|\| x.value.trim().length !== 0)
	.map((x) => x.value)
	.join('');
	}

fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416

fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416

Conversation

Krishna2323 commented Jun 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah left a comment • edited Loading

Choose a reason for hiding this comment

Krishna2323 commented Jul 9, 2024

rayane-djouah commented Jul 9, 2024

Reviewer Checklist

Screenshots/Videos

rayane-djouah left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

Krishna2323 commented Jun 25, 2024 •

edited

Loading

rayane-djouah left a comment •

edited

Loading