fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300

ishpaul777 · 2024-06-24T19:46:37Z

Details

Fixed Issues

$ #44194
PROPOSAL: #44194 (comment)

Tests

Verify that no errors appear in the JS console

Go to staging.new.expensify.com
Go to any room chat
Click on the chat header
Click Room description
Edit room description and save it
Wait for the room description system message to show up in the chat
Look at the room chat LHN preview

Expected Result:

Room chat LHN preview will display room description edit system message

Change prefered language to Spanish, Verify LHN preview and system message will display room description edit system message in spanish language.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Not able to build android , sorry : (

Android: mWeb Chrome

WhatsApp.Video.2024-06-25.at.12.36.34.AM.mp4

iOS: Native

Screen.Recording.2024-06-25.at.12.25.45.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-06-25.at.12.24.13.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-25.at.12.19.42.AM.mov

MacOS: Desktop

ishpaul777 · 2024-06-24T20:01:02Z

src/libs/SidebarUtils.ts

@@ -352,6 +352,9 @@ function getOptionData({
                        : ` ${Localize.translate(preferredLocale, 'workspace.invite.from')}`;
                result.alternateText += `${preposition} ${roomName}`;
            }
+            if (lastActionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
+                result.alternateText = `${lastActorDisplayName} set the room description to : ${lastActionOriginalMessage?.description}`;


I have no idea in what case lastActorDisplayName is displayed, its used it all above actions but in all cases i tested its empty string.

I think that's fine yeah

wait then this would cause a regression right? it would display empty string in the place of lastActorDisplayName @ishpaul777 ?

Also, won't we also need a spanish copy of the same here?

I am not sure if should translate becuase its not a translated message in chat

I am not sure if should translate becuase its not a translated message in chat

Umm good point, won't look good on the UI, cool then i will proceed with the review

I am just going to add translation for chat message

If it makes the product better and you are ready to take the extra effort, i would be more than happy to review it :))

just pinging @yuwenmemon so that he also knows this

I will complete the review as this PR is technically complete, if we need to alter the text that is not a big game, thanks @ishpaul777 🚀

haha i did think that the following was misinterpreted:

I have no idea in what case lastActorDisplayName is displayed, its used it all above actions but in all cases i tested its empty string.

I think that's fine yeah

@ishpaul777 can you have a look here once, we will discuss this further

melvin-bot · 2024-06-24T20:14:46Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-06-24T20:52:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf

LGTM

OSBotify · 2024-06-25T04:42:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2024-06-25T05:10:23Z

src/pages/home/report/ReportActionItem.tsx

@@ -623,6 +623,9 @@ function ReportActionItem({
            children = <ReportActionItemBasicMessage message={translate('iou.unheldExpense')} />;
        } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.MERGED_WITH_CASH_TRANSACTION) {
            children = <ReportActionItemBasicMessage message={translate('systemMessage.mergedWithCashTransaction')} />;
+        } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {


@ishpaul777 check out all the is$ACTION_TYPEAction utility functions in ReportActionUtils. You can use type predicates to narrow the type of a report action, and thus avoid having to do any type casting.

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " (cherry picked from commit 9ee8806)

OSBotify · 2024-06-25T05:49:35Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.1-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-06-25T19:46:35Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allgandalf · 2024-07-29T04:51:46Z

src/libs/SidebarUtils.ts

@@ -352,6 +352,11 @@ function getOptionData({
                        : ` ${Localize.translate(preferredLocale, 'workspace.invite.from')}`;
                result.alternateText += `${preposition} ${roomName}`;
            }
+            if (lastActionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {


We missed the case if the room description is markdown/html/emojis, this overlook caused #44448.

Never thought that i would have to comment on the PR that i myself reviewed 😆 . I agree that this should had been noticed during testing but it was missed, i will be more careful moving forward

hungvu193 · 2024-08-08T04:11:06Z

src/libs/SidebarUtils.ts

+                result.alternateText = `${lastActorDisplayName} ${Localize.translate(preferredLocale, 'roomChangeLog.updateRoomDescription')} ${
+                    lastActionOriginalMessage?.description
+                }`.trim();
+            }


We always display set the room description to: here and it caused this bug .
More detail in this comment: #45522 (comment)

Opps, I was perhaps not in my best mind while reviewing this PR 😓 , thanks for pointing that out @hungvu193 🙌

Edit:

ahh now that i look at the original issue, i recall that this was the last deploy blocker and needed to be reviewed quickly hence the hurry to deploy caused the quality of the PR to come done, honest mistake 😅

fixes the issue

4552845

ishpaul777 commented Jun 24, 2024

View reviewed changes

ishpaul777 marked this pull request as ready for review June 24, 2024 20:14

ishpaul777 requested a review from a team as a code owner June 24, 2024 20:14

melvin-bot bot removed the request for review from a team June 24, 2024 20:14

melvin-bot bot requested a review from allgandalf June 24, 2024 20:14

ishpaul777 changed the title ~~fixes the issue~~ fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " Jun 24, 2024

ishpaul777 added 2 commits June 25, 2024 01:49

fixes empty string

28492c4

fixes translation for room description

a018b79

allgandalf approved these changes Jun 24, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon June 24, 2024 22:25

yuwenmemon approved these changes Jun 25, 2024

View reviewed changes

yuwenmemon merged commit 9ee8806 into Expensify:main Jun 25, 2024
16 of 18 checks passed

roryabraham reviewed Jun 25, 2024

View reviewed changes

OSBotify pushed a commit that referenced this pull request Jun 25, 2024

Merge pull request #44300 from ishpaul777/fix/44194

7e8c2e4

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " (cherry picked from commit 9ee8806)

github-actions bot mentioned this pull request Jun 25, 2024

Deploy Checklist: New Expensify 2024-06-21 #44186

Closed

melvin-bot bot mentioned this pull request Jun 25, 2024

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] Room - Room chat LHN preview displays "removed 0 user" after editing room description #44194

Closed

6 tasks

bernhardoj mentioned this pull request Jun 26, 2024

[HOLD for payment 2024-08-02] [$250] mWeb - Room - System message for room description with markdown is shown as html code #44448

Closed

6 tasks

dominictb mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-24] Thread - LHN displays "removed 1 user" instead of "left the chat" after leaving thread #44610

Closed

6 tasks

allgandalf reviewed Jul 29, 2024

View reviewed changes

hungvu193 reviewed Aug 8, 2024

View reviewed changes

hungvu193 mentioned this pull request Aug 8, 2024

[$250] [HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] Room - System message for clearing room description is copied differently #45522

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300

ishpaul777 commented Jun 24, 2024 •

edited

Loading

ishpaul777 Jun 24, 2024 •

edited

Loading

yuwenmemon Jun 24, 2024

allgandalf Jun 24, 2024

allgandalf Jun 24, 2024

ishpaul777 Jun 24, 2024

allgandalf Jun 24, 2024

ishpaul777 Jun 24, 2024 •

edited

Loading

allgandalf Jun 24, 2024

allgandalf Jun 24, 2024

allgandalf Jun 24, 2024 •

edited

Loading

melvin-bot bot commented Jun 24, 2024

allgandalf commented Jun 24, 2024 •

edited

Loading

allgandalf left a comment

OSBotify commented Jun 25, 2024

roryabraham Jun 25, 2024

OSBotify commented Jun 25, 2024

OSBotify commented Jun 25, 2024

allgandalf Jul 29, 2024

hungvu193 Aug 8, 2024

allgandalf Aug 8, 2024 •

edited

Loading

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300

fixes the "Room chat LHN preview displays "removed 0 user" after editing room description " #44300

Conversation

ishpaul777 commented Jun 24, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishpaul777 Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allgandalf Jun 24, 2024 • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Jun 24, 2024

allgandalf commented Jun 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 25, 2024

Choose a reason for hiding this comment

OSBotify commented Jun 25, 2024

OSBotify commented Jun 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allgandalf Aug 8, 2024 • edited Loading

Choose a reason for hiding this comment

ishpaul777 commented Jun 24, 2024 •

edited

Loading

ishpaul777 Jun 24, 2024 •

edited

Loading

ishpaul777 Jun 24, 2024 •

edited

Loading

allgandalf Jun 24, 2024 •

edited

Loading

allgandalf commented Jun 24, 2024 •

edited

Loading

allgandalf Aug 8, 2024 •

edited

Loading