-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: split amount is put into a second line #43624
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cc7cf38
fix: 42117
tienifr 1daed97
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr caeb829
fix lint
tienifr e94ff4a
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr 46a068b
apply changes for web
tienifr f45b45a
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr 9a95dcd
remove undefined default prop
tienifr abc73ae
compute contentWidth based on the longest amount
tienifr 3f1c835
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr ba7a016
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr c628722
reduce fixed digit amount to 8
tienifr 920dc1d
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr a02e906
Merge branch 'main' of https://github.com/tienifr/App into fix/42117
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier we assumed each digit occupies
9px
then multiply the total amount with9
to compute the content width. That's to make sure the all the split input widths are equal and are the longest possible number length which assumingly is the total amount.But since the paddings, margins... are no longer inclusive in this content width, in case the total amount has more digits than the individual split amount, we would have a larger input width.
So I kept the old requirement: the split input widths are equal and are the longest possible number length but the longest possible number now is not based on the total amount but the individual split amount.