Fix timerow should update on Language changes. #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
commented
Aug 2, 2021
| componentWillUnmount() { | ||
| clearInterval(this.timer); | ||
| clearInterval(this.readyTimer); |
There was a problem hiding this comment.
Extra. Don't see any readytimer.
|
Requesting review @nkuoch. |
nkuoch
approved these changes
Aug 2, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Aug 2, 2021
|
🚀 Deployed to staging in version: 1.0.82-8🚀
|
|
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Removed usages of
ShouldComponentUpdateand usedPureComponent. On change the Language the Callback passed as props from the WithLocalize HOC will not cause a render due to the currentShouldComponentUpdateonly check for state changes. but this is a perfect example of using the Pure Component.Fixed Issues
$ #4352
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android