Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" #43223

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ishpaul777
Copy link
Contributor

@ishpaul777 ishpaul777 commented Jun 6, 2024

Reverts #42450

Fixes #43216

@mountiny mountiny changed the title Revert "fix: Error message only changes after clicking Split expense button for the second time" [CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" Jun 6, 2024
@mountiny mountiny marked this pull request as ready for review June 6, 2024 21:06
@mountiny mountiny requested a review from a team as a code owner June 6, 2024 21:06
@melvin-bot melvin-bot bot removed the request for review from a team June 6, 2024 21:06
Copy link

melvin-bot bot commented Jun 6, 2024

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from yuwenmemon June 6, 2024 21:06
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for verifying this, testing real quick too

@mountiny
Copy link
Contributor

mountiny commented Jun 6, 2024

Screen.Recording.2024-06-06.at.23.15.42.mov

@mountiny
Copy link
Contributor

mountiny commented Jun 6, 2024

Straight revert

@mountiny mountiny merged commit c03bdc6 into Expensify:main Jun 6, 2024
13 of 16 checks passed
@melvin-bot melvin-bot bot added the Emergency label Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Jun 6, 2024
@mountiny
Copy link
Contributor

mountiny commented Jun 6, 2024

Straight revert, asked for CP, not emergency

OSBotify pushed a commit that referenced this pull request Jun 6, 2024
[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time"

(cherry picked from commit c03bdc6)
@OSBotify
Copy link
Contributor

OSBotify commented Jun 6, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants