-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" #43223
Conversation
…button for the second time"
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for verifying this, testing real quick too
Screen.Recording.2024-06-06.at.23.15.42.mov |
Straight revert |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert, asked for CP, not emergency |
[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" (cherry picked from commit c03bdc6)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Reverts #42450
Fixes #43216