Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staging due to undefined Onyx key #4286

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix staging due to undefined Onyx key #4286

merged 1 commit into from
Jul 28, 2021

Conversation

marcaaron
Copy link
Contributor

Details

Fixed Issues

$ #4284

Tests

QA Steps

  1. Log out
  2. Sign in
  3. Verify it works ok

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from luacmartins July 28, 2021 22:10
@marcaaron marcaaron requested a review from a team as a code owner July 28, 2021 22:10
@marcaaron marcaaron self-assigned this Jul 28, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 28, 2021 22:10
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron removed the request for review from jasperhuangg July 28, 2021 22:10
luacmartins
luacmartins approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcaaron marcaaron merged commit e864cf8 into main Jul 28, 2021
@marcaaron marcaaron deleted the marcaaron-fixUsagesOfPreferredLocale branch July 28, 2021 22:56
github-actions bot pushed a commit that referenced this pull request Jul 28, 2021
@marcaaron
Merge pull request #4286 from Expensify/marcaaron-fixUsagesOfPreferre…
bc0340d 
…dLocale

Fix staging due to undefined Onyx key

(cherry picked from commit e864cf8)
This was referenced Jul 28, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@iwiznia iwiznia mentioned this pull request Jul 29, 2021
Merged
5 tasks
@OSBotify OSBotify mentioned this pull request Jul 30, 2021
Closed
100 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Aug 6, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
@DylanDylann DylanDylann mentioned this pull request Jan 23, 2025
Merged
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @luacmartins