Fix: missing avatars and names above IOU preview in main chat after login #42453

nkdengineer · 2024-05-22T05:20:48Z

Details

Fixed Issues

$ #38702
PROPOSAL: #38702 (comment)

Tests

Precondition:

User A and B have no prior chat with each other
User B must be logged out

[User A] Request money from User B
[User B] Paid this money request
[User A] Clear cache and restart (or logout and login again)
[User A] Open the DM chat with user B without opening the iou report
Verify that the report preview display correctly avatars of two users and the checkmark icon is displayed which mean it is settled.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Precondition:

User A and B have no prior chat with each other
User B must be logged out

[User A] Request money from User B
[User B] Paid this money request
[User A] Clear cache and restart (or logout and login again)
[User A] Open the DM chat with user B without opening the iou report
Verify that the report preview display correctly avatars of two users and the checkmark icon is displayed which mean it is settled.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-12.at.11.02.22.mov

Android: mWeb Chrome

Screen.Recording.2024-06-12.at.11.01.24.mov

iOS: Native

Screen.Recording.2024-06-12.at.11.08.18.mov

iOS: mWeb Safari

Screen.Recording.2024-06-12.at.11.06.13.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-12.at.10.59.30.mov

MacOS: Desktop

Screen.Recording.2024-06-12.at.11.11.16.mov

youssef-lr · 2024-06-11T20:15:13Z

@nkdengineer this should be ready for review, but not merging. the fix is on staging so we can test now.

youssef-lr · 2024-06-11T20:15:43Z

Also, conflicts :)

youssef-lr · 2024-06-12T03:09:28Z

it just hit me, do we rely on the IOU report to show the total? if yes then I think we should start including that in the settled IOUs previews. As for the current IOU report, will be fetched as part of OpenReport soon.

melvin-bot · 2024-06-12T04:16:04Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

youssef-lr · 2024-06-12T04:20:49Z

it just hit me, do we rely on the IOU report to show the total? if yes then I think we should start including that in the settled IOUs previews. As for the current IOU report, will be fetched as part of OpenReport soon.

Actually nvm, we get it from the report action message

App/src/components/ReportActionItem/ReportPreview.tsx

Line 178 in 774a3ec

    
           // If iouReport is not available, get amount from the action message (Ex: "Domain20821's Workspace owes $33.00" or "paid ₫60" or "paid -₫60 elsewhere")

nkdengineer · 2024-06-12T04:25:42Z

it just hit me, do we rely on the IOU report to show the total? if yes then I think we should start including that in the settled IOUs previews. As for the current IOU report, will be fetched as part of OpenReport soon.

@youssef-lr What action do we want to do in this case?

youssef-lr · 2024-06-12T04:27:45Z

nothing, we get the total from the message in that case, it's already implemented

nkdengineer · 2024-06-12T04:29:29Z

Thanks.

nkdengineer · 2024-06-18T03:11:55Z

@eVoloshchak please take a look at this PR

eVoloshchak · 2024-06-19T15:35:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-06-20-14-59-53.mp4

Android: mWeb Chrome

Screen.Recording.2024-06-20.at.14.58.17.mov

iOS: Native

Screen.Recording.2024-06-20.at.15.02.49.mov

iOS: mWeb Safari

Screen.Recording.2024-06-20.at.15.04.31.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-20.at.14.46.48.mov

MacOS: Desktop

Screen.Recording.2024-06-20.at.15.10.14.mov

src/pages/home/report/ReportActionItemSingle.tsx

eVoloshchak · 2024-06-19T15:54:12Z

src/libs/ReportUtils.ts

@@ -772,8 +772,11 @@ function isReportManager(report: OnyxEntry<Report>): boolean {
 /**
 * Checks if the supplied report has been approved
 */
-function isReportApproved(reportOrID: OnyxInputOrEntry<Report> | string | EmptyObject): boolean {
+function isReportApproved(reportOrID: OnyxInputOrEntry<Report> | string | EmptyObject, parentReportAction: OnyxEntry<ReportAction> = undefined): boolean {


Why do we need to specifically set the parentReportAction default value as undefined?

@eVoloshchak Some other places we can use this function without parentReportAction param.

Where is this used in this PR?

Co-authored-by: Eugene Voloshchak <[email protected]>

eVoloshchak · 2024-06-20T13:16:52Z

Noting that the app hangs when doing Clear cache and restart on a high traffic account, so had to use log-out/relaunch the app as a main testing method
Tests well!

nkdengineer · 2024-06-22T08:34:32Z

src/components/ReportActionItem/ReportPreview.tsx

    const moneyRequestComment = action?.childLastMoneyRequestComment ?? '';
    const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(chatReport);
    const isOpenExpenseReport = isPolicyExpenseChat && ReportUtils.isOpenExpenseReport(iouReport);

-    const isApproved = ReportUtils.isReportApproved(iouReport);
+    const isApproved = ReportUtils.isReportApproved(iouReport, action);


@youssef-lr We use it here.

youssef-lr

LGTM!

OSBotify · 2024-06-26T07:24:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T19:37:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:54:38Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkdengineer and others added 4 commits May 14, 2024 12:21

Use report preview action to display data in ReportPreview

7957804

Merge branch 'Expensify:main' into fix/38702

bf6a6e7

fix: add fallback report action child owner account id

0f7a6ed

fix lint

1dd2daf

nkdengineer mentioned this pull request May 22, 2024

[HOLD for payment 2024-07-10] [$500] IOU - Missing avatars and names above IOU preview in main chat after login #38702

Closed

6 tasks

nkdengineer changed the title ~~Fix: missing avatars and names above IOU preview in main chat after login~~ [Hold BE] Fix: missing avatars and names above IOU preview in main chat after login Jun 4, 2024

merge main

16fea0b

merge main

159fce2

fix lint

32f869d

nkdengineer changed the title ~~[Hold BE] Fix: missing avatars and names above IOU preview in main chat after login~~ Fix: missing avatars and names above IOU preview in main chat after login Jun 12, 2024

nkdengineer marked this pull request as ready for review June 12, 2024 04:15

nkdengineer requested a review from a team as a code owner June 12, 2024 04:15

melvin-bot bot requested review from eVoloshchak and removed request for a team June 12, 2024 04:16

merge main

9106ecf

eVoloshchak suggested changes Jun 19, 2024

View reviewed changes

Update src/pages/home/report/ReportActionItemSingle.tsx

e311c10

Co-authored-by: Eugene Voloshchak <[email protected]>

eVoloshchak approved these changes Jun 20, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr June 20, 2024 13:17

nkdengineer added 3 commits June 21, 2024 10:42

Merge branch 'main' into fix/38702

b2d9fe0

Merge branch 'main' into fix/38702

792ca7b

pass action to isReportApproved

a2a7393

nkdengineer commented Jun 22, 2024

View reviewed changes

youssef-lr approved these changes Jun 26, 2024

View reviewed changes

youssef-lr merged commit 57e5d0e into Expensify:main Jun 26, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 27, 2024

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

85 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: missing avatars and names above IOU preview in main chat after login #42453

Fix: missing avatars and names above IOU preview in main chat after login #42453

nkdengineer commented May 22, 2024 •

edited

Loading

youssef-lr commented Jun 11, 2024

youssef-lr commented Jun 11, 2024

youssef-lr commented Jun 12, 2024

melvin-bot bot commented Jun 12, 2024

youssef-lr commented Jun 12, 2024

nkdengineer commented Jun 12, 2024

youssef-lr commented Jun 12, 2024

nkdengineer commented Jun 12, 2024

nkdengineer commented Jun 18, 2024

eVoloshchak commented Jun 19, 2024 •

edited

Loading

eVoloshchak Jun 19, 2024

nkdengineer Jun 19, 2024

youssef-lr Jun 21, 2024

eVoloshchak commented Jun 20, 2024 •

edited

Loading

nkdengineer Jun 22, 2024

youssef-lr left a comment

OSBotify commented Jun 26, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

Fix: missing avatars and names above IOU preview in main chat after login #42453

Fix: missing avatars and names above IOU preview in main chat after login #42453

Conversation

nkdengineer commented May 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

youssef-lr commented Jun 11, 2024

youssef-lr commented Jun 11, 2024

youssef-lr commented Jun 12, 2024

melvin-bot bot commented Jun 12, 2024

youssef-lr commented Jun 12, 2024

nkdengineer commented Jun 12, 2024

youssef-lr commented Jun 12, 2024

nkdengineer commented Jun 12, 2024

nkdengineer commented Jun 18, 2024

eVoloshchak commented Jun 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak Jun 19, 2024

Choose a reason for hiding this comment

nkdengineer Jun 19, 2024

Choose a reason for hiding this comment

youssef-lr Jun 21, 2024

Choose a reason for hiding this comment

eVoloshchak commented Jun 20, 2024 • edited Loading

nkdengineer Jun 22, 2024

Choose a reason for hiding this comment

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 26, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 10, 2024

nkdengineer commented May 22, 2024 •

edited

Loading

eVoloshchak commented Jun 19, 2024 •

edited

Loading

eVoloshchak commented Jun 20, 2024 •

edited

Loading