Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Center new expensify icon in about page" #4241

Closed
wants to merge 1 commit into from
Closed

Revert "Center new expensify icon in about page" #4241

wants to merge 1 commit into from

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jul 26, 2021 •
edited
Loading

Reverts #4180 to fix #4207

Tests / QA Steps

  1. Go to Settings -> Preferences
  2. Drop-downs should not be horizontally centered and wonky.

Screenshots

Web

image

@roryabraham roryabraham self-assigned this Jul 26, 2021
@roryabraham roryabraham requested a review from a team as a code owner July 26, 2021 23:58
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 26, 2021 23:58
@roryabraham roryabraham requested a review from robertjchen July 27, 2021 00:15
@roryabraham
Copy link
Contributor Author

@robertjchen will you please review this since this fixes and hourly and it's 2am for @Dal-Papa ?

@roryabraham roryabraham removed the request for review from Dal-Papa July 27, 2021 00:16
This was referenced Jul 27, 2021
Closed
Closed
@roryabraham roryabraham deleted the revert-4180-bugfix/center_new_expensify_icon_in_about_page branch July 6, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertjchen robertjchen robertjchen approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web - Settings - Dropdown symbol overlaps with text in the box
3 participants
@roryabraham @OSBotify @robertjchen