Fix: infinite skeleton loading when delete concierge task #42022

vradriano · 2024-05-11T23:45:12Z

Details

This PR fixes the eternal skeleton issue that occurs after a user deletes a subtask of concierge. It adds the parentReportActionId to prevent malformed objects.

Fixed Issues

$ #40918
PROPOSAL: #40918 (comment)

Tests

Create account and login
Select one of these categories displayed at the first modal(What do you want to do today?)
Fill in the First and Last Name.
Go to Concierge chat, select one of their subtask
At the task, go to the Header, select the three dots, and delete it
You must go back automatically to the Concierge chat without any error

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create account and login
Select one of these categories displayed at the first modal(What do you want to do today?)
Fill in the First and Last Name.
Go to Concierge chat, select one of their subtask
At the task, go to the Header, select the three dots, and delete it
You must go back automatically to the Concierge chat without any error

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-mwebsafari.mov

MacOS: Chrome / Safari

macos-safari.mov

MacOS: Desktop

electron.mov

github-actions · 2024-05-11T23:45:28Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2024-05-11T23:45:39Z

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

vradriano · 2024-05-11T23:48:14Z

I have read the CLA Document and I hereby sign the CLA

tgolen · 2024-05-13T12:59:21Z

@eh2077 It looks like you are the C+ for this issue. I'm not sure why it didn't assign you so I have manually added you to take the first pass on this PR.

eh2077 · 2024-05-13T16:17:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mobile-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mobile-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/libs/actions/Report.ts

eh2077 · 2024-05-13T17:00:38Z

@vradriano Please make sure your commits are signed, see https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#begin-coding-your-solution-in-a-pull-request.

Please follow following format to link issue and proposal

<!---
1. Please postfix `$` with a URL link to the GitHub issue this Pull Request is fixing. For example, `$ https://github.com/Expensify/App/issues/<issueID>`.
2. Please postfix  `PROPOSAL:` with a URL link to your GitHub comment, which contains the approved proposal (i.e. the proposal that was approved by Expensify).  For example, `PROPOSAL: https://github.com/Expensify/App/issues/<issueID>#issuecomment-1369752925`

Do NOT add the special GH keywords like `fixed` etc, we have our own process of managing the flow.
It MUST be an entire link to the github issue and your comment proposal ; otherwise, the linking and its automation will not work as expected.

Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line):

$ https://github.com/Expensify/App/issues/<issueID>
$ https://github.com/Expensify/App/issues/<issueID(comment)>

Do NOT only link the issue number like this: $ #<issueID>
--->

vradriano · 2024-05-13T17:49:36Z

@eh2077 Mb. I think everything is okay now.

eh2077 · 2024-05-13T18:04:43Z

Not sure why the CI is pending.

@tgolen Can you help to trigger run workflows? Thanks

tgolen · 2024-05-13T18:48:43Z

Sure, no worries. They have to be manually triggered on a contributor's first PR.

tgolen · 2024-05-13T18:49:55Z

@vradriano You will need to go back and resign all your commits though.

vradriano · 2024-05-13T19:20:14Z

@tgolen i'm not sure if i did it right, can you confirm it for me? Thanks

tgolen · 2024-05-13T19:34:17Z

Looks good! I'll see if all the tests will pass then merge this.

tgolen · 2024-05-14T14:42:40Z

I checked each test manually and it looks like they all passed even though they are still showing as queued in this PR.

melvin-bot · 2024-05-14T14:42:51Z

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-05-14T14:51:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:15:56Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-23T00:00:57Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

vradriano requested a review from a team as a code owner May 11, 2024 23:45

melvin-bot bot requested review from tgolen and removed request for a team May 11, 2024 23:45

tgolen requested a review from eh2077 May 13, 2024 12:58

eh2077 reviewed May 13, 2024

View reviewed changes

src/libs/actions/Report.ts Outdated Show resolved Hide resolved

vradriano requested a review from eh2077 May 13, 2024 17:46

tgolen previously approved these changes May 13, 2024

View reviewed changes

ISSUE - 40918: Fix infinite skeleton loading when delete concierge task

e54dcc0

vradriano dismissed tgolen’s stale review via e54dcc0 May 13, 2024 19:03

vradriano force-pushed the issue/40918 branch from 5a90e76 to e54dcc0 Compare May 13, 2024 19:03

Add semicolon

8f71ad0

tgolen approved these changes May 14, 2024

View reviewed changes

tgolen merged commit cba6916 into Expensify:main May 14, 2024
4 of 15 checks passed

melvin-bot bot added the Emergency label May 14, 2024

tgolen removed the Emergency label May 14, 2024

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

vradriano mentioned this pull request Jun 2, 2024

[$250] Onboarding - Infinite skeleton on concierge chat page when deleting a task and going back #40918

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: infinite skeleton loading when delete concierge task #42022

Fix: infinite skeleton loading when delete concierge task #42022

vradriano commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

melvin-bot bot commented May 11, 2024

vradriano commented May 11, 2024 •

edited

Loading

tgolen commented May 13, 2024

eh2077 commented May 13, 2024 •

edited

Loading

eh2077 commented May 13, 2024

vradriano commented May 13, 2024

eh2077 commented May 13, 2024

tgolen commented May 13, 2024

tgolen commented May 13, 2024

vradriano commented May 13, 2024 •

edited

Loading

tgolen commented May 13, 2024

tgolen commented May 14, 2024

melvin-bot bot commented May 14, 2024

OSBotify commented May 14, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

Fix: infinite skeleton loading when delete concierge task #42022

Fix: infinite skeleton loading when delete concierge task #42022

Conversation

vradriano commented May 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented May 11, 2024 • edited Loading

melvin-bot bot commented May 11, 2024

vradriano commented May 11, 2024 • edited Loading

tgolen commented May 13, 2024

eh2077 commented May 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eh2077 commented May 13, 2024

vradriano commented May 13, 2024

eh2077 commented May 13, 2024

tgolen commented May 13, 2024

tgolen commented May 13, 2024

vradriano commented May 13, 2024 • edited Loading

tgolen commented May 13, 2024

tgolen commented May 14, 2024

melvin-bot bot commented May 14, 2024

OSBotify commented May 14, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

vradriano commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

vradriano commented May 11, 2024 •

edited

Loading

eh2077 commented May 13, 2024 •

edited

Loading

vradriano commented May 13, 2024 •

edited

Loading