fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount.

src/CONST.ts

@@ -3621,7 +3621,6 @@ const CONST = {
         TAG_OUT_OF_POLICY: 'tagOutOfPolicy',
         TAX_AMOUNT_CHANGED: 'taxAmountChanged',
         TAX_OUT_OF_POLICY: 'taxOutOfPolicy',
-        TAX_RATE_CHANGED: 'taxRateChanged',
         TAX_REQUIRED: 'taxRequired',
     },
 

src/components/ReceiptAudit.tsx

@@ -7,17 +7,24 @@ import Icon from './Icon';
 import * as Expensicons from './Icon/Expensicons';
 import Text from './Text';
 
-function ReceiptAuditHeader({notes, shouldShowAuditMessage}: {notes: string[]; shouldShowAuditMessage: boolean}) {
+function ReceiptAudit({notes, shouldShowAuditSuccess, shouldShowAuditFailure}: {notes: string[]; shouldShowAuditSuccess?: boolean; shouldShowAuditFailure?: boolean}) {
     const styles = useThemeStyles();
     const theme = useTheme();
     const {translate} = useLocalize();
 
-    const auditText = notes.length > 0 ? translate('iou.receiptIssuesFound', notes.length) : translate('common.verified');
+    let auditText = '';
+
+    if (notes.length > 0 && shouldShowAuditFailure) {
+        auditText = translate('iou.receiptIssuesFound', notes.length);
+    } else if (!notes.length && shouldShowAuditSuccess) {
+        auditText = translate('common.verified');
+    }
+
     return (
         <View style={[styles.ph5, styles.mbn1]}>
             <View style={[styles.flexRow, styles.alignItemsCenter]}>
                 <Text style={[styles.textLabelSupporting]}>{translate('common.receipt')}</Text>
-                {shouldShowAuditMessage && (
+                {auditText && (
                     <>
                         <Text style={[styles.textLabelSupporting]}>{` • ${auditText}`}</Text>
                         <Icon
@@ -34,9 +41,4 @@ function ReceiptAuditHeader({notes, shouldShowAuditMessage}: {notes: string[]; s
     );
 }
 
-function ReceiptAuditMessages({notes = []}: {notes?: string[]}) {
-    const styles = useThemeStyles();
-    return <View style={[styles.mtn1, styles.mb2, styles.ph5, styles.gap1]}>{notes.length > 0 && notes.map((message) => <Text style={[styles.textLabelError]}>{message}</Text>)}</View>;
-}
-
-export {ReceiptAuditHeader, ReceiptAuditMessages};
+export default ReceiptAudit;

src/components/ReportActionItem/MoneyRequestView.tsx

@@ -7,7 +7,7 @@ import * as Expensicons from '@components/Icon/Expensicons';
 import MenuItemWithTopDescription from '@components/MenuItemWithTopDescription';
 import OfflineWithFeedback from '@components/OfflineWithFeedback';
 import {useSession} from '@components/OnyxProvider';
-import {ReceiptAuditHeader, ReceiptAuditMessages} from '@components/ReceiptAudit';
+import ReceiptAudit from '@components/ReceiptAudit';
 import ReceiptEmptyState from '@components/ReceiptEmptyState';
 import Switch from '@components/Switch';
 import Text from '@components/Text';
@@ -178,7 +178,7 @@ function MoneyRequestView({
     // A flag for showing tax rate
     const shouldShowTax = isTaxTrackingEnabled(isPolicyExpenseChat, policy);
 
-    const {getViolationsForField} = useViolations(transactionViolations ?? []);
+    const {getViolationsForField} = useViolations(transactionViolations ?? [], !isReceiptBeingScanned && ReportUtils.isPaidGroupPolicy(report));
     const hasViolations = useCallback(
         (field: ViolationField, data?: OnyxTypes.TransactionViolation['data']): boolean => !!canUseViolations && getViolationsForField(field, data).length > 0,
         [canUseViolations, getViolationsForField],
@@ -330,16 +330,17 @@ function MoneyRequestView({
     const shouldShowMapOrReceipt = showMapAsImage || hasReceipt;
     const shouldShowReceiptEmptyState = !hasReceipt && !isInvoice && (canEditReceipt || isAdmin || isApprover);
     const noticeTypeViolations = transactionViolations?.filter((violation) => violation.type === 'notice').map((v) => ViolationsUtils.getViolationTranslation(v, translate)) ?? [];
-    const shouldShowNotesViolations = !isReceiptBeingScanned && canUseViolations && ReportUtils.isPaidGroupPolicy(report);
+    const shouldShowAuditMessage = !isReceiptBeingScanned && canUseViolations && ReportUtils.isPaidGroupPolicy(report);
 
     return (
         <View style={[StyleUtils.getReportWelcomeContainerStyle(isSmallScreenWidth, true, shouldShowAnimatedBackground)]}>
             {shouldShowAnimatedBackground && <AnimatedEmptyStateBackground />}
             <View style={shouldShowAnimatedBackground && [StyleUtils.getReportWelcomeTopMarginStyle(isSmallScreenWidth, true)]}>
                 {!isInvoice && (
-                    <ReceiptAuditHeader
+                    <ReceiptAudit
                         notes={noticeTypeViolations}
-                        shouldShowAuditMessage={Boolean(shouldShowNotesViolations && didRceiptScanSucceed)}
+                        shouldShowAuditSuccess={shouldShowAuditMessage && didRceiptScanSucceed}
+                        shouldShowAuditFailure={shouldShowAuditMessage && hasReceipt}
                     />
                 )}
                 {shouldShowMapOrReceipt && (
@@ -393,7 +394,6 @@ function MoneyRequestView({
                     />
                 )}
                 {!shouldShowReceiptEmptyState && !shouldShowMapOrReceipt && <View style={{marginVertical: 6}} />}
-                {shouldShowNotesViolations && <ReceiptAuditMessages notes={noticeTypeViolations} />}
                 {canUseViolations && <ViolationMessages violations={getViolationsForField('receipt')} />}
                 <OfflineWithFeedback pendingAction={getPendingFieldAction('amount')}>
                     <MenuItemWithTopDescription

src/hooks/useViolations.ts

@@ -42,23 +42,28 @@ const violationFields: Record<ViolationName, ViolationField> = {
     tagOutOfPolicy: 'tag',
     taxAmountChanged: 'tax',
     taxOutOfPolicy: 'tax',
-    taxRateChanged: 'tax',
     taxRequired: 'tax',
 };
 
 type ViolationsMap = Map<ViolationField, TransactionViolation[]>;
 
-function useViolations(violations: TransactionViolation[]) {
+function useViolations(violations: TransactionViolation[], shouldIncludeNoticeViolations?: boolean) {
     const violationsByField = useMemo((): ViolationsMap => {
-        const filteredViolations = violations.filter((violation) => violation.type === CONST.VIOLATION_TYPES.VIOLATION);
+        const filteredViolations = violations.filter((violation) => {
+            if (!shouldIncludeNoticeViolations) {
+                return violation.type === CONST.VIOLATION_TYPES.VIOLATION;
+            }
+            return violation.type === CONST.VIOLATION_TYPES.VIOLATION || violation.type === CONST.VIOLATION_TYPES.NOTICE;
+        });
+
         const violationGroups = new Map<ViolationField, TransactionViolation[]>();
         for (const violation of filteredViolations) {
             const field = violationFields[violation.name];
             const existingViolations = violationGroups.get(field) ?? [];
             violationGroups.set(field, [...existingViolations, violation]);
         }
         return violationGroups ?? new Map();
-    }, [violations]);
+    }, [violations, shouldIncludeNoticeViolations]);
 
     const getViolationsForField = useCallback(
         (field: ViolationField, data?: TransactionViolation['data']) => {

src/libs/Violations/ViolationsUtils.ts

@@ -276,8 +276,6 @@ const ViolationsUtils = {
                 return translate('violations.taxAmountChanged');
             case 'taxOutOfPolicy':
                 return translate('violations.taxOutOfPolicy', {taxName});
-            case 'taxRateChanged':
-                return translate('violations.taxRateChanged');
             case 'taxRequired':
                 return translate('violations.taxRequired');
             default: