fix: Status expiry time does not show correctly when hovering the user in the chat report #41383

Krishna2323 · 2024-05-01T06:04:08Z

Details

Fixed Issues

$ #40733
PROPOSAL: #40733 (comment)

Tests

Open profile > Status > Clear after > Select Today and save
Open any chat report and hover over the status icon
Verify it tooltip shows (Until tomorrow)
Open profile > Status > Clear after > Custom > Time > Set 11:59PM and save.
Open any chat report and hover over the status icon
Verify it tooltip shows (Until 11:59PM)

Verify that no errors appear in the JS console

Offline tests

Open profile > Status > Clear after > Select Today and save
Open any chat report and hover over the status icon
Verify it tooltip shows (Until tomorrow)
Open profile > Status > Clear after > Custom > Time > Set 11:59PM and save.
Open any chat report and hover over the status icon
Verify it tooltip shows (Until 11:59PM)

QA Steps

Open profile > Status > Clear after > Select Today and save
Open any chat report and hover over the status icon
Verify it tooltip shows (Until tomorrow)
Open profile > Status > Clear after > Custom > Time > Set 11:59PM and save.
Open any chat report and hover over the status icon
Verify it tooltip shows (Until 11:59PM)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…r in the chat report. Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-05-01T06:04:12Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-05-01T15:53:03Z

src/libs/DateUtils.ts

@@ -534,7 +534,7 @@ function getStatusUntilDate(inputDate: string): string {
    const endOfToday = endOfDay(now);

    // If the date is equal to the end of today


@Krishna2323 Also should update this comment

What do you think about this?

// endOfToday return 11:59:59. // Use isSameSecond to ensure accuracy, otherwise, setting the time to 11:59PM would also display until tomorrow.

@Krishna2323 What do you think about
// If the date is adjusted to the following day.

@DylanDylann, I think we should add comment about why we are using isSameSecond instead of isSameDay. Let me know your opinion.

@Krishna2323 As the pattern of this comment, this comment gives information about when this code is executed. I am ok with your suggestion to add more explanation why using isSameSecond

// If the date is adjusted to the following day
// Use isSameSecond to ensure accuracy, otherwise, setting the time to 11:59PM would also display until tomorrow.

Ok, so should we add this?

Ok. It looks good

// If the date is adjusted to the following day
// Use isSameSecond to ensure accuracy, otherwise, setting the time to 11:59PM would also display until tomorrow.

@Krishna2323 It is a bit lengthy. I think this is enough

// If the date is adjusted to the following day

@DylanDylann, updated.

DylanDylann · 2024-05-03T07:58:03Z

@Krishna2323 Bump?

Krishna2323 · 2024-05-03T08:20:30Z

@DylanDylann, sorry for delay, somehow I missed your suggestion.

DylanDylann · 2024-05-03T09:18:24Z

@Krishna2323 Also please help to merge the latest main

Signed-off-by: Krishna Gupta <[email protected]>

…323/App into krishna2323/issue/40733

DylanDylann · 2024-05-03T10:29:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-03.at.17.26.28.mov

MacOS: Desktop

Screen.Recording.2024-05-03.at.17.29.12.mov

OSBotify · 2024-05-03T19:37:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:11:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Status expiry time does not show correctly when hovering the use…

52936f5

…r in the chat report. Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner May 1, 2024 06:04

melvin-bot bot removed the request for review from a team May 1, 2024 06:04

melvin-bot bot requested a review from DylanDylann May 1, 2024 06:04

DylanDylann reviewed May 1, 2024

View reviewed changes

Krishna2323 added 3 commits May 3, 2024 15:05

Merge branch 'Expensify:main' into krishna2323/issue/40733

60916f9

comment update.

d1ded05

Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'krishna2323/issue/40733' of https://github.com/Krishna2…

8f4f082

…323/App into krishna2323/issue/40733

Krishna2323 requested a review from DylanDylann May 3, 2024 10:09

DylanDylann approved these changes May 3, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr May 3, 2024 10:31

youssef-lr approved these changes May 3, 2024

View reviewed changes

youssef-lr merged commit a9cc15b into Expensify:main May 3, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

Krishna2323 mentioned this pull request May 9, 2024

[Payment due 2024-05-15][$250] Status expiry time does not show correctly when hovering the user in the chat report #40733

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Status expiry time does not show correctly when hovering the user in the chat report #41383

fix: Status expiry time does not show correctly when hovering the user in the chat report #41383

Krishna2323 commented May 1, 2024 •

edited

Loading

melvin-bot bot commented May 1, 2024

DylanDylann May 1, 2024

Krishna2323 May 3, 2024 •

edited

Loading

DylanDylann May 3, 2024

Krishna2323 May 3, 2024

DylanDylann May 3, 2024

Krishna2323 May 3, 2024

DylanDylann May 3, 2024

DylanDylann May 3, 2024

Krishna2323 May 3, 2024

DylanDylann commented May 3, 2024

Krishna2323 commented May 3, 2024

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024 •

edited

Loading

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

		@@ -534,7 +534,7 @@ function getStatusUntilDate(inputDate: string): string {
		const endOfToday = endOfDay(now);

		// If the date is equal to the end of today

fix: Status expiry time does not show correctly when hovering the user in the chat report #41383

fix: Status expiry time does not show correctly when hovering the user in the chat report #41383

Conversation

Krishna2323 commented May 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 1, 2024

Choose a reason for hiding this comment

Krishna2323 May 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented May 3, 2024

Krishna2323 commented May 3, 2024

DylanDylann commented May 3, 2024

DylanDylann commented May 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented May 3, 2024

OSBotify commented May 9, 2024

Krishna2323 commented May 1, 2024 •

edited

Loading

Krishna2323 May 3, 2024 •

edited

Loading

DylanDylann commented May 3, 2024 •

edited

Loading