[TS migration] Remove 'OptionsSelector' component #41077

war-in · 2024-04-26T10:22:31Z

Details

Fixed Issues

$ #25125
PROPOSAL:

Tests

Go to small room.
Create split expense / submit expense.
Provide amount (e.g. 100).
Verify that values are displayed correctly.
There should be some space between the Show more and Submit buttons (depending on the room size).
Go to huge room (with at least 20 users) (crowded policy - #huge-room)
Do all previous steps.
Verify that the list is scrollable and clickable (values should update if someone is "unclicked").
Create split expanse / submit expense and add scan with wrong file type (there should be warning Password-protected PDF is not supported)

Offline tests

QA Steps

Go to small room.
Create split expense / submit expense.
Provide amount (e.g. 100).
Verify that values are displayed correctly.
There should be some space between the Show more and Submit buttons (depending on the room size).
Go to huge room (with at least 20 users) (crowded policy - #huge-room)
Do all previous steps.
Verify that the list is scrollable and clickable (values should update if someone is "unclicked").
Create split expanse / submit expense and add scan with wrong file type (there should be warning Password-protected PDF is not supported)

PR Author Checklist

Screenshots/Videos

Android: Native

android.-.native.mov

Android: mWeb Chrome

android.-.web.mov

iOS: Native

ios.-.native.mov

iOS: mWeb Safari

iOS.to.Web.1.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx # src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx

war-in · 2024-04-29T16:40:31Z

While working on this and recording videos I've encountered a bug (it is present on the main branch too)
The Password-protected PDF is not supported warning is not displayed on native apps (iOS and android).

Screen.Recording.Apr.29.1.mov

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

war-in · 2024-05-13T10:57:32Z

@s77rt It should be ready for review now :)

war-in · 2024-05-13T13:05:02Z

It turned out that there was another PR doing the same thing :/
I'll merge it and leave only necessary changes

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

war-in · 2024-05-13T13:22:01Z

Done, it is ready for review now :)

s77rt · 2024-05-13T18:21:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Networking issue

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt · 2024-05-13T18:25:01Z

Can you please fix this styling bug, comparing to staging the user email is right next to the amount

war-in · 2024-05-14T09:49:11Z

@s77rt Fixed :)

src/components/MoneyRequestConfirmationList.tsx

OSBotify · 2024-05-15T11:36:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-23T00:39:12Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-27T14:02:20Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

war-in added 9 commits April 23, 2024 09:56

wip

e3e9e7b

wip....

0ab6923

show tick next to payee

3f1c13c

show amount

7cd7718

Merge branch 'refs/heads/main' into war-in/options-selector-removal

0eff692

align items

b05192b

remove optionsSelector

1e65a85

fix typecheck

affc169

styling

1ad6d78

war-in changed the title ~~War in/options selector removal~~ [TS migration] Migrate 'OptionsSelector' component to TypeScript Apr 26, 2024

war-in added 9 commits April 26, 2024 17:05

add correct styling

3db3fb4

use ScrollView

f5148ed

add second ScrollView to get rid of error

115be37

styling

01840ca

use SelectionList as main component

04b9907

Merge branch 'refs/heads/main' into war-in/options-selector-removal

dadec41

fix lint

b34b47e

move children to listFooterContent

08b162e

Merge branch 'refs/heads/main' into war-in/options-selector-removal

1259b8d

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx # src/pages/workspace/workflows/WorkspaceWorkflowsPayerPage.tsx

war-in added 2 commits April 30, 2024 10:58

Merge branch 'refs/heads/main' into war-in/options-selector-removal

3eb6751

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

prettier

eb8d61e

Christinadobrzyn mentioned this pull request May 3, 2024

[HOLD for payment 2024-06-03] [TS migration] Migrate 'OptionsSelector' component to TypeScript #25125

Closed

blazejkustra approved these changes May 6, 2024

View reviewed changes

Merge branch 'refs/heads/main' into war-in/options-selector-removal

830d71c

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

war-in changed the title ~~[TS migration] Migrate 'OptionsSelector' component to TypeScript~~ [TS migration] Remove 'OptionsSelector' component May 6, 2024

war-in marked this pull request as ready for review May 6, 2024 09:32

war-in requested a review from a team as a code owner May 6, 2024 09:32

melvin-bot bot requested review from s77rt and removed request for a team May 6, 2024 09:32

war-in added 2 commits May 13, 2024 11:33

remove ArrowKeyFocusManager.js

c274163

show non-editable amount when needed

d9a5d2f

war-in requested a review from s77rt May 13, 2024 10:57

Merge branch 'refs/heads/main' into war-in/options-selector-removal

de9138d

# Conflicts: # src/components/MoneyRequestConfirmationList.tsx

war-in mentioned this pull request May 13, 2024

feat: refactor MoneyRequestConfirmationList #40785

Merged

50 tasks

blazejkustra approved these changes May 13, 2024

View reviewed changes

war-in added 2 commits May 14, 2024 10:54

Merge branch 'refs/heads/main' into war-in/options-selector-removal

dcc0582

fix padding

929d7f1

s77rt suggested changes May 14, 2024

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Outdated Show resolved Hide resolved

war-in added 2 commits May 14, 2024 16:38

Merge branch 'refs/heads/main' into war-in/options-selector-removal

720900d

padding -> margin

8cc152c

war-in requested a review from s77rt May 14, 2024 14:42

s77rt approved these changes May 14, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas May 14, 2024 15:33

danieldoglas approved these changes May 15, 2024

View reviewed changes

danieldoglas merged commit 947f9c6 into Expensify:main May 15, 2024
16 checks passed

srikarparsi mentioned this pull request May 15, 2024

[$250] Split - No spacing between username + email address and split amount on confirmation page #42191

Closed

6 tasks

pecanoro mentioned this pull request May 15, 2024

[HOLD for payment 2024-06-03] [$125] Web - Split scan - Excessive header space in split menu #42210

Closed

6 tasks

github-actions bot mentioned this pull request May 22, 2024

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed

45 tasks

lanitochka17 mentioned this pull request May 23, 2024

[PAUSED][$250] Web - Unable to create a split expense with a large number of room members #42562

Closed

6 tasks

war-in deleted the war-in/options-selector-removal branch June 24, 2024 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Remove 'OptionsSelector' component #41077

[TS migration] Remove 'OptionsSelector' component #41077

war-in commented Apr 26, 2024 •

edited

Loading

war-in commented Apr 29, 2024 •

edited

Loading

war-in commented May 13, 2024

war-in commented May 13, 2024

war-in commented May 13, 2024

s77rt commented May 13, 2024 •

edited

Loading

s77rt commented May 13, 2024

war-in commented May 14, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

OSBotify commented May 27, 2024

[TS migration] Remove 'OptionsSelector' component #41077

[TS migration] Remove 'OptionsSelector' component #41077

Conversation

war-in commented Apr 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

war-in commented Apr 29, 2024 • edited Loading

war-in commented May 13, 2024

war-in commented May 13, 2024

war-in commented May 13, 2024

s77rt commented May 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented May 13, 2024

war-in commented May 14, 2024

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

OSBotify commented May 27, 2024

war-in commented Apr 26, 2024 •

edited

Loading

war-in commented Apr 29, 2024 •

edited

Loading

s77rt commented May 13, 2024 •

edited

Loading