Patch for WebView crash v2 #41023

aldo-expensify · 2024-04-25T19:16:39Z

Patches:

patches/react-native+0.73.4+015+fixIOSWebViewCrash.patch: Created from [RN][iOS] Fix compiler flags passed to libraries facebook/react-native#43088. This patch won't be needed when we upgrade react-native to >= 0.73.5
patches/@rnmapbox+maps+10.1.11.patch: Patch created by @staszekscp here, there is no PR as far as I know. To check if the patch is still needed you need to check if the renaming of the file extension is still needed or not.

Details

Trying adding the patches from this PR again: #40527, but trying to reduce the changes to a minimum

Fixed Issues

$ #40517
PROPOSAL:

Tests

In Web/Desktop:

Create NewDot account (must be in beta accountingOnNewExpensify)
Create Workspace
Go to the Workspace's Settings > More Features
Enable "Accounting"
Go to Workspace's Settings > Accounting
Click "Set Up" in the quickbooks online menu entry
Verify a browser tabs open with the quickbooks authentication page
Close the tab
Verify that NewDot is still working and no crash happened

Android native / IOS native:

Create NewDot account (must be in beta accountingOnNewExpensify)
Create Workspace
Go to the Workspace's Settings > More Features
Enable "Accounting"
Go to Workspace's Settings > Accounting
Click "Set Up" in the quickbooks online menu entry
Verify that the QBO authentication page opens inside NewDot
Swipe back (or press back button)
Verify that the QBO authentication page closes, and that the App is still working and no crash happened

Verify that no errors appear in the JS console

Offline tests

QA Steps

In Web/Desktop:

Create NewDot account (must be in beta accountingOnNewExpensify)
Create Workspace
Go to the Workspace's Settings > More Features
Enable "Accounting"
Go to Workspace's Settings > Accounting
Click "Set Up" in the quickbooks online menu entry
Verify a browser tabs open with the quickbooks authentication page
Close the tab
Verify that NewDot is still working and no crash happened

Android native / IOS native:

Create NewDot account (must be in beta accountingOnNewExpensify)
Create Workspace
Go to the Workspace's Settings > More Features
Enable "Accounting"
Go to Workspace's Settings > Accounting
Click "Set Up" in the quickbooks online menu entry
Verify that the QBO authentication page opens inside NewDot
Swipe back (or press back button)
Verify that the QBO authentication page closes, and that the App is still working and no crash happened

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aldo-expensify · 2024-04-25T21:23:07Z

@rojiphil do you have an IOS device to test the AdHoc build? 🙏

melvin-bot · 2024-04-26T01:21:21Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-04-26T01:21:44Z

Going to make this ready for review. Tom tested here in IOS and it didn't crash: https://expensify.slack.com/archives/C036QM0SLJK/p1714094451031619?thread_ts=1713799261.297609&cid=C036QM0SLJK

Recording from Tom's device:

RPReplay_Final1714094494.MP4

aldo-expensify · 2024-04-26T01:27:38Z

cc @roryabraham in case you see something wrong here 🙇

aldo-expensify · 2024-04-26T01:27:47Z

Oops wrong button

rojiphil · 2024-04-26T03:48:10Z

do you have an IOS device to test the AdHoc build?

@aldo-expensify I do not have an IOS device. Since we already tested on an iOS device here, are you still looking for a C+ with an IOS device? If so, we will have to reassign. On the other hand, I can carry out the tests on an iOS simulator + other platforms including on an Android device. Would this work?

rojiphil · 2024-04-26T03:50:01Z

@aldo-expensify And a small request here. Please add [email protected] and [email protected] accounts to the accountingOnNewExpensify beta. Thanks

aldo-expensify · 2024-04-26T04:53:05Z

@aldo-expensify And a small request here. Please add [email protected] and [email protected] accounts to the accountingOnNewExpensify beta. Thanks

Done

do you have an IOS device to test the AdHoc build?

@aldo-expensify I do not have an IOS device. Since we already tested on an iOS device here, are you still looking for a C+ with an IOS device? If so, we will have to reassign. On the other hand, I can carry out the tests on an iOS simulator + other platforms including on an Android device. Would this work?

I think it is fine if you carry out the other platforms and IOS simulator

staszekscp · 2024-04-26T06:42:20Z

Nice job with the cleanup! I've also opened a PR to react-native-live-markdown so we can remove one of the patches soon 😄

aldo-expensify · 2024-04-26T06:45:59Z

Nice job with the cleanup! I've also opened a PR to react-native-live-markdown so we can remove one of the patches soon 😄

Great, thanks again for all the help!

rojiphil

Patch file for react-native-live-markdown was generated for 0.1.62 whereas the latest one in use is 0.1.64. Can we not fix this to avoid the warning?
Here is the warning message.

rojiphil · 2024-04-26T11:07:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

41023-android-native--01.mp4

Android: mWeb Chrome

41023-mweb-chrome--01.mp4

iOS: Native

Tested on simulator

41023-ios-native--01.mp4

iOS: mWeb Safari

41023-mweb-safari--01.mp4

MacOS: Chrome / Safari

41023-web-safari--01.mp4

MacOS: Desktop

41023-desktop--01.mp4

…ew-v2

aldo-expensify · 2024-04-26T19:05:44Z

Patch file for react-native-live-markdown was generated for 0.1.62 whereas the latest one in use is 0.1.64. Can we not fix this to avoid the warning?

Updated. I confirmed that we still need the patch for 0.1.64

aldo-expensify · 2024-04-26T19:07:49Z

I launched another adhoc build to confirm that this still build fine after pulling from main

github-actions · 2024-04-26T19:40:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41023/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41023/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41023/NewExpensify.dmg	https://41023.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

roryabraham · 2024-04-26T19:46:50Z

@aldo-expensify please include links to the upstream PRs / commits for each of these patches in the PR description so that we can know when we can remove it later.

aldo-expensify · 2024-04-26T20:37:37Z

Because it was requested here:

Removed patch patches/https://github.com/Expensify+react-native-live-markdown+0.1.64.patch
Upgraded react-native-live-markdown to 0.1.69

aldo-expensify · 2024-04-26T20:46:25Z

@aldo-expensify please include links to the upstream PRs / commits for each of these patches in the PR description so that we can know when we can remove it later.

Added description for patches

aldo-expensify · 2024-04-26T21:04:02Z

huh Snyk failed because of Failed to parse ios/Podfile.lock as valid YAML ???

Can we re-run these?

I don't see how and I don't see any error in the Podfile.lock

github-actions · 2024-04-26T21:18:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41023/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41023/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41023/NewExpensify.dmg	https://41023.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rojiphil · 2024-04-27T16:41:48Z

@aldo-expensify ios native build works fine for me. But android native build fails for me. It seems like @fullstory/react-native package is required but not present. It looks like some recent change introduced this.
Here is the failure message while running npm run android.

rojiphil · 2024-04-27T16:43:32Z

@aldo-expensify After running npm run pod-install, I also notice that podfile.lock does not include fullstory_react-native dependency. Could this be related to the android native issue?

trjExpensify · 2024-04-29T13:15:37Z

Do we need to move reviewers/comments over to: #41117?

github-actions · 2024-04-29T20:14:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41023/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/41023/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41023/NewExpensify.dmg	https://41023.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

aldo-expensify · 2024-04-29T20:18:08Z

@rojiphil can you re-approve? 🙏

…ew-v2

trjExpensify · 2024-04-30T09:43:55Z

Bump @rojiphil on the re-approval, please.

rojiphil · 2024-04-30T09:50:12Z

Reviewing now

rojiphil

The App does not crash on iOS native (built using npm run iOS and tested on simulator). Note: I have not tested on real device as I do not have one.
For all other platforms, the tests were performed based on the ad hoc build.
Android platform tests were carried out on real device
Works well. LGTM

Running android native build using npm run android still fails for me as mentioned here. But this also fails on the latest main. So, have raised the issue here

melvin-bot · 2024-04-30T11:15:37Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Hey @aldo-expensify. I was trying to verify iOS on a physical device, but after granting the beta flag and re-authenticating I'm still not seeing the accounting option 😕

Any idea what I missed?

Created public domain account
Created workspace
Granted beta
Authenticated on iOS AdHoc build
No accounting option

trjExpensify · 2024-04-30T13:06:28Z

@Julesssss I think it can take an hour or so for the beta to be recognised. Is this build up here good to go or do we need a new one? I'm happy to give it a whirl on an iOS device. Alternatively, I can spin you up an email address on my private domain that has access and ship you the magic code to sign-in when received.

Julesssss

Verified physical iOS with thanks to Tom

OSBotify · 2024-04-30T13:21:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-01T03:02:04Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.69-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-02T13:05:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Patch for WebView crash

35b23f6

aldo-expensify self-assigned this Apr 25, 2024

aldo-expensify added the Ready To Build label Apr 25, 2024

This comment has been minimized.

Sign in to view

aldo-expensify marked this pull request as ready for review April 26, 2024 01:21

aldo-expensify requested a review from a team as a code owner April 26, 2024 01:21

melvin-bot bot removed the request for review from a team April 26, 2024 01:21

melvin-bot bot requested a review from rojiphil April 26, 2024 01:21

aldo-expensify closed this Apr 26, 2024

aldo-expensify reopened this Apr 26, 2024

staszekscp approved these changes Apr 26, 2024

View reviewed changes

rojiphil reviewed Apr 26, 2024

View reviewed changes

aldo-expensify added 2 commits April 26, 2024 12:03

Merge branch 'main' of github.com:Expensify/App into aldo_patch-webvi…

f80757e

…ew-v2

Update patch version

133e0c0

Upgrade expensify/react-native-live-markdown and remove patch

f72d330

aldo-expensify mentioned this pull request Apr 26, 2024

Patch for WebView crash v3 #41117

Closed

50 tasks

This was referenced Apr 26, 2024

Upgrade RN to 0.73.5 / fix codegen patch #40850

Closed

Update react-native to 0.73.7 #40846

Closed

Merge main / fix conflicts

05e9d69

Merge branch 'main' of github.com:Expensify/App into aldo_patch-webvi…

e2d0fac

…ew-v2

aldo-expensify mentioned this pull request Apr 29, 2024

[HOLD for payment 2024-05-09] [Wave Collect][QBO] iOS - Accounting - App crashes after completing QBO setup flow #40517

Closed

6 tasks

rojiphil approved these changes Apr 30, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss April 30, 2024 11:15

Julesssss reviewed Apr 30, 2024

View reviewed changes

Julesssss approved these changes Apr 30, 2024

View reviewed changes

Julesssss merged commit 2a1c2cb into main Apr 30, 2024
19 checks passed

Julesssss deleted the aldo_patch-webview-v2 branch April 30, 2024 13:13

github-actions bot mentioned this pull request May 1, 2024

Deploy Checklist: New Expensify 2024-05-01 #41376

Closed

59 tasks

francoisl mentioned this pull request May 3, 2024

Fix patch for new rnmapbox-maps version #41556

Merged

50 tasks

Patch for WebView crash v2 #41023

Patch for WebView crash v2 #41023

Conversation

aldo-expensify commented Apr 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

aldo-expensify commented Apr 25, 2024

melvin-bot bot commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024 • edited Loading

aldo-expensify commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

rojiphil commented Apr 26, 2024

rojiphil commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

staszekscp commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

rojiphil left a comment

Choose a reason for hiding this comment

rojiphil commented Apr 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

aldo-expensify commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

roryabraham commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024

aldo-expensify commented Apr 26, 2024 • edited Loading

github-actions bot commented Apr 26, 2024

rojiphil commented Apr 27, 2024

rojiphil commented Apr 27, 2024

trjExpensify commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

aldo-expensify commented Apr 29, 2024

trjExpensify commented Apr 30, 2024

rojiphil commented Apr 30, 2024

rojiphil left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Apr 30, 2024

Julesssss left a comment

Choose a reason for hiding this comment

trjExpensify commented Apr 30, 2024

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 30, 2024

OSBotify commented May 1, 2024

OSBotify commented May 2, 2024

aldo-expensify commented Apr 25, 2024 •

edited

Loading

aldo-expensify commented Apr 26, 2024 •

edited

Loading

rojiphil commented Apr 26, 2024 •

edited

Loading

aldo-expensify commented Apr 26, 2024 •

edited

Loading