-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle tax for split requests #40240
Merged
Merged
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c611187
Pass taxCode and taxAmount params for split bill request
MonilBhavsar c7ec5f2
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar 8cb3a49
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar bb6d480
Merge branch 'monil-splitBillTaxUpdate' of github.com:Expensify/App i…
MonilBhavsar 98e0e40
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar 477b381
Split amount based on new logic and update optimistic transaction
MonilBhavsar ec48476
Fix lint
MonilBhavsar bd20eed
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar de50156
Fix bug when selectedReportID and hence policy is undefined on confir…
MonilBhavsar c3db0c8
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar c667482
Fix taxAmount not being calculated
MonilBhavsar cdfb3ad
Handle editing split bill case
MonilBhavsar 78bf98a
Handle scan split requests optimistically
MonilBhavsar 776856c
Fix lint
MonilBhavsar 6dd21cb
Check for ownerAccountID in case of split with policy
MonilBhavsar c7d8b42
Merge branch 'main' into monil-splitBillTaxUpdate
MonilBhavsar 787c520
Fix taxAmount is negative optimistically
MonilBhavsar d136b4a
Fix lint and typecheck
MonilBhavsar c671c7a
Fix bug when updating taxAmount and refactor
MonilBhavsar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug was
Let me know if you think this is not the correct way and should use separate hook or may be something else. Open to other solutions.