Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After revert: Defer local updates if there are missing updates and only call GetMissingOnyxMessages once #39683

Merged
merged 45 commits into from
Apr 30, 2024
Merged

After revert: Defer local updates if there are missing updates and only call GetMissingOnyxMessages once #39683

merged 45 commits into from
Apr 30, 2024

Commits on Apr 5, 2024

  1. Revert "Merge pull request Expensify#39668 from Expensify/revert-3899… 

    …7-@chrispader/prevent-simultaneous-calls-to-GetMissingOnyxMessages"

This reverts commit 3864cdb, reversing
changes made to 42ee04c.
    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    068e624 View commit details
    Browse the repository at this point in the history

  2. remove queue clearing and add TS type guard for OnyxUpdate

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1a8528c View commit details
    Browse the repository at this point in the history

  3. fix: type check

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e52db00 View commit details
    Browse the repository at this point in the history

  4. simplify code

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    2e13b36 View commit details
    Browse the repository at this point in the history

  5. simplify code

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4fbbd9a View commit details
    Browse the repository at this point in the history

  6. fix: and simplify

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    9eaa455 View commit details
    Browse the repository at this point in the history

  7. add comment

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c134283 View commit details
    Browse the repository at this point in the history

  8. rename variables

    @chrispader
    chrispader committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    36c9ad6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c34337f View commit details
    Browse the repository at this point in the history

  2. remove unnecessary pause

    @chrispader
    chrispader committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    48fa52e View commit details
    Browse the repository at this point in the history

  3. check for isLoadingApp and ActiveClientManager first

    @chrispader
    chrispader committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    beb16a3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1d396e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5f1bb97 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    4cdaf5d View commit details
    Browse the repository at this point in the history

  2. minor improvements of OnyxUpdateMangaer

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    26ded32 View commit details
    Browse the repository at this point in the history

  3. implement tests

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e21abf5 View commit details
    Browse the repository at this point in the history

  4. add exports for testing

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    cbe2d9f View commit details
    Browse the repository at this point in the history

  5. fix: test implementation

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    2a29079 View commit details
    Browse the repository at this point in the history

  6. implement proxy for OnyxUpdateManager

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    28004cb View commit details
    Browse the repository at this point in the history

  7. update tests

    @chrispader
    chrispader committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    70e428e View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. extract util logic from OnyxUpdateManager

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0890696 View commit details
    Browse the repository at this point in the history

  2. extract createProxyForValue and further split up utils

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    909b5a8 View commit details
    Browse the repository at this point in the history

  3. fix: tests

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c502513 View commit details
    Browse the repository at this point in the history

  4. extract mocks from test

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    001eb3a View commit details
    Browse the repository at this point in the history

  5. apply updaes

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4eaf83a View commit details
    Browse the repository at this point in the history

  6. remove unnecessary promise trigger code

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9910943 View commit details
    Browse the repository at this point in the history

  7. update tests and mocks

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b078cfa View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cf3b7e6 View commit details
    Browse the repository at this point in the history

  9. fix: ts

    @chrispader
    chrispader committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2c50853 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix: tests

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3904ef4 View commit details
    Browse the repository at this point in the history

  2. move specific mocks to mock folders

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    abff1aa View commit details
    Browse the repository at this point in the history

  3. fix: update mocks and tests

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    39387f6 View commit details
    Browse the repository at this point in the history

  4. simplify

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6327968 View commit details
    Browse the repository at this point in the history

  5. fix: update mocks, tests and test utils to allow for broader E2E tests

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b0a70ba View commit details
    Browse the repository at this point in the history

  6. add more tests and comments

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d0e3b68 View commit details
    Browse the repository at this point in the history

  7. remove waitForBatchedChanges

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    52ad15a View commit details
    Browse the repository at this point in the history

  8. rename and move helper function

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a7aac11 View commit details
    Browse the repository at this point in the history

  9. add isPaused checker function to SequentialQueue

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    95fc4f6 View commit details
    Browse the repository at this point in the history

  10. reset more things before each test

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3e8bc28 View commit details
    Browse the repository at this point in the history

  11. add another test

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5e42e99 View commit details
    Browse the repository at this point in the history

  12. fix: first test

    @chrispader
    chrispader committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f57a149 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0bb6a51 View commit details
    Browse the repository at this point in the history

  2. remove unused line

    @chrispader
    chrispader committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a738a51 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    23eab2d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Merge branch 'main' into @chrispader/GetMissingOnyxMessages-deferred-… 

    …updates-after-revert
    @chrispader
    chrispader committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f48d931 View commit details
    Browse the repository at this point in the history