fix: Fix playing Shutter Sound in Scan Receipt #39400
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||
| import {useFocusEffect} from '@react-navigation/core'; | ||||
| import lodashGet from 'lodash/get'; | ||||
| import React, {useCallback, useEffect, useRef, useState} from 'react'; | ||||
| import {ActivityIndicator, Alert, AppState, InteractionManager, View} from 'react-native'; | ||||
| import {Gesture, GestureDetector} from 'react-native-gesture-handler'; | ||||
| import {RESULTS} from 'react-native-permissions'; | ||||
|
|
@@ -31,6 +31,8 @@ | |||
| import * as IOU from '@userActions/IOU'; | ||||
| import CONST from '@src/CONST'; | ||||
| import ROUTES from '@src/ROUTES'; | ||||
| import Onyx, {useOnyx} from 'react-native-onyx'; | ||||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||||
| import * as CameraPermission from './CameraPermission'; | ||||
| import NavigationAwareCamera from './NavigationAwareCamera'; | ||||
|
|
||||
|
|
@@ -63,6 +65,7 @@ | |||
| const device = useCameraDevice('back', { | ||||
| physicalDevices: ['wide-angle-camera'], | ||||
| }); | ||||
| const [user] = useOnyx(ONYXKEYS.USER) | ||||
|
There was a problem hiding this comment. should I use a selector for only There was a problem hiding this comment. I dont think we can use useOnyx yet, please use selector There was a problem hiding this comment. How would that look like then? There was a problem hiding this comment. @mountiny what is the reason we shouldn't use `useOnyx yet? There was a problem hiding this comment.
Suggested change
|
||||
|
|
||||
| const hasFlash = device != null && device.hasFlash; | ||||
| const camera = useRef(null); | ||||
|
|
@@ -239,6 +242,7 @@ | |||
| return camera.current | ||||
| .takePhoto({ | ||||
| flash: flash && hasFlash ? 'on' : 'off', | ||||
| enableShutterSound: !user.isMutedAllSounds | ||||
| }) | ||||
| .then((photo) => { | ||||
| // Store the receipt on the transaction object in Onyx | ||||
|
|
@@ -258,7 +262,7 @@ | |||
| showCameraAlert(); | ||||
| Log.warn('Error taking photo', error); | ||||
| }); | ||||
| }, [cameraPermissionStatus, flash, hasFlash, user.isMutedAllSounds, translate, transactionID, action, navigateToConfirmationStep, updateScanAndNavigate]); | ||||
|
|
||||
| // Wait for camera permission status to render | ||||
| if (cameraPermissionStatus == null) { | ||||
|
|
||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.