[TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

war-in · 2024-03-26T11:48:42Z

Details

Fixed Issues

$ #38917
PROPOSAL:

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.Request.Money.mov

Android.Native.mov

Android: mWeb Chrome

android.web.-.request.money.mov

android.web.-.split.bill.mov

iOS: Native

Request.Money.iOS.mov

Split.Bill.2.mov

iOS: mWeb Safari

ios.web.-.request.money.mov

ios.web.-.split.bill.mov

MacOS: Chrome / Safari

Request.money.mov

Split.Bill.mov

MacOS: Desktop

Request.money.1.mov

Split.Bill.1.mov

src/pages/iou/request/step/IOURequestStepDescription.tsx

blazejkustra

Just couple of comments, good work! 😄

src/pages/iou/request/step/IOURequestStepDescription.tsx

src/pages/iou/request/step/withWritableReportOrNotFound.tsx

kubabutkiewicz

lgtm!

melvin-bot · 2024-03-28T13:59:51Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2024-03-28T20:04:31Z

src/pages/iou/request/step/IOURequestStepDescription.tsx

    // In the split flow, when editing we use SPLIT_TRANSACTION_DRAFT to save draft value
    const isEditingSplitBill = iouType === CONST.IOU.TYPE.SPLIT && action === CONST.IOU.ACTION.EDIT;
-    const currentDescription =
-        isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? lodashGet(splitDraftTransaction, 'comment.comment', '') : lodashGet(transaction, 'comment.comment', '');
+    const currentDescription = isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? splitDraftTransaction?.comment.comment ?? '' : transaction?.comment.comment ?? '';


Suggested change

const currentDescription = isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? splitDraftTransaction?.comment.comment ?? '' : transaction?.comment.comment ?? '';

const currentDescription = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction?.comment.comment ?? '' : transaction?.comment.comment ?? '';

Couldn't we use isEmptyObject instead of lodash here?

I missed that one, +1

kubabutkiewicz · 2024-03-29T15:58:01Z

@getusha kind bump 😄

getusha · 2024-03-29T17:00:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-29.at.11.48.55.at.night.mov

Android: mWeb Chrome

Screen.Recording.2024-03-29.at.9.06.21.at.night.mov

iOS: Native

Screen.Recording.2024-03-29.at.11.55.28.at.night.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.9.12.46.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.8.56.22.in.the.evening.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.9.41.31.at.night.mov

getusha

LGTM, can we remove IOURequestStepCurrency from the title 😄 & check this comment thanks!

melvin-bot · 2024-03-29T21:52:30Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #38917 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

fabioh8010 · 2024-04-02T08:48:33Z

LGTM, can we remove IOURequestStepCurrency from the title 😄 & check this comment thanks!

cc @war-in

@mountiny Could you assign an engineer here? Thanks

lakchote · 2024-04-02T11:05:06Z

LGTM 👍

OSBotify · 2024-04-02T11:14:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:55:32Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

war-in added 4 commits March 26, 2024 10:41

migrate step date

b71feac

migrate IOURequestStepDescription

85621d3

add missing types

9d8e8a1

Merge branch 'main' into ts/war-in/iou-request-step-desc-date

ff173b4

war-in commented Mar 27, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDescription.tsx Show resolved Hide resolved

fix wrong HOC order

fffd56b

blazejkustra suggested changes Mar 27, 2024

View reviewed changes

blazejkustra mentioned this pull request Mar 27, 2024

[TS migration] Migrate IOURequestStepTaxRatePage and IOURequestStepTaxAmountPage to TypeScript #39059

Merged

51 tasks

review suggestions

bbce2e0

war-in requested a review from blazejkustra March 28, 2024 07:39

blazejkustra approved these changes Mar 28, 2024

View reviewed changes

kubabutkiewicz approved these changes Mar 28, 2024

View reviewed changes

war-in marked this pull request as ready for review March 28, 2024 13:59

war-in requested a review from a team as a code owner March 28, 2024 13:59

melvin-bot bot removed the request for review from a team March 28, 2024 13:59

melvin-bot bot requested a review from getusha March 28, 2024 13:59

fabioh8010 approved these changes Mar 28, 2024

View reviewed changes

getusha approved these changes Mar 29, 2024

View reviewed changes

getusha approved these changes Apr 2, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote April 2, 2024 09:06

blazejkustra mentioned this pull request Apr 2, 2024

[TS migration] Migrate StepScreenWrapper, StepScreenDragAndDropWrapper, IOURequestStepConfirmation and IOURequestStepCategory pages to TypeScript #39175

Merged

50 tasks

lakchote approved these changes Apr 2, 2024

View reviewed changes

lakchote merged commit 5cdfbb7 into Expensify:main Apr 2, 2024
18 of 23 checks passed

war-in changed the title ~~[TS migration] Migrate IOURequestStepDescription, IOURequestStepDate and IOURequestStepCurrency pages to TypeScript~~ [TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript Apr 3, 2024

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [TS migration] Migrate IOURequestStepDescription, IOURequestStepDate and IOURequestStepCurrency pages to TypeScript #38917

Closed

war-in deleted the ts/war-in/iou-request-step-desc-date branch June 24, 2024 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

[TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

war-in commented Mar 26, 2024 •

edited

Loading

blazejkustra left a comment

kubabutkiewicz left a comment

melvin-bot bot commented Mar 28, 2024

fabioh8010 Mar 28, 2024

blazejkustra Mar 28, 2024

kubabutkiewicz commented Mar 29, 2024

getusha commented Mar 29, 2024 •

edited

Loading

getusha left a comment

melvin-bot bot commented Mar 29, 2024

fabioh8010 commented Apr 2, 2024

lakchote commented Apr 2, 2024

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

	const currentDescription = isEditingSplitBill && !lodashIsEmpty(splitDraftTransaction) ? splitDraftTransaction?.comment.comment ?? '' : transaction?.comment.comment ?? '';
	const currentDescription = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction?.comment.comment ?? '' : transaction?.comment.comment ?? '';

[TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

[TS migration] Migrate IOURequestStepDescription and IOURequestStepDate pages to TypeScript #38995

Conversation

war-in commented Mar 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra left a comment

Choose a reason for hiding this comment

kubabutkiewicz left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 28, 2024

fabioh8010 Mar 28, 2024

Choose a reason for hiding this comment

blazejkustra Mar 28, 2024

Choose a reason for hiding this comment

kubabutkiewicz commented Mar 29, 2024

getusha commented Mar 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 29, 2024

fabioh8010 commented Apr 2, 2024

lakchote commented Apr 2, 2024

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

war-in commented Mar 26, 2024 •

edited

Loading

getusha commented Mar 29, 2024 •

edited

Loading