Enlarge emojis within text #37980

kbieganowski · 2024-03-08T15:12:46Z

Details

Fixed Issues

$ #4114

PROPOSAL: n/a

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

github-actions · 2024-03-08T15:13:02Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

kbieganowski · 2024-03-08T15:25:43Z

I have read the CLA Document and I hereby sign the CLA

MrRefactor · 2024-03-08T15:34:05Z

src/libs/EmojiUtils.ts

@@ -564,6 +564,47 @@ function getSpacersIndexes(allEmojis: EmojiPickerList): number[] {
    return spacersIndexes;
 }

+const emojiRegex = /(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])/;


move it to CONST file

MrRefactor · 2024-03-08T15:34:18Z

src/libs/EmojiUtils.ts

+ * Split string into plain text and emojis array with attention to surrogate pairs
+ * @param text
+ */
+const splitTextWithEmojis = (text: string) => {


return type

…ue with emojis layout resolved

pecanoro · 2024-04-09T12:30:44Z

Any updates here? Since the PR has been opened for a while now

kbieganowski · 2024-04-10T08:07:18Z

Hi @pecanoro I'm still working on some ios and android issues, more info can be found in this update #4114 (comment)

kbieganowski · 2024-04-22T13:14:17Z

Closing this PR in favour of #40692 (amount of conflicts was not worth wasting the time to resolve them commit by commit)

MrRefactor reviewed Mar 8, 2024

View reviewed changes

kbieganowski mentioned this pull request Mar 8, 2024

[HOLD for payment 2024-12-03] [$1000] Make emojis larger in other contexts than just single character messages #4114

Closed

mananjadhav mentioned this pull request Mar 31, 2024

[HOLD PR #47547] [$1000] Emoji size from email reply is smaller then emoji size sent via normal chat and emoji does not use user selected skin color #14753

Open

6 tasks

kbieganowski added 4 commits April 3, 2024 14:39

conflicts resolved

60206ca

conflicts resolved

a9024b4

wip: update text and emoji splitting logic and messages layout fixes

13182fd

conflicts resolved

a6768d3

kbieganowski force-pushed the fix/enlarge-emojis-within-text branch from b906650 to a6768d3 Compare April 3, 2024 13:18

wip: change emojis size in composer based on input value, android iss…

9869ec4

…ue with emojis layout resolved

wip: fix cut emojis issue in inputs on native

e0b43c5

kbieganowski closed this Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enlarge emojis within text #37980

Enlarge emojis within text #37980

kbieganowski commented Mar 8, 2024 •

edited

Loading

github-actions bot commented Mar 8, 2024 •

edited

Loading

kbieganowski commented Mar 8, 2024

MrRefactor Mar 8, 2024

MrRefactor Mar 8, 2024

pecanoro commented Apr 9, 2024

kbieganowski commented Apr 10, 2024

kbieganowski commented Apr 22, 2024

Enlarge emojis within text #37980

Enlarge emojis within text #37980

Conversation

kbieganowski commented Mar 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Mar 8, 2024 • edited Loading

kbieganowski commented Mar 8, 2024

MrRefactor Mar 8, 2024

Choose a reason for hiding this comment

MrRefactor Mar 8, 2024

Choose a reason for hiding this comment

pecanoro commented Apr 9, 2024

kbieganowski commented Apr 10, 2024

kbieganowski commented Apr 22, 2024

kbieganowski commented Mar 8, 2024 •

edited

Loading

github-actions bot commented Mar 8, 2024 •

edited

Loading