Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Receipt Audit Feature / Note type violations. #37813
feat: Receipt Audit Feature / Note type violations. #37813
Changes from 11 commits
9467b3a
8c400c3
96744d5
952a4da
8438383
7f97519
cebc960
86014ab
3db41da
afb1afb
b538331
48d1543
77165e7
699bb28
25cc0fa
da3ae8c
f2a59fd
fd457cd
7a194c9
0de547a
b785e1f
f4e118a
67d7dc4
80b7eb5
bfec360
d9975d8
269163f
ae2324e
4bb11b5
899f12c
4225d83
98ef4fb
78b79cc
87270fb
51cb29d
cd91773
ca0650b
943df82
cd52fee
1ae1c5b
31f34a8
2c9ab1e
8f17210
148c2b9
ace1043
cfbddf1
a0a2fc3
812fd14
9fbf78e
4081f85
e117ef5
22e6fcb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 Is the violation type 'note' for such violations? What type do we use for violation messages? Can we reuse the existing method for violation messages? If you have any confusion, please do raise it on the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobitneupane, I guess we need to pass array of strings to
ReceiptAudit
component so we need to extract like this. The type for violation messages isviolation
.App/src/libs/TransactionUtils.ts
Line 593 in b7a230e
@JmillsExpensify can you pls confirm if the type for note type violation is
note
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 type for such violation is "notice"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 If there is no receipt in the request, I believe we do raise note type violation.
hasNoteTypeViolation
will return true in MoneyRequestPreviewContext resulting Review Required sub-state but we don't show any receipt audit message because hasReceipt is false. This would create discrepancy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be resolved with the linked commit.
And this also:
Commit: fd457cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 Did we verify if it is the correct translation? We can ask for the correct translations in slack channel.