Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176

FitseTLT · 2024-02-24T21:22:44Z

Details

Fixed Issues

$ #36264
PROPOSAL: #36264 (comment)

Tests

Open https://staging.new.expensify.com/
Log in with the account of the employee added to the policy
Navigate to the group policy chat room
Create a manual request and send it to the WS room
Open https://staging.new.expensify.com/
in incognito mode
Log in to the policy administrator account
Pay the money request from the employee
Go to the details of the paid IOU
Click on the Tag field to display a list of available tags
Copy the URL address
Paste and send the copied URL in the IOU details
On behalf of the employee, go to the details of the paid IOU
Click on the link sent by the administrator
Check that not found page is displayed instead of tag picker page

Verify that no errors appear in the JS console

Offline tests

same

QA Steps

same

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-02-24T21:22:48Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-02-26T19:13:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ishpaul777 · 2024-02-26T19:14:03Z

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-05.at.2.36.35.AM.mov

Screen.Recording.2024-03-05.at.2.39.36.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-27.at.1.48.00.AM.mov

iOS: Native

Screen.Recording.2024-03-05.at.2.19.09.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-27.at.1.20.18.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-26.at.1.51.21.AM.mov

MacOS: Desktop

Screen.Recording.2024-02-27.at.2.32.23.AM.mov

ishpaul777 · 2024-02-26T19:45:30Z

back button position doesn't seem to correct @FitseTLT

FitseTLT · 2024-02-28T20:08:20Z

@ishpaul777 Proceed with your review

ishpaul777 · 2024-03-03T01:04:27Z

@FitseTLT can you merge main behind 700+ commits

FitseTLT · 2024-03-03T19:48:18Z

Merged

ishpaul777

LGTM!

ishpaul777 · 2024-03-04T21:17:54Z

@FitseTLT please update videos as the recorded was added before latest commits and has the bug #37176 (comment) visible

neil-marcellini

Looks great as is.

NAB: Should we make this the default behavior for the step screen wrapper? Internally it could set shouldShowNotFoundPage if you are editing and are not allowed to. If you want to do this in a follow up, please raise another PR and tag me for review.

neil-marcellini · 2024-03-05T19:56:45Z

src/pages/iou/request/step/IOURequestStepTag.js

@@ -12,7 +12,9 @@ import compose from '@libs/compose';
 import * as IOUUtils from '@libs/IOUUtils';
 import Navigation from '@libs/Navigation/Navigation';
 import * as PolicyUtils from '@libs/PolicyUtils';
+import {canEditMoneyRequest} from '@libs/ReportUtils';


NAB: I think we generally prefer import * in our style, but I can't actually find a rule about that.

OSBotify · 2024-03-05T21:34:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-06T22:05:12Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-07T23:51:12Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mkhutornyi · 2024-03-14T19:35:52Z

src/pages/iou/request/step/IOURequestStepTag.js

+    const parentReportAction = parentReportActions[report.parentReportActionID];
+
+    // eslint-disable-next-line rulesdir/no-negated-variables
+    const shouldShowNotFoundPage = isEditing && !canEditMoneyRequest(parentReportAction);


While updating not found logic here, the case of P2P request could also have been considered as it doesn't make sense to show tags page in P2P.
Issue: #37207

Don't know how this pr is considered as the offending PR to that issue as it wasn't merged when that issue was created and this pr is still younger than yours 😄

There's no specific offending PR for #37207.
I also didn't say that this one is the offending PR but just missing case.

display not found page on deeplink unauthorized access for tag page

46cb964

FitseTLT requested a review from a team as a code owner February 24, 2024 21:22

melvin-bot bot removed the request for review from a team February 24, 2024 21:22

melvin-bot bot requested a review from ishpaul777 February 24, 2024 21:22

FitseTLT added 2 commits February 28, 2024 22:16

Merge branch 'main' into fix-deeplink-tag-page-bug

ca95fb3

moved not found page under screen wrapper

cb31a15

Merge branch 'main' into fix-deeplink-tag-page-bug

1b084e5

ishpaul777 approved these changes Mar 4, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini March 4, 2024 21:15

neil-marcellini approved these changes Mar 5, 2024

View reviewed changes

neil-marcellini merged commit a36b0fc into Expensify:main Mar 5, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Mar 6, 2024

Deploy Checklist: New Expensify 2024-03-06 #37845

Closed

63 tasks

melvin-bot bot mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-03-19] [HOLD for payment 2024-03-14] [$500] IOU - An employee can access in a paid IOU the tag selection menu via a URL request #36264

Closed

6 tasks

mkhutornyi reviewed Mar 14, 2024

View reviewed changes

mkhutornyi mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat #37207

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176

Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176

FitseTLT commented Feb 24, 2024

melvin-bot bot commented Feb 24, 2024

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 26, 2024 •

edited

Loading

FitseTLT commented Feb 28, 2024

ishpaul777 commented Mar 3, 2024

FitseTLT commented Mar 3, 2024

ishpaul777 left a comment

ishpaul777 commented Mar 4, 2024

neil-marcellini left a comment

neil-marcellini Mar 5, 2024

OSBotify commented Mar 5, 2024

OSBotify commented Mar 6, 2024

OSBotify commented Mar 7, 2024

mkhutornyi Mar 14, 2024

FitseTLT Mar 14, 2024

mkhutornyi Mar 14, 2024

Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176

Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176

Conversation

FitseTLT commented Feb 24, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 24, 2024

ishpaul777 commented Feb 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Feb 26, 2024 • edited Loading

Screenshots/Videos

ishpaul777 commented Feb 26, 2024 • edited Loading

FitseTLT commented Feb 28, 2024

ishpaul777 commented Mar 3, 2024

FitseTLT commented Mar 3, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

ishpaul777 commented Mar 4, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini Mar 5, 2024

Choose a reason for hiding this comment

OSBotify commented Mar 5, 2024

OSBotify commented Mar 6, 2024

OSBotify commented Mar 7, 2024

mkhutornyi Mar 14, 2024

Choose a reason for hiding this comment

FitseTLT Mar 14, 2024

Choose a reason for hiding this comment

mkhutornyi Mar 14, 2024

Choose a reason for hiding this comment

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 26, 2024 •

edited

Loading