Improve flagging the users as texting Concierge from the OldDot on web #37088

rezkiy37 · 2024-02-22T15:55:39Z

Details

The PR improves a flow how the app detects if it was redirected from OldDot. When the user writes to Concierge from the NewDot on the web, the app informs the backend that the user is coming/texting from OldDot. However, the app forgets an initial deep-link if a tab was refreshed. The PR adds a logic to persist the initial deep-link via the sessionStorage.

Fixed Issues

$ #35565
PROPOSAL: #35565 (comment)

Tests

Start Concierge from OldDot web. Also, you can use a next endpoint /transition?accountID=<ACCOUNT_ID>&email=<LOGIN>&exitTo=r%2F<CONCIERGE_REPORT_ID>&shouldForceLogin=false.
Get redirected to the Concierge chat in NewDot in a new tab.
Send a message to Concierge.
Verify that the API command AddComment includes isOldDotConciergeChat and equals true.
Verify that in the Concierge tool, the message is marked as coming from OldDot.
The user refreshes the tab with the Concierge chat in NewDot.
Send a message to Concierge.
Verify that the API command AddComment includes isOldDotConciergeChat and equals true.
Verify that in the Concierge tool, the message is marked as coming from OldDot.
The user duplicates the tab with the Concierge chat in NewDot.
Send a message to Concierge.
Verify that the API command AddComment includes isOldDotConciergeChat and equals true.
Verify that in the Concierge tool, the message is marked as coming from OldDot.
The user opens a new tab with Concierge chat in NewDot without using OldDot.
Send a message to Concierge.
Verify that the API command AddComment does not include isOldDotConciergeChat and equals true.
Verify that in the Concierge tool, the message is not marked as coming from OldDot.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Ping @cristipaval to QA this.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

IOS.Safari.3.mp4

MacOS: Chrome / Safari

Chrome.1.mp4

MacOS: Desktop

N/A

…ture/35565-improve-flagging-user-texting-concierge

This reverts commit afd0f5f.

…ture/35565-improve-flagging-user-texting-concierge

melvin-bot · 2024-02-26T17:34:00Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2024-02-27T17:45:21Z

Hi, Code seems to be fine. Let me test in my morning and update here.

abdulrahuman5196 · 2024-02-29T07:56:03Z

REviewing now

abdulrahuman5196 · 2024-02-29T11:04:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.4.21.20.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.4.11.17.PM.mp4

MacOS: Desktop

N/A

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @cristipaval

🎀 👀 🎀
C+ Reviewed

cristipaval

Thanks @rezkiy37 and @abdulrahuman5196 🙌

OSBotify · 2024-02-29T12:31:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T23:43:22Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2024-03-04T19:04:07Z

src/libs/actions/Report.ts

-    const exitToRoute = params.get('exitTo') ?? '';
-    const {reportID} = ReportUtils.parseReportRouteParams(exitToRoute);
-    reportIDDeeplinkedFromOldDot = reportID;
+    const isWeb = ([CONST.PLATFORM.WEB] as unknown as string).includes(getPlatform());


this code is not in compliance with our standards for cross-platform code. @rezkiy37 @abdulrahuman5196 @cristipaval please review App Philosophy with particular emphasis on item 5. Then please open a follow-up PR to implement this in a way that's compliant with our code standards. Thanks!

Okay. I will prepare an additional PR. Ty!

I am preparing a PR to fix it.

roryabraham · 2024-03-04T19:04:59Z

src/libs/actions/Report.ts

+    const {reportID: currentReportID} = ReportUtils.parseReportRouteParams(currentExitToRoute);
+
+    if (!isWeb) {
+        reportIDDeeplinkedFromOldDot = currentReportID;


isn't it possible that someone could click a link in OldDot web and have it open a native app?

I tested this scenario a few times. It always opens a browser to handle a deep link. It proposes to open a native app, once you get a report screen opened. Therefore, it does not need to handle the deep link anymore.

OSBotify · 2024-03-04T20:25:36Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rezkiy37 added 10 commits February 20, 2024 17:20

add a new onyx key - initial url

afd0f5f

implement handling of a prev initial url

fa2e3ce

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

0ef8e19

…ture/35565-improve-flagging-user-texting-concierge

Revert "add a new onyx key - initial url"

c57bd66

This reverts commit afd0f5f.

add session storage key const

6f1b2e3

integrate handling of a prev initial url via session storage

7297d97

remove dev. mode return

ba66ff0

check for web only

036dc29

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

288ab2c

…ture/35565-improve-flagging-user-texting-concierge

handle if not wab as before

8fb2888

rezkiy37 mentioned this pull request Feb 23, 2024

[HOLD for payment 2024-03-22] [HOLD for payment 2024-03-11] [$500] Improve flagging the users as texting Concierge from the OldDot on web #35565

Closed

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

011db88

…ture/35565-improve-flagging-user-texting-concierge

rezkiy37 marked this pull request as ready for review February 26, 2024 17:33

rezkiy37 requested a review from a team as a code owner February 26, 2024 17:33

melvin-bot bot removed the request for review from a team February 26, 2024 17:33

melvin-bot bot requested a review from abdulrahuman5196 February 26, 2024 17:34

abdulrahuman5196 approved these changes Feb 29, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval February 29, 2024 11:09

cristipaval added the InternalQA This pull request required internal QA label Feb 29, 2024

cristipaval approved these changes Feb 29, 2024

View reviewed changes

cristipaval merged commit 04c8305 into Expensify:main Feb 29, 2024
17 checks passed

github-actions bot mentioned this pull request Feb 29, 2024

Deploy Checklist: New Expensify 2024-02-29 #37578

Closed

36 tasks

roryabraham reviewed Mar 4, 2024

View reviewed changes

rayane-djouah mentioned this pull request Mar 4, 2024

[HOLD for payment 2024-04-05] [$500] Internal QA checklist not working for external PRs #37691

Closed

rezkiy37 mentioned this pull request Mar 5, 2024

Fix cross platform concern of the improve flagging feature #37754

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve flagging the users as texting Concierge from the OldDot on web #37088

Improve flagging the users as texting Concierge from the OldDot on web #37088

rezkiy37 commented Feb 22, 2024 •

edited by cristipaval

Loading

melvin-bot bot commented Feb 26, 2024

abdulrahuman5196 commented Feb 27, 2024

abdulrahuman5196 commented Feb 29, 2024

abdulrahuman5196 commented Feb 29, 2024 •

edited

Loading

abdulrahuman5196 left a comment

cristipaval left a comment

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

roryabraham Mar 4, 2024

rezkiy37 Mar 5, 2024

rezkiy37 Mar 5, 2024

roryabraham Mar 4, 2024

rezkiy37 Mar 5, 2024

OSBotify commented Mar 4, 2024

Improve flagging the users as texting Concierge from the OldDot on web #37088

Improve flagging the users as texting Concierge from the OldDot on web #37088

Conversation

rezkiy37 commented Feb 22, 2024 • edited by cristipaval Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 26, 2024

abdulrahuman5196 commented Feb 27, 2024

abdulrahuman5196 commented Feb 29, 2024

abdulrahuman5196 commented Feb 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

cristipaval left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

roryabraham Mar 4, 2024

Choose a reason for hiding this comment

rezkiy37 Mar 5, 2024

Choose a reason for hiding this comment

rezkiy37 Mar 5, 2024

Choose a reason for hiding this comment

roryabraham Mar 4, 2024

Choose a reason for hiding this comment

rezkiy37 Mar 5, 2024

Choose a reason for hiding this comment

OSBotify commented Mar 4, 2024

rezkiy37 commented Feb 22, 2024 •

edited by cristipaval

Loading

abdulrahuman5196 commented Feb 29, 2024 •

edited

Loading