Migrate pages group 1

[ghost]

Details

Fixed Issues

$ #36274
PROPOSAL: #36274 (comment)

Tests

• Verify that no errors appear in the JS console

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

Offline tests

QA Steps

• Verify that no errors appear in the JS console

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[ghost]

I have read the CLA Document and I hereby sign the CLA

[melvin-bot]

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ghost]

Hey! Looks like a PR, just got recently merged which migrated the components that I have been working on which is WorkspaceProfilePage.tsx and WorkspaceProfileCurrencyPage.tsx.

cc - @ntdiary

[ntdiary]

Hey! Looks like a PR, just got recently merged which migrated the components that I have been working on which is WorkspaceProfilePage.tsx and WorkspaceProfileCurrencyPage.tsx.

cc - @ntdiary

So, we can revert these two files and resolve the conflict based on the main branch. :)

[ghost]

Hey! Looks like a PR, just got recently merged which migrated the components that I have been working on which is WorkspaceProfilePage.tsx and WorkspaceProfileCurrencyPage.tsx.
cc - @ntdiary

So, we can revert these two files and resolve the conflict based on the main branch. :)

Will do it @ntdiary

[ghost]

The ProcessMoneyRequestHoldPage.tsx was also merged in this PR (3 days ago) that is why it has been removed as I resolved the merge conflict which also removed this - ProcessMoneyRequestHoldPage.tsx file as well

[ghost]

Hey @blazejkustra ! I hope everything is fine now regarding this PR?

[blazejkustra]

@godofoutcasts94 Yes, looks good to me!

[ghost]

@ntdiary if you are available. Please review this PR and let's close it as soon as possible.

[ntdiary]

@godofoutcasts94 , a minor change, can you please rename the file to SearchInputManager.ts, because it doesn't contain React syntax. Also, I'll be running tests concurrently. :)

[ghost]

@godofoutcasts94 , a minor change, can you please rename the file to SearchInputManager.ts, because it doesn't contain React syntax. Also, I'll be running tests concurrently. :)

sure, I will do it since I was a bit skeptical about it. So, I renamed it as tsx

[ntdiary]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

36681-android-native.mp4

Android: mWeb Chrome

36681-android-chrome.mp4

iOS: Native

36681-ios-native.mp4

iOS: mWeb Safari

36881-ios-safari.mp4

MacOS: Chrome / Safari

36681-web.mp4

MacOS: Desktop

36681-desktop.mp4

[ntdiary]

@godofoutcasts94, eh, don't worry, this is reviewer's checklist, which needs to be filled by me, you don't need to fill it. 😂

[ntdiary]

I've already filled out my reviewer checklist. @godofoutcasts94, have you renamed the file? Also, considering the actual changes to the files, we need to ensure that the normal page becomes PrivateNotesEditPage and WorkspaceInvitePage, you can update the test steps :)

[ghost]

I've already filled out my reviewer checklist. @godofoutcasts94, have you renamed the file? Also, considering the actual changes to the files, we need to ensure that the normal page becomes PrivateNotesEditPage and WorkspaceInvitePage, you can update the test steps :)

Yes yes that's what I was talking about regarding updating the tests steps. No I haven't renamed the file yet. I will do it right away.

[ghost]

I've already filled out my reviewer checklist. @godofoutcasts94, have you renamed the file? Also, considering the actual changes to the files, we need to ensure that the normal page becomes PrivateNotesEditPage and WorkspaceInvitePage, you can update the test steps :)

Renamed the file from tsx to ts

[ghost]

I've already filled out my reviewer checklist. @godofoutcasts94, have you renamed the file? Also, considering the actual changes to the files, we need to ensure that the normal page becomes PrivateNotesEditPage and WorkspaceInvitePage, you can update the test steps :)

Updated the test steps with new screenshots/videos. Now please review and let me know if everything is fine according to you @ntdiary.

[ntdiary]

@godofoutcasts94, here are the steps I suggested. You can just update with them, without re-uploading the video. :)

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

[ghost]

@godofoutcasts94, here are the steps I suggested. You can just update with them, without re-uploading the video. :)

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

Done @ntdiary. Hope I am not ruining things for you or maybe irritating you which may lead to issues for me.

[ntdiary]

@godofoutcasts94, here are the steps I suggested. You can just update with them, without re-uploading the video. :)

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

Done @ntdiary. Hope I am not ruining things for you or maybe irritating you which may lead to issues for me.

Ah? Don't worry, collaboration is enjoyable, please feel free to submit more proposals and resolve more issues. 😄

[ntdiary]

LGTM.

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #36274 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[ghost]

@godofoutcasts94, here are the steps I suggested. You can just update with them, without re-uploading the video. :)

1. Re-login in with an account that has personal chat and workspace.
2. Open any personal chat and select Private notes option.
3. Verify that the page can display loading state normally before the first rendering is completed.
4. Navigate to Workspace > Members > Invite new members page.
5. Verify that the page can load and filter based on input normally.

Done @ntdiary. Hope I am not ruining things for you or maybe irritating you which may lead to issues for me.

Ah? Don't worry, collaboration is enjoyable, please feel free to submit more proposals and resolve more issues. 😄

Thanks a lot for such support.

[blimpich]

Looks good, one comment then I think we can merge.

[blimpich]

LGTM! Nice job!

[ghost]

LGTM! Nice job!

Thanks ! @blimpich

[OSBotify]

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅