fix breadcumbs font auto scaling

[dukenv0307]

Details

Fixed Issues

$ #35785
PROPOSAL: #35785 (comment)

Tests

1. Kill the app if it is in the background
2. Change device font size to the minimum
3. Relaunch New Expensify app
4. Verify that "/ Chats" is on the same line as Expensify logo
5. Tap Settings from the bottom
6. Verify that "/ Settings" is on the same line as Expensify logo
7. Select a workspace
8. Verify that "Workspace / Settings" is on the same line

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Kill the app if it is in the background
2. Change device font size to the minimum
3. Relaunch New Expensify app
4. Verify that "/ Chats" is on the same line as Expensify logo
5. Tap Settings from the bottom
6. Verify that "/ Settings" is on the same line as Expensify logo
7. Select a workspace
8. Verify that "Workspace / Settings" is on the same line

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@shawnborton @Ollyws One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36655/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36655/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36655/NewExpensify.dmg	https://36655.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

cc @Expensify/design for review too

@dukenv0307 this seems fine from your screenshots, but hard to tell. What happens when you scale the device font size to be quite larger as well?

[Ollyws]

The font does seem to get cut off when the text size is set to largest:

[shawnborton]

Cool, we should probably fix that case as I'm sure it will come up in a future bug report 🤣

[Ollyws]

cc: @dukenv0307

[dukenv0307]

@Ollyws I just updated code, please check again.

android-resize.mp4

[Ollyws]

Thanks for the update.

Here are a couple of screenshots with the text size turned up to it's maxiumum on iOS, it generally looks good apart from the overflow on the settings doesn't have any margin on the right. Curious to know the design team's thoughts.

Chats	Settings

[mountiny]

@shawnborton what do you think, not sure if there is any ideal solution here

[shawnborton]

Yeah... this is where I think we should cap the amount that the font should grow. I have no idea if that breaks any kind of accessibility rule, but at some point we simply can't fit any kind of text in the available space with a font size that large.

[mountiny]

@dukenv0307 is it possible to cap the font size somehow?

[dukenv0307]

@Ollyws this is my device when the text size turned up to it's maxiumum on iOS

Max font	Chat	Settings

[dukenv0307]

If we want to cap the font size, we can pass the value to maxFontSizeMultiplier as a prop to handle the largest possible scale a font can reach.

[mountiny]

@dukenv0307 I think that would be great! @shawnborton what font size do we want to allow as max?

[shawnborton]

I'd be curious to see a couple of different options here. Personally I think even just 2-3x the normal font size there would be a good cap?

Also, are we able to get the wordmark to scale proportionally with the font size too?

[mountiny]

@dukenv0307 can you provide couple screenshots of these sizes?

Also will this be fixed by your changes? https://expensify.slack.com/archives/C01GTK53T8Q/p1709063185695719 I dont think so

[dukenv0307]

Case maxFontSizeMultiplier = 2:

Chat	Settings

Case maxFontSizeMultiplier = 3:

Chat	Settings

[dukenv0307]

Also will this be fixed by your changes? https://expensify.slack.com/archives/C01GTK53T8Q/p1709063185695719 I dont think so

@mountiny Yes, it can be fixed by my changes in this PR

[shawnborton]

Can we see it with a max multiplier of something like 1.5? The 2 and 3 cases seem like this particular text is so much larger than say the chat rows below it.

[shawnborton]

I understand, but it is supposed to look like text and I think it should scale along with the font size adjustments.

[dubielzyk-expensify]

But if we still want to scale it, we can get the font scale ratio and also scale the height and width of the logo/icon (along with other related things like the environment badge) according to that ratio.

Yeah, this is actually exactly what we want. They need to look proportional next to each other. I think what you've mentioned is a clever solution so I recon that's the way to go @dukenv0307

[dukenv0307]

Currently, we use getValueUsingPixelRatio to handle resizing breadcrumbs font size and we set default is 19, and max is 32 . So here, we should limit the scale value of Expensify's logo.
Here is the result when I set maxScale = 1.5

ios-resize.mp4

@shawnborton @dubielzyk-expensify what do you think?

[shawnborton]

That feels pretty good to me. And then when the font is set to a normal/default size, how does it look?

[dubielzyk-expensify]

Yeah same as Shawn. That's looking pretty good to me from those two settings at least. Perhaps do a few and upload as screenshots so we can see a few more variations?

[dukenv0307]

Here are some variations @shawnborton @dubielzyk-expensify

Setting	Screen Shot

[shawnborton]

Cool, I just want to make sure the default iOS text setting doesn't scale up/down the wordmark or text in any way. Can you confirm that when you get a moment? Thanks!

[dukenv0307]

the default iOS text setting doesn't scale up/down the wordmark or text in any way.

@shawnborton i confirm this

[shawnborton]

Sounds good, thanks!

[mountiny]

Ok I think we are all set up then @Ollyws would you be able to complete the checklist?

[Ollyws]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

06_MacOS_Desktop.mp4

MacOS: Desktop

MacOS_Safari.mp4

[Ollyws]

LGTM.

[mountiny]

Thanks everyone

[melvin-bot]

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mountiny]

not an emergency

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅