feat: add additional full screen engagement modal to NewDot #35019

teneeto · 2024-01-23T23:54:43Z

Details

Adds additional screens - new Engagement Modal that pops up for new users on the site, and sends concierge messages related to their choices.

Fixed Issues

$ #34468
PROPOSAL: issue-2079898524

Also fixes: #35663

Tests

New Account

Create a new account on NewDot
Make sure you see the engagement modal
Choose any option
Make sure that concierge sends you a message based on that option (on mobile, you should be brought to the concierge chat page)
Sign out and back in
Make sure the message is still there and that the modal does not re-appear
Repeat this for all options

Existing Account

Log into an account that is on a workspace already
Make sure that the modal does not appear

Completed on OldDot

Create a new account on OldDot
Wait for the RHP to pop up
Select any option
Sign into newDot on the same account
Make sure that the modal does not appear

Closed on OldDot

Create a new account on OldDot
Wait for the RHP to pop up
Select the x in the top right
Sign into newDot on the same account
Make sure that the modal does not appear

Closed on NewDot

Create a new account on NewDot
Click the x on the modal
Refresh the page
Make sure that the modal does not re-appear

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-01.at.17.46.25.mov

Android: mWeb Chrome

Screen.Recording.2024-02-05.at.10.20.43.mov

iOS: Native

Screen.Recording.2024-01-31.at.16.21.36.mov

iOS: mWeb Safari

Screen.Recording.2024-01-31.at.16.56.33.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-31.at.16.04.14.mov

MacOS: Desktop

Screen.Recording.2024-01-31.at.17.01.34.mov

marcaaron · 2024-02-06T22:34:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron · 2024-02-06T22:35:37Z

Going to do a quick run through on the testing and should merge by EOD

github-actions · 2024-02-06T22:54:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35019/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35019/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://35019.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

github-actions · 2024-02-06T23:59:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35019/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35019/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35019/NewExpensify.dmg	https://35019.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

marcaaron · 2024-02-07T01:47:22Z

Left an update here. It is failing in Desktop and Web. I think there was some recent regression here that could be related.

marcaaron · 2024-02-07T02:08:44Z

Desktop:

No engagement modal appears for new user

Web:

Engagement modal appears, but Concierge chat doesn't load behind it

2024-02-06_15-36-24.mp4

teneeto · 2024-02-07T07:16:31Z

@marcaaron how do we reconcile this? do we make that fix here, or wait for the bug to be fixed.

marcaaron · 2024-02-07T20:43:29Z

The proposed fix looks pretty simple we could try to incorporate it here and just close that other PR if it solves the issue.

marcaaron · 2024-02-07T20:58:46Z

Everything works for me with that line applied actually. I'm gonna propose we fold it into this PR so we can ship this.

marcaaron · 2024-02-07T21:08:48Z

@teneeto add these changes and I can approve + merge.

diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx
index 3e77433bd0..a953175fdc 100644
--- a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx
+++ b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx
@@ -43,7 +43,7 @@ function BottomTabBar({isLoadingApp = false}: PurposeForUsingExpensifyModalProps
         const routes = navigationState.routes;
         const currentRoute = routes[navigationState.index];

-        if (currentRoute && NAVIGATORS.BOTTOM_TAB_NAVIGATOR !== currentRoute.name) {
+        if (currentRoute && currentRoute.name !== NAVIGATORS.BOTTOM_TAB_NAVIGATOR && currentRoute.name !== NAVIGATORS.CENTRAL_PANE_NAVIGATOR) {
             return;
         }

…dditional-screens-for-engagement-modal

teneeto · 2024-02-07T22:15:23Z

@marcaaron Done ✅

Thanks for the intervention too.

github-actions · 2024-02-07T23:09:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/35019/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/35019/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/35019/NewExpensify.dmg	https://35019.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

marcaaron

Retested on all platforms and it's working and looking great.

OSBotify · 2024-02-07T23:31:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shubham1206agra · 2024-02-08T04:20:11Z

src/components/Icon/Expensicons.ts

@@ -109,7 +110,6 @@ import QuestionMark from '@assets/images/question-mark-circle.svg';
 import ReceiptSearch from '@assets/images/receipt-search.svg';
 import Receipt from '@assets/images/receipt.svg';
 import Rotate from '@assets/images/rotate-image.svg';
-import RotateLeft from '@assets/images/rotate-left.svg';


@teneeto Is there a reason why this was removed?
This created a regression here

@marcaaron If you agree, can we handle this in #35663?

@ shubham1206agra, I omitted it in a merge conflict. Is there an issue for it I can add it ASAP.

Actually, I was thinking of doing it in #35663 since the actual PR was migrated here.

Ok, that's brilliant too. whichever way is best, I'm here to assist when you need me. cc @marcaaron

Ah good catch, yes let's please fix these regressions as quickly as we can. Thanks!

Follow up PR #36144

OSBotify · 2024-02-08T18:43:40Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.39-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-12T14:01:19Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

add olddot-wireframe to Expensicons

c1ccade

teneeto changed the title ~~Add additional full screen engagement modal to NewDot~~ feat: add additional full screen engagement modal to NewDot Jan 23, 2024

teneeto added 7 commits January 24, 2024 16:56

add ManageTeamsExpensesModal

4f29dce

add ToExpensifyClassicModal

6a3ee83

fix lint

0b06dd6

fix prettier

31fe1b4

remove apos string

2ca5613

link modals

cfc2e68

set isVisible state

e802631

marcaaron self-requested a review January 25, 2024 21:43

marcaaron assigned teneeto Jan 25, 2024

teneeto added 19 commits January 31, 2024 02:12

add types for engagement modal

6cffe50

add screen constant for engagement modal

40a8fdc

add screen routes for engagement modal

fc8bcf0

link engagement modal screens to routes

f943c70

add engagement modal screens to stack Navigator

8377e70

add engagement modal stack Navigator to right modal navigator

06d9934

remove PurposeForUsingExpensifyModal from SideBarScreen

e10e810

remove setStates for rendering navigation

064cd97

remove modal set state and add button text translations

6495d7a

remove modal state options

41818d3

remove PurposeForUsingExpensifyModal from SideBarScreen for native

746d5ad

move all engagement related pages to pages

ffec205

update engagement file names

4244209

update engagement screens path in ModalStackNavigator

bb2c68f

refactor PurposeForUsingExpensifyPage

220dcce

navigate to ManageTeamsExpenses

c300112

add back navigation function

ccb9a14

navigate to HOME when close button is pressed

f58f9a1

remove iconFill

c495afa

marcaaron mentioned this pull request Feb 7, 2024

[$500] [Wave 8] [Ideal Nav] Android - "Welcome to Expensify" pop up does not appear when navigate to Concierge link #35663

Closed

6 tasks

teneeto added 2 commits February 7, 2024 23:08

Merge branch 'main' of github.com:teneeto/Expensify into feat/34468/a…

868b769

…dditional-screens-for-engagement-modal

update Onboard navigation factors

dd69810

teneeto dismissed stale reviews from marcaaron and dubielzyk-expensify via dd69810 February 7, 2024 22:14

marcaaron self-requested a review February 7, 2024 23:26

marcaaron approved these changes Feb 7, 2024

View reviewed changes

marcaaron merged commit 166aa80 into Expensify:main Feb 7, 2024
19 checks passed

shubham1206agra reviewed Feb 8, 2024

View reviewed changes

teneeto mentioned this pull request Feb 8, 2024

fix: add page theme for onboard engagement screen root #36144

Merged

50 tasks

shubham1206agra mentioned this pull request Feb 8, 2024

[$500] "Welcome to Expensify" modal is not dismissed when navigate to New Dot via link #36138

Closed

6 tasks

teneeto mentioned this pull request Feb 8, 2024

[HOLD for payment 2024-02-19] Build additional screens for engagement modal #34468

Closed

github-actions bot mentioned this pull request Feb 8, 2024

Deploy Checklist: New Expensify 2024-02-08 #36168

Closed

77 tasks

hoangzinh mentioned this pull request Feb 12, 2024

[$500] LHN - Banner remains opened when user taps outside the banner. #35583

Closed

6 tasks

Ollyws mentioned this pull request Jul 30, 2024

[PAID] [$250] Settings - A new user can navigate away from the onboarding modal using an URL #45260

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add additional full screen engagement modal to NewDot #35019

feat: add additional full screen engagement modal to NewDot #35019

teneeto commented Jan 23, 2024 •

edited by marcaaron

Loading

marcaaron commented Feb 6, 2024 •

edited

Loading

marcaaron commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

teneeto commented Feb 7, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

teneeto commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

marcaaron left a comment

OSBotify commented Feb 7, 2024

shubham1206agra Feb 8, 2024

teneeto Feb 8, 2024

shubham1206agra Feb 8, 2024

teneeto Feb 8, 2024

shawnborton Feb 8, 2024

MonilBhavsar Feb 8, 2024

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

feat: add additional full screen engagement modal to NewDot #35019

feat: add additional full screen engagement modal to NewDot #35019

Conversation

teneeto commented Jan 23, 2024 • edited by marcaaron Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

marcaaron commented Feb 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

github-actions bot commented Feb 6, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

teneeto commented Feb 7, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

marcaaron commented Feb 7, 2024

teneeto commented Feb 7, 2024

github-actions bot commented Feb 7, 2024

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 7, 2024

shubham1206agra Feb 8, 2024

Choose a reason for hiding this comment

teneeto Feb 8, 2024

Choose a reason for hiding this comment

shubham1206agra Feb 8, 2024

Choose a reason for hiding this comment

teneeto Feb 8, 2024

Choose a reason for hiding this comment

shawnborton Feb 8, 2024

Choose a reason for hiding this comment

MonilBhavsar Feb 8, 2024

Choose a reason for hiding this comment

OSBotify commented Feb 8, 2024

OSBotify commented Feb 12, 2024

teneeto commented Jan 23, 2024 •

edited by marcaaron

Loading

marcaaron commented Feb 6, 2024 •

edited

Loading