Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll behavior when single item is selected #34485

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Fix scroll behavior when single item is selected #34485

merged 7 commits into from
Jan 26, 2024

Commits on Jan 15, 2024

  1. Update useEffect to not scroll if multiple options cannot be selected

    @neonbhai
    neonbhai committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    26630b2 View commit details
    Browse the repository at this point in the history

  2. Define shouldScrollToTopOnSelect prop

    @neonbhai
    neonbhai committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b0742da View commit details
    Browse the repository at this point in the history

  3. Add prop shouldScrollToTopOnSelect to BaseSelectionList

    @neonbhai
    neonbhai committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    102862b View commit details
    Browse the repository at this point in the history

  4. Prettier

    @neonbhai
    neonbhai committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2543e1c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge branch 'Expensify:main' into scroll-behavior-fix

    @neonbhai
    neonbhai authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    24fa7c8 View commit details
    Browse the repository at this point in the history

  2. Remove shouldScrollToTopOnSelect prop 

    We remove this prop from BaseSelectionList as we don't have a usecase for now
    @neonbhai
    neonbhai committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fb49bc9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'main' of https://github.com/Expensify/App into scroll-b… 

    …ehavior-fix
    @neonbhai
    neonbhai committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a7e0e01 View commit details
    Browse the repository at this point in the history