[TS migration] Migrate 'AnchorForCommentsOnly' component to TypeScript #32670

VickyStash · 2023-12-07T14:28:08Z

Details

[TS migration] Migrate 'AnchorForCommentsOnly' component to TypeScript

Fixed Issues

$ #25135
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open any chat and send a link as a message, for example [test link](http://google.com/)
Make sure the message with a link looks and works as expected.
Hover on a link text and make sure tooltip with link URL appears (web/desktop step only)
Right click (on web/desktop) or long press (mobile) the link, you should see Copy URL popup, click on it and make sure URL is copied and the popup disappears.
Delete the message, make sure the delete popup looks and works as expected.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Open any chat and send a link as a message, for example [test link](http://google.com/)
Make sure the message with a link looks and works as expected.
Hover on a link text and make sure tooltip with link URL appears (web/desktop step only)
Right click (on web/desktop) or long press (mobile) the link, you should see Copy URL popup, click on it and make sure URL is copied and the popup disappears.
Delete the message, make sure the delete popup looks and works as expected.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

src/components/AnchorForCommentsOnly/index.native.tsx

src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

rezkiy37

Left comments.

kubabutkiewicz · 2023-12-07T20:11:21Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

                    style={StyleSheet.flatten([style, defaultTextStyle])}
                    role={CONST.ACCESSIBILITY_ROLE.LINK}
                    hrefAttrs={{
                        rel,
                        target: isEmail || !linkProps.href ? '_self' : target,
                    }}
-                    href={linkProps.href || href}
+                    href={href}


why you got rid of linkProps.href ?

Because it looks likelinkProps.href is or have href value or undefined anyway

App/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

Line 53 in d70f96b

linkProps.href = href;

# Conflicts: # src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

src/components/AnchorForCommentsOnly/index.native.tsx

src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

src/components/AnchorForCommentsOnly/types.ts

src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

src/components/AnchorForCommentsOnly/index.native.tsx

melvin-bot · 2023-12-14T14:47:33Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

VickyStash · 2023-12-15T07:35:42Z

Note: before merging these updates into the main, we need to merge main into the migration branch and make sure no new usages of old source CONTEXT_MENU_TYPES const appeared. Otherwise, there can be some regressions.

getusha · 2023-12-18T13:51:07Z

src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly.tsx

-                    href,
-                    lodashGet(linkRef, 'current'),
-                );
+                ReportActionContextMenu.showContextMenu(isEmail ? CONST.CONTEXT_MENU_TYPES.EMAIL : CONST.CONTEXT_MENU_TYPES.LINK, event, href, linkRef.current);


Should we add 'current' in linkRef check, to avoid possible crash?

@getusha hm, is there a case where linkRef doesn't have current field? I think ref object should have current value

Seems like we don't need it as the component is functional component.

getusha · 2023-12-18T13:52:58Z

src/pages/home/report/ContextMenu/ContextMenuActions.js

-const CONTEXT_MENU_TYPES = {
-    LINK: 'LINK',
-    REPORT_ACTION: 'REPORT_ACTION',
-    EMAIL: 'EMAIL',
-    REPORT: 'REPORT',
-};


Good catch 👍

getusha · 2023-12-18T16:19:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-21.at.11.54.19.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-21.at.11.50.00.AM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-12-21.at.11.44.06.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-12-21.at.11.00.13.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-12-21.at.10.57.48.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-21.at.11.56.08.AM.mov

# Conflicts: # src/pages/home/report/ContextMenu/ContextMenuActions.js

VickyStash · 2023-12-20T10:19:40Z

@getusha kind bump 🙂

# Conflicts: # src/pages/home/report/ContextMenu/ContextMenuActions.js

getusha

lgtm!

melvin-bot · 2023-12-21T09:08:05Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25135 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

srikarparsi

lgtm

OSBotify · 2023-12-21T22:37:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-26T00:14:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.16-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

VickyStash added 3 commits December 7, 2023 15:17

[TS migration] Migrate 'AnchorForCommentsOnly' component

fa0e582

Add props destructuring

1112a8b

Update import

d70f96b

VickyStash mentioned this pull request Dec 7, 2023

[HOLD for payment 2024-02-05] [TS migration] Migrate '[Remaining Group 3]' lib to TypeScript #31921

Closed