Adds new ReportUtils for Violations

src/components/ReportActionItem/ReportPreview.js

@@ -127,7 +127,7 @@ function ReportPreview(props) {
     const hasReceipts = transactionsWithReceipts.length > 0;
     const hasOnlyDistanceRequests = ReportUtils.hasOnlyDistanceRequestTransactions(props.iouReportID);
     const isScanning = hasReceipts && ReportUtils.areAllRequestsBeingSmartScanned(props.iouReportID, props.action);
-    const hasErrors = hasReceipts && ReportUtils.hasMissingSmartscanFields(props.iouReportID);
+    const hasErrors = (hasReceipts && ReportUtils.hasMissingSmartscanFields(props.iouReportID)) || ReportUtils.reportHasViolations(props.iouReportID);
     const lastThreeTransactionsWithReceipts = transactionsWithReceipts.slice(-3);
     const lastThreeReceipts = _.map(lastThreeTransactionsWithReceipts, (transaction) => ReceiptUtils.getThumbnailAndImageURIs(transaction));
     const hasNonReimbursableTransactions = ReportUtils.hasNonReimbursableTransactions(props.iouReportID);

src/libs/ReportUtils.js

@@ -11,6 +11,7 @@ import * as defaultWorkspaceAvatars from '@components/Icon/WorkspaceDefaultAvata
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
+import * as CollectionUtils from './CollectionUtils';
 import * as CurrencyUtils from './CurrencyUtils';
 import DateUtils from './DateUtils';
 import isReportMessageAttachment from './isReportMessageAttachment';
@@ -81,6 +82,31 @@ Onyx.connect({
     callback: (val) => (loginList = val),
 });
 
+const transactionViolations = {};
+Onyx.connect({
+    key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
+    callback: (violations, key) => {
+        if (!key || !violations) {
+            return;
+        }
+
+        const transactionID = CollectionUtils.extractCollectionItemID(key);
+        transactionViolations[transactionID] = violations;
+    },
+});
+
+const reportActions = {};
+Onyx.connect({
+    key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    callback: (actions, key) => {
+        if (!key || !actions) {
+            return;
+        }
+
+        const reportID = CollectionUtils.extractCollectionItemID(key);
+        reportActions[reportID] = actions;
+    },
+});
 let allPolicyTags = {};
 
 Onyx.connect({
@@ -3316,11 +3342,66 @@ function canAccessReport(report, policies, betas, allReportActions) {
  */
 function shouldHideReport(report, currentReportId) {
     const parentReport = getParentReport(getReport(currentReportId));
-    const reportActions = ReportActionsUtils.getAllReportActions(report.reportID);
-    const isChildReportHasComment = _.some(reportActions, (reportAction) => (reportAction.childVisibleActionCount || 0) > 0);
+    const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
+    const isChildReportHasComment = _.some(allReportActions, (reportAction) => (reportAction.childVisibleActionCount || 0) > 0);
     return parentReport.reportID !== report.reportID && !isChildReportHasComment;
 }
 
+/**
+ * @param {String} transactionID
+ * @returns {Boolean}
+ */
+
+function transactionHasViolation(transactionID) {
+    const violations = lodashGet(transactionViolations, transactionID, []);
+    return _.some(violations, (violation) => violation.type === 'violation');
+}
+
+/**
+ *
+ * @param {Object} report
+ * @returns {Boolean}
+ */
+
+function transactionThreadHasViolations(report) {
+    if (!Permissions.canUseViolations()) {
+        return false;
+    }
+    // eslint-disable-next-line es/no-nullish-coalescing-operators
+    if (!report.parentReportActionID) {
+        return false;
+    }
+
+    const parentReportAction = lodashGet(reportActions, `${report.parentReportID}.${report.parentReportActionID}`);
+    if (!parentReportAction) {
+        return false;
+    }
+    // eslint-disable-next-line es/no-nullish-coalescing-operators
+    const transactionID = parentReportAction.originalMessage.IOUTransactionID ?? 0;
+    if (!transactionID) {
+        return false;
+    }
+    // eslint-disable-next-line es/no-nullish-coalescing-operators
+    const reportID = parentReportAction.originalMessage.IOUReportID ?? 0;
+    if (!reportID) {
+        return false;
+    }
+    if (!isCurrentUserSubmitter(reportID)) {
+        return false;
+    }
+    return transactionHasViolation(transactionID);
+}
+
+/**
+ * @param {String} reportID
+ * @returns {Boolean}
+ */
+
+function reportHasViolations(reportID) {
+    const transactions = TransactionUtils.getAllReportTransactions(reportID);
+    return _.some(transactions, (transaction) => transactionHasViolation(transaction.transactionID));
+}
+
 /**
  * Takes several pieces of data from Onyx and evaluates if a report should be shown in the option list (either when searching
  * for reports or the reports shown in the LHN).
@@ -3396,6 +3477,11 @@ function shouldReportBeInOptionList(report, currentReportId, isInGSDMode, betas,
         return true;
     }
 
+    // Always show IOU reports with violations
+    if (isExpenseRequest(report) && transactionThreadHasViolations(report)) {
+        return true;
+    }
+
     // All unread chats (even archived ones) in GSD mode will be shown. This is because GSD mode is specifically for focusing the user on the most relevant chats, primarily, the unread ones
     if (isInGSDMode) {
         return isUnread(report);
@@ -4437,5 +4523,7 @@ export {
     getPersonalDetailsForAccountID,
     getChannelLogMemberMessage,
     getRoom,
+    transactionThreadHasViolations,
+    reportHasViolations,
     shouldDisableWelcomeMessage,
 };

src/libs/SidebarUtils.ts

@@ -361,7 +361,7 @@ function getOptionData(
     result.shouldShowSubscript = ReportUtils.shouldReportShowSubscript(report);
     result.pendingAction = report.pendingFields ? report.pendingFields.addWorkspaceRoom || report.pendingFields.createChat : null;
     result.allReportErrors = OptionsListUtils.getAllReportErrors(report, reportActions) as OnyxCommon.Errors;
-    result.brickRoadIndicator = Object.keys(result.allReportErrors ?? {}).length !== 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
+    result.brickRoadIndicator = Object.keys(result.allReportErrors ?? {}).length !== 0 || ReportUtils.transactionThreadHasViolations(report) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
     result.ownerAccountID = report.ownerAccountID;
     result.managerID = report.managerID;
     result.reportID = report.reportID;