Adds new ReportUtils for Violations

src/components/LHNOptionsList/LHNOptionsList.js

@@ -64,6 +64,9 @@ const propTypes = {
     transactions: PropTypes.objectOf(transactionPropTypes),
     /** List of draft comments */
     draftComments: PropTypes.objectOf(PropTypes.string),
+
+    /** The list of betas the user has access to */
+    betas: PropTypes.arrayOf(PropTypes.string),
     ...withCurrentReportIDPropTypes,
 };
 
@@ -77,6 +80,7 @@ const defaultProps = {
     personalDetails: {},
     transactions: {},
     draftComments: {},
+    betas: {},
     ...withCurrentReportIDDefaultProps,
 };
 
@@ -97,6 +101,7 @@ function LHNOptionsList({
     transactions,
     draftComments,
     currentReportID,
+    betas,
 }) {
     const styles = useThemeStyles();
     /**
@@ -156,10 +161,11 @@ function LHNOptionsList({
                     onSelectRow={onSelectRow}
                     preferredLocale={preferredLocale}
                     comment={itemComment}
+                    betas={betas}
                 />
             );
         },
-        [currentReportID, draftComments, onSelectRow, optionMode, personalDetails, policy, preferredLocale, reportActions, reports, shouldDisableFocusOptions, transactions],
+        [currentReportID, draftComments, onSelectRow, optionMode, personalDetails, policy, preferredLocale, reportActions, reports, shouldDisableFocusOptions, transactions, betas],
     );
 
     return (
@@ -211,5 +217,8 @@ export default compose(
         draftComments: {
             key: ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT,
         },
+        betas: {
+            key: ONYXKEYS.BETAS,
+        },
     }),
 )(LHNOptionsList);

src/components/LHNOptionsList/OptionRowLHNData.js

@@ -87,7 +87,7 @@ function OptionRowLHNData({
 
     const optionItem = useMemo(() => {
         // Note: ideally we'd have this as a dependent selector in onyx!
-        const item = SidebarUtils.getOptionData(fullReport, reportActions, personalDetails, preferredLocale, policy, parentReportAction);
+        const item = SidebarUtils.getOptionData(fullReport, reportActions, personalDetails, preferredLocale, policy, parentReportAction, propsToForward.betas);
         if (deepEqual(item, optionItemRef.current)) {
             return optionItemRef.current;
         }

src/components/ReportActionItem/ReportPreview.js

@@ -127,7 +127,7 @@ function ReportPreview(props) {
     const hasReceipts = transactionsWithReceipts.length > 0;
     const hasOnlyDistanceRequests = ReportUtils.hasOnlyDistanceRequestTransactions(props.iouReportID);
     const isScanning = hasReceipts && ReportUtils.areAllRequestsBeingSmartScanned(props.iouReportID, props.action);
-    const hasErrors = hasReceipts && ReportUtils.hasMissingSmartscanFields(props.iouReportID);
+    const hasErrors = (hasReceipts && ReportUtils.hasMissingSmartscanFields(props.iouReportID)) || ReportUtils.reportHasViolations(props.iouReportID);
     const lastThreeTransactionsWithReceipts = transactionsWithReceipts.slice(-3);
     const lastThreeReceipts = _.map(lastThreeTransactionsWithReceipts, (transaction) => ReceiptUtils.getThumbnailAndImageURIs(transaction));
     const hasNonReimbursableTransactions = ReportUtils.hasNonReimbursableTransactions(props.iouReportID);

src/libs/ReportUtils.js

@@ -11,6 +11,7 @@ import * as defaultWorkspaceAvatars from '@components/Icon/WorkspaceDefaultAvata
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
+import * as CollectionUtils from './CollectionUtils';
 import * as CurrencyUtils from './CurrencyUtils';
 import DateUtils from './DateUtils';
 import isReportMessageAttachment from './isReportMessageAttachment';
@@ -81,6 +82,31 @@ Onyx.connect({
     callback: (val) => (loginList = val),
 });
 
+const transactionViolations = {};
+Onyx.connect({
+    key: ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS,
+    callback: (violations, key) => {
+        if (!key || !violations) {
+            return;
+        }
+
+        const transactionID = CollectionUtils.extractCollectionItemID(key);
+        transactionViolations[transactionID] = violations;
+    },
+});
+
+const reportActions = {};
+Onyx.connect({
+    key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
+    callback: (actions, key) => {
+        if (!key || !actions) {
+            return;
+        }
+
+        const reportID = CollectionUtils.extractCollectionItemID(key);
+        reportActions[reportID] = actions;
+    },
+});
 let allPolicyTags = {};
 
 Onyx.connect({
@@ -3347,11 +3373,67 @@ function canAccessReport(report, policies, betas, allReportActions) {
  */
 function shouldHideReport(report, currentReportId) {
     const parentReport = getParentReport(getReport(currentReportId));
-    const reportActions = ReportActionsUtils.getAllReportActions(report.reportID);
-    const isChildReportHasComment = _.some(reportActions, (reportAction) => (reportAction.childVisibleActionCount || 0) > 0);
+    const allReportActions = ReportActionsUtils.getAllReportActions(report.reportID);
+    const isChildReportHasComment = _.some(allReportActions, (reportAction) => (reportAction.childVisibleActionCount || 0) > 0);
     return parentReport.reportID !== report.reportID && !isChildReportHasComment;
 }
 
+/**
+ * @param {String} transactionID
+ * @returns {Boolean}
+ */
+
+function transactionHasViolation(transactionID) {
+    const violations = lodashGet(transactionViolations, transactionID, []);
+    return _.some(violations, (violation) => violation.type === 'violation');
+}
+
+/**
+ *
+ * @param {Object} report
+ * @param {Array<String> | null} betas
+ * @returns {Boolean}
+ */
+
+function transactionThreadHasViolations(report, betas) {
+    if (!Permissions.canUseViolations(betas)) {
+        return false;
+    }
+
+    if (!report.parentReportActionID) {
+        return false;
+    }
+
+    const parentReportAction = lodashGet(reportActions, `${report.parentReportID}.${report.parentReportActionID}`);
+    if (!parentReportAction) {
+        return false;
+    }
+    // eslint-disable-next-line es/no-nullish-coalescing-operators
+    const transactionID = parentReportAction.originalMessage.IOUTransactionID ?? 0;
+    if (!transactionID) {
+        return false;
+    }
+    // eslint-disable-next-line es/no-nullish-coalescing-operators
+    const reportID = parentReportAction.originalMessage.IOUReportID ?? 0;
+    if (!reportID) {
+        return false;
+    }
+    if (!isCurrentUserSubmitter(reportID)) {
+        return false;
+    }
+    return transactionHasViolation(transactionID);
+}
+
+/**
+ * @param {String} reportID
+ * @returns {Boolean}
+ */
+
+function reportHasViolations(reportID) {
+    const transactions = TransactionUtils.getAllReportTransactions(reportID);
+    return _.some(transactions, (transaction) => transactionHasViolation(transaction.transactionID));
+}
+
 /**
  * Takes several pieces of data from Onyx and evaluates if a report should be shown in the option list (either when searching
  * for reports or the reports shown in the LHN).
@@ -3427,6 +3509,11 @@ function shouldReportBeInOptionList(report, currentReportId, isInGSDMode, betas,
         return true;
     }
 
+    // Always show IOU reports with violations
+    if (isExpenseRequest(report) && transactionThreadHasViolations(report)) {
+        return true;
+    }
+
     // All unread chats (even archived ones) in GSD mode will be shown. This is because GSD mode is specifically for focusing the user on the most relevant chats, primarily, the unread ones
     if (isInGSDMode) {
         return isUnread(report);
@@ -4478,6 +4565,8 @@ export {
     getPersonalDetailsForAccountID,
     getChannelLogMemberMessage,
     getRoom,
+    transactionThreadHasViolations,
+    reportHasViolations,
     shouldDisableWelcomeMessage,
     canEditWriteCapability,
 };

src/libs/SidebarUtils.ts

@@ -298,6 +298,7 @@ function getOptionData(
     preferredLocale: ValueOf<typeof CONST.LOCALES>,
     policy: Policy,
     parentReportAction: ReportAction,
+    betas: Beta[],
 ): OptionData | undefined {
     // When a user signs out, Onyx is cleared. Due to the lazy rendering with a virtual list, it's possible for
     // this method to be called after the Onyx data has been cleared out. In that case, it's fine to do
@@ -360,7 +361,8 @@ function getOptionData(
     result.shouldShowSubscript = ReportUtils.shouldReportShowSubscript(report);
     result.pendingAction = report.pendingFields ? report.pendingFields.addWorkspaceRoom || report.pendingFields.createChat : null;
     result.allReportErrors = OptionsListUtils.getAllReportErrors(report, reportActions) as OnyxCommon.Errors;
-    result.brickRoadIndicator = Object.keys(result.allReportErrors ?? {}).length !== 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
+    result.brickRoadIndicator =
+        Object.keys(result.allReportErrors ?? {}).length !== 0 || ReportUtils.transactionThreadHasViolations(report, betas) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
     result.ownerAccountID = report.ownerAccountID;
     result.managerID = report.managerID;
     result.reportID = report.reportID;

src/libs/__mocks__/Permissions.ts

@@ -13,4 +13,5 @@ export default {
     canUseDefaultRooms: (betas: Beta[]) => betas.includes(CONST.BETAS.DEFAULT_ROOMS),
     canUsePolicyRooms: (betas: Beta[]) => betas.includes(CONST.BETAS.POLICY_ROOMS),
     canUseCustomStatus: (betas: Beta[]) => betas.includes(CONST.BETAS.CUSTOM_STATUS),
+    canUseViolations: (betas: Beta[]) => betas.includes(CONST.BETAS.VIOLATIONS),
 };

tests/unit/SidebarFilterTest.js

@@ -111,6 +111,7 @@ describe('Sidebar', () => {
                     // When Onyx is updated to contain that report
                     .then(() =>
                         Onyx.multiSet({
+                            [ONYXKEYS.BETAS]: [CONST.BETAS.VIOLATIONS],
                             [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,
@@ -141,7 +142,7 @@ describe('Sidebar', () => {
                     // When Onyx is updated to contain that data and the sidebar re-renders
                     .then(() =>
                         Onyx.multiSet({
-                            [ONYXKEYS.BETAS]: [],
+                            [ONYXKEYS.BETAS]: [CONST.BETAS.VIOLATIONS],
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,
                             [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
@@ -194,7 +195,7 @@ describe('Sidebar', () => {
                     // When Onyx is updated to contain that data and the sidebar re-renders
                     .then(() =>
                         Onyx.multiSet({
-                            [ONYXKEYS.BETAS]: [],
+                            [ONYXKEYS.BETAS]: [CONST.BETAS.VIOLATIONS],
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,
                             [`${ONYXKEYS.COLLECTION.REPORT}${report1.reportID}`]: report1,
@@ -246,7 +247,7 @@ describe('Sidebar', () => {
                     // When Onyx is updated to contain that data and the sidebar re-renders
                     .then(() =>
                         Onyx.multiSet({
-                            [ONYXKEYS.BETAS]: [],
+                            [ONYXKEYS.BETAS]: [CONST.BETAS.VIOLATIONS],
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,
                             [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
@@ -379,6 +380,7 @@ describe('Sidebar', () => {
                     // When Onyx is updated to contain that data and the sidebar re-renders
                     .then(() =>
                         Onyx.multiSet({
+                            [ONYXKEYS.BETAS]: [CONST.BETAS.VIOLATIONS],
                             [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD,
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,
@@ -445,11 +447,14 @@ describe('Sidebar', () => {
             };
             LHNTestUtils.getDefaultRenderedSidebarLinks(draftReport.reportID);
 
+            const betas = [CONST.BETAS.VIOLATIONS];
+
             return (
                 waitForBatchedUpdates()
                     // When Onyx is updated to contain that data and the sidebar re-renders
                     .then(() =>
                         Onyx.multiSet({
+                            [ONYXKEYS.BETAS]: betas,
                             [ONYXKEYS.NVP_PRIORITY_MODE]: CONST.PRIORITY_MODE.GSD,
                             [ONYXKEYS.PERSONAL_DETAILS_LIST]: LHNTestUtils.fakePersonalDetails,
                             [ONYXKEYS.IS_LOADING_REPORT_DATA]: false,