[NO QA] Remove unnecessary screenshot/videos section from issue template #30574

Julesssss · 2023-10-30T11:49:40Z

Details

Removes the detailed screenshot section from the default issue template. We used to require evidence for each platform, but no longer do as contributors can't create bug reports.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/331105

Tests

N/A

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Julesssss · 2023-10-30T12:13:23Z

Having a problem with a failing check. This isn't very important so I'll try the CI actions again later.

* main: (268 commits) Update tests/e2e/testRunner.js Account for both options and reports in unread check Update Auto-Reconciliation.md Rename report to option in requiresAttentionFromCurrentUser Rename shouldShowGBR in one more place Rename shouldShowGBR to requiresAttentionFromCurrentUser in tests Update src/libs/ReportUtils.js Rename functions to separate UI from function logic Update version to 1.3.94-0 Update comment about pinned/gbr reports Remove unneeded import Update Footer.js Add tests for various shouldShowGBR cases Update CONST.ts Update pinned logic for linter Use or instead of null coalescing in getOrderedReportIDs Add task logic to shouldShowGBR Delete docs/articles/expensify-classic/expensify-card/CPA-Card.md Reduce isPolicyOwnedByExpensifyAccounts to one line Add isExpensifyOnlyParticipantInReport function back since its used by tests ...

melvin-bot · 2023-11-01T12:22:44Z

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2023-11-01T12:22:58Z

Not an emergency

OSBotify · 2023-11-01T12:28:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-02T10:38:02Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:08:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:35:25Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:52:58Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

remove unnecessary screenshot/videos section from issue template

a10f8b4

Julesssss self-assigned this Oct 30, 2023

Julesssss marked this pull request as ready for review October 30, 2023 11:49

Julesssss requested a review from a team as a code owner October 30, 2023 11:49

melvin-bot bot requested review from fedirjh and removed request for a team October 30, 2023 11:49

Julesssss removed the request for review from fedirjh October 30, 2023 11:49

Expensify deleted a comment from melvin-bot bot Oct 30, 2023

Julesssss requested a review from a team October 30, 2023 11:53

melvin-bot bot requested review from situchan and removed request for a team October 30, 2023 11:53

iwiznia approved these changes Oct 30, 2023

View reviewed changes

Julesssss removed the request for review from situchan October 30, 2023 11:55

Expensify deleted a comment from melvin-bot bot Oct 30, 2023

rlinoz self-requested a review November 1, 2023 12:22

rlinoz approved these changes Nov 1, 2023

View reviewed changes

rlinoz merged commit c8e7ee5 into main Nov 1, 2023
6 of 7 checks passed

rlinoz deleted the jules-updateChecklist branch November 1, 2023 12:22

melvin-bot bot added the Emergency label Nov 1, 2023

Julesssss removed the Emergency label Nov 1, 2023

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Remove unnecessary screenshot/videos section from issue template #30574

[NO QA] Remove unnecessary screenshot/videos section from issue template #30574

Julesssss commented Oct 30, 2023 •

edited

Loading

Julesssss commented Oct 30, 2023

melvin-bot bot commented Nov 1, 2023

Julesssss commented Nov 1, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

[NO QA] Remove unnecessary screenshot/videos section from issue template #30574

[NO QA] Remove unnecessary screenshot/videos section from issue template #30574

Conversation

Julesssss commented Oct 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Julesssss commented Oct 30, 2023

melvin-bot bot commented Nov 1, 2023

Julesssss commented Nov 1, 2023

OSBotify commented Nov 1, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

Julesssss commented Oct 30, 2023 •

edited

Loading