-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Provider Refactor] BankAccountManualStep #30525
[Form Provider Refactor] BankAccountManualStep #30525
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine, will finish the checklist today.
@cdOut The branch isn't updated with the latest |
@mananjadhav done |
@cdOut The form validations work but I am not able to successfully add the account. Neither does the form retain values when you press back from the Company Information form. The same works on main and staging. web-bank-account-flow.mov |
@mananjadhav I will look into it today, hopefully should push a fix soon |
merge main into form-migration/BankAccountManualStep
@mananjadhav the draft saving should be fixed by now, please retest |
Cc. @luacmartins |
Thanks @cdOut . I'll have it reviewed and tested. |
@mananjadhav did you manage to review the PR? |
thanks for the bump, because this new change is in the Additionally, we just added the draft logic, does that mean the |
@mananjadhav I'm the person who was rewriting the |
Thanks for the context @kowczarz. I was just making sure we don't miss out on anything. Will have this finished today. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-bank-account-step.movAndroid: mWeb Chromemweb-chrome-bank-account-step.moviOS: Nativeios-bank-account-step.moviOS: mWeb Safarimweb-safari-bank-account-step.movMacOS: Chrome / Safariweb-bank-account-step_LgIVTHLe.mp4MacOS: Desktopdesktop-bank-account-step.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.3-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.3-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.3-11 🚀
|
Details
Changed the Form component into the new FormProvider component in BankAccountManualStep
Fixed Issues
$ #30316
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
WEB.mov
MacOS: Desktop
DESKTOP.mov