Remove last few `report.managerEmail` uses #30515

Beamanator · 2023-10-27T14:16:50Z

cc @thienlnam since hopefully this will be the last change needed for tasks 🙏 (related to email -> accountID migration)

also cc @puneetlath so you're aware! we're getting close!

Details

We're working on getting rid of emails & using accountIDs instead - see https://github.com/Expensify/Expensify/issues/294647

Purpose = to increase privacy / prevent emails from being leaked around the app - in onyx & in API calls

Note: We need to watch out for creating reports / tasks with BRAND NEW users that we may / may not have personal details for yet. I believe we now store email addresses in personal details when we start chats (since we must have typed in their email address?) but I'm not 100% sure, which is why it needs to be tested.

Fixed Issues

$ Related to https://github.com/Expensify/Expensify/issues/294647
$ Finishes up https://github.com/Expensify/Expensify/issues/299956

Tests

Make sure task actions still work well:

Create new task
Edit task name / description
Assignee (brand new & existing)

Note: You should test on multiple devices so you can make sure all task updates work correctly for:

The receiver / assignee / report attendees
The same user, on another device (ex: edit tasks on chrome & make sure you see the same correct updates on mobile)

Similarly, make a few money requests & edit / delete them, make sure everything still works perfectly

Verify that no errors appear in the JS console

Offline tests

Same as above, everything should work optimistically offline

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

(see MacOS: Chrome / Safari video)

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-27.at.5.44.39.PM.mov

MacOS: Desktop

melvin-bot · 2023-10-27T14:17:27Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2023-10-27T14:24:01Z

Nice! Should we have a C+ test it?

Beamanator · 2023-10-27T14:24:49Z

@puneetlath Yesssss definitely! 👍 I'm going to do a bit of testing on my side too, then will look for a C+ to take this on 🙏

puneetlath · 2023-10-27T14:25:59Z

Sweet, sounds good!

…ortManagerEmail

Beamanator · 2023-10-27T15:45:40Z

FINALLY tests pass, let's get some C+ to help test now! I uploaded a vid of some tests w/ ios & web

Beamanator · 2023-10-27T15:53:20Z

Thanks @shubham1206agra for volunteering to help with this!

shubham1206agra · 2023-10-31T07:19:12Z

@Beamanator Can you merge latest main here?

…ortManagerEmail

Beamanator · 2023-10-31T07:26:06Z

@shubham1206agra done! 👍

Beamanator · 2023-10-31T13:48:30Z

@shubham1206agra just checking, are you able to review this today? 🙏

shubham1206agra · 2023-10-31T14:58:29Z

@Beamanator Can you review this video (especially at the last)?

Screen.Recording.2023-10-31.at.8.14.46.PM.mp4

Beamanator · 2023-11-01T09:36:52Z

@shubham1206agra sorry I didn't see your message! Is there anything in particular you think isn't working properly? I'll watch and see if I notice anything

Beamanator · 2023-11-01T09:41:37Z

Aah it looks like deleting tasks isn't updating the other user live - have you noticed this before @thienlnam ? (see video above, around minute 2:22) - it looks like it did update both users when the user who created the task deleted it (around minute 1:22), but not when the other person deletes it (minute 2:22)

I guess the question @shubham1206agra is: Does that bug exist in staging / prod as well? If so, we can move forward with this PR. If not, it could be caused by my changes

shubham1206agra · 2023-11-01T09:47:17Z

@Beamanator I think you should first repro this, and test the same in production or staging

Beamanator · 2023-11-01T09:53:34Z

@shubham1206agra it would be great if you could try, if you can't repro in staging/prod I'm happy to give it a go - but I'm pretty busy with other things at the moment

shubham1206agra · 2023-11-01T11:26:26Z

@Beamanator The Same can be repro in prod. I think we can continue the review now.

Beamanator · 2023-11-01T12:41:00Z

Nice, yeah I agree @shubham1206agra 👍

shubham1206agra · 2023-11-01T12:57:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-31.at.8.14.46.PM.mp4

MacOS: Desktop

melvin-bot · 2023-11-01T12:58:37Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-11-01T12:58:41Z

🎯 @shubham1206agra, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #30695.

thienlnam · 2023-11-01T18:02:00Z

Yeah there are currently some PRs to fix some functionality with cancel task

Beamanator · 2023-11-01T18:59:04Z

Good to know @thienlnam 🙏

I'll fix merge conflicts 😓

…ortManagerEmail

Beamanator · 2023-11-01T19:06:28Z

Conflicts fixed! @shubham1206agra can you please test again before we move forward? 🙏

marcaaron · 2023-11-02T04:31:23Z

Not sure why Melvin requested a review from me. Looks like an internal engineer was already assigned. Gonna unsubscribe, but lmk if an additional review is needed.

shubham1206agra · 2023-11-02T12:45:27Z

@Beamanator Still works fine

OSBotify · 2023-11-02T13:34:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:34:28Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:52:01Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:48:57Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator added 2 commits October 27, 2023 15:47

Remove a few managerEmail uses

8661910

Remove a few more managerEmails

b98acd7

Beamanator self-assigned this Oct 27, 2023

Beamanator requested a review from a team as a code owner October 27, 2023 14:16

melvin-bot bot requested review from Gonals and removed request for a team October 27, 2023 14:17

Beamanator added 4 commits October 27, 2023 16:27

export function to be used elsewhere

f90fcd4

Fix test

dc45365

ermagerd

bd28c35

Merge branch 'main' of github.com:Expensify/App into beaman-removeRep…

3dd8321

…ortManagerEmail

Beamanator requested a review from shubham1206agra October 27, 2023 15:52

Merge branch 'main' of github.com:Expensify/App into beaman-removeRep…

8827331

…ortManagerEmail

shubham1206agra approved these changes Nov 1, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron November 1, 2023 12:58

melvin-bot bot mentioned this pull request Nov 1, 2023

[PAY NOV 16th] Payment issue for E/App PR#30515 #30695

Closed

Beamanator added 2 commits November 1, 2023 21:05

Merge branch 'main' of github.com:Expensify/App into beaman-removeRep…

ecdcca7

…ortManagerEmail

Re-remove managerEmail

29bd51a

marcaaron removed their request for review November 2, 2023 04:31

Gonals approved these changes Nov 2, 2023

View reviewed changes

Gonals merged commit e36c722 into main Nov 2, 2023
13 checks passed

Gonals deleted the beaman-removeReportManagerEmail branch November 2, 2023 13:28

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

lanitochka17 mentioned this pull request Nov 7, 2023

[HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report #31028

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove last few `report.managerEmail` uses #30515

Remove last few `report.managerEmail` uses #30515

Beamanator commented Oct 27, 2023 •

edited

Loading

melvin-bot bot commented Oct 27, 2023

puneetlath commented Oct 27, 2023

Beamanator commented Oct 27, 2023

puneetlath commented Oct 27, 2023

Beamanator commented Oct 27, 2023

Beamanator commented Oct 27, 2023

shubham1206agra commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

Beamanator commented Nov 1, 2023

Beamanator commented Nov 1, 2023 •

edited

Loading

shubham1206agra commented Nov 1, 2023

Beamanator commented Nov 1, 2023

shubham1206agra commented Nov 1, 2023

Beamanator commented Nov 1, 2023

shubham1206agra commented Nov 1, 2023 •

edited

Loading

melvin-bot bot commented Nov 1, 2023

melvin-bot bot commented Nov 1, 2023

thienlnam commented Nov 1, 2023

Beamanator commented Nov 1, 2023

Beamanator commented Nov 1, 2023

marcaaron commented Nov 2, 2023

shubham1206agra commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

Remove last few report.managerEmail uses #30515

Remove last few report.managerEmail uses #30515

Conversation

Beamanator commented Oct 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 27, 2023

puneetlath commented Oct 27, 2023

Beamanator commented Oct 27, 2023

puneetlath commented Oct 27, 2023

Beamanator commented Oct 27, 2023

Beamanator commented Oct 27, 2023

shubham1206agra commented Oct 31, 2023

Beamanator commented Oct 31, 2023

Beamanator commented Oct 31, 2023

shubham1206agra commented Oct 31, 2023

Beamanator commented Nov 1, 2023

Beamanator commented Nov 1, 2023 • edited Loading

shubham1206agra commented Nov 1, 2023

Beamanator commented Nov 1, 2023

shubham1206agra commented Nov 1, 2023

Beamanator commented Nov 1, 2023

shubham1206agra commented Nov 1, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 1, 2023

melvin-bot bot commented Nov 1, 2023

thienlnam commented Nov 1, 2023

Beamanator commented Nov 1, 2023

Beamanator commented Nov 1, 2023

marcaaron commented Nov 2, 2023

shubham1206agra commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

Remove last few `report.managerEmail` uses #30515

Remove last few `report.managerEmail` uses #30515

Beamanator commented Oct 27, 2023 •

edited

Loading

Beamanator commented Nov 1, 2023 •

edited

Loading

shubham1206agra commented Nov 1, 2023 •

edited

Loading