Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #30320

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Update CONTRIBUTING.md #30320

merged 4 commits into from
Nov 1, 2023

Conversation

greg-schroeder
Copy link
Contributor

@puneetlath or @mountiny can you take a look at this for me? Thanks!

Details

Adjusting the contributing guidelines to take into account changes to bug reporting and removal of the urgency bonus

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/326650

@greg-schroeder greg-schroeder requested a review from a team as a code owner October 25, 2023 00:18
@melvin-bot melvin-bot bot requested review from s77rt and removed request for a team October 25, 2023 00:18
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

@s77rt @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@greg-schroeder greg-schroeder removed the request for review from s77rt October 25, 2023 00:18
contributingGuides/CONTRIBUTING.md Outdated Show resolved Hide resolved
contributingGuides/CONTRIBUTING.md Outdated Show resolved Hide resolved
contributingGuides/CONTRIBUTING.md Outdated Show resolved Hide resolved
mountiny
mountiny previously approved these changes Oct 27, 2023
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think however we can merge this now and then polish later as we changed the policy already and this is outdated

@mountiny
Copy link
Contributor

Bump on this one @puneetlath @greg-schroeder should we go ahead?

Removed line 74 about us paying $50
Removed lines 71-85 cuz they all had to do with bug reporting
@mallenexpensify
Copy link
Contributor

@mountiny can you do a quick review of this then update? I made some changes/updates and commented above. Other than that, I think/hope we're good?

@puneetlath puneetlath merged commit 717e48d into main Nov 1, 2023
5 of 8 checks passed
@puneetlath puneetlath deleted the greg-schroeder-patch-1 branch November 1, 2023 20:41
@melvin-bot melvin-bot bot added the Emergency label Nov 1, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor

Merging without the checklist since this is just an update to the readme.

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.96-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants