-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show loading indicator when policy is loading #29842
show loading indicator when policy is loading #29842
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Bump @rushatgabhane |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-20.at.10.33.55.movMobile Web - ChromeUploading Screen Recording 2023-10-20 at 10.43.50.mov… Mobile Web - SafariUploading Screen Recording 2023-10-20 at 10.43.50.mov… DesktopScreen.Recording.2023-10-20.at.10.41.22.moviOSScreen.Recording.2023-10-20.at.10.37.52.movAndroidScreen.Recording.2023-10-20.at.10.39.21.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francoisl LGTM!
For context, other pages are already using withPolicyAndFullscreenLoading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.88-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀
|
Details
Fixed Issues
$ #28402
PROPOSAL: #28402 (comment)
Tests
Test 1
Test 2
Test 3
Test 4
Test 5
Test 6
Offline tests
NA
QA Steps
Test 1
Test 2
Test 3
Test 4
Test 5
Test 6
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
Test 1webChrome-loadingInvite-test1.mp4
Test 2
webChrome-loadingMembers-test2.mp4
Test 3
webChrome-loadingCurrency-test3.mp4
Test 4
webChrome-test4.mp4
Test 5
webChrome-test5.mp4
Test 6
webChrome-test6.mp4
Android: Native
androidNativeInviteMissing.mov
Android: mWeb Chrome
mWebChromeInvitePage-compressed.mp4
iOS: Native
iOSNative.mov
iOS: mWeb Safari
iOS-Safari.mov
MacOS: Desktop
desktop-loadingInvite.mp4