Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style console error on open avatar #29461

Merged

Conversation

saranshbalyan-1234
Copy link
Contributor

@saranshbalyan-1234 saranshbalyan-1234 commented Oct 12, 2023

Details

Fixed Issues

$ #29386
PROPOSAL: #29386 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

Same as QA steps

QA Steps

  1. go to any chat
  2. click on header
  3. open profile pic in full view
  4. verify there is no console error on web and desktop

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2023-10-12.at.8.59.28.PM.mov
MacOS: Desktop
Screen.Recording.2023-10-12.at.9.00.27.PM.mov

@saranshbalyan-1234 saranshbalyan-1234 requested a review from a team as a code owner October 12, 2023 15:26
@melvin-bot melvin-bot bot requested review from parasharrajat and removed request for a team October 12, 2023 15:26
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat
Copy link
Member

@saranshbalyan-1234 You are not allowed to submit PR until you are assigned to the issue.

@saranshbalyan-1234
Copy link
Contributor Author

@parasharrajat do I need to reject this pr now?

@parasharrajat
Copy link
Member

Let's wait if you get assigned.

@saranshbalyan-1234
Copy link
Contributor Author

Sure, thanks

@parasharrajat
Copy link
Member

parasharrajat commented Oct 12, 2023

Screenshots

🔲 iOS / native

Screen.Recording.2023-10-13.at.1.20.40.AM.mov

🔲 iOS / Safari

Screen.Recording.2023-10-13.at.1.11.42.AM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-10-13.at.1.06.46.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-10-13.at.1.02.01.AM.mov

🔲 Android / Chrome

Screen.Recording.2023-10-13.at.1.07.25.AM.mov

🔲 Android / native

Screen.Recording.2023-10-13.at.1.21.15.AM.mov

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from thienlnam October 12, 2023 19:52
@thienlnam thienlnam merged commit e9975f6 into Expensify:main Oct 12, 2023
14 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1231.624 ms → 1312.410 ms (+80.786 ms, +6.6%) 🔴
App start runJsBundle 845.303 ms → 901.511 ms (+56.208 ms, +6.6%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1231.624 ms
Stdev: 37.658 ms (3.1%)
Runs: 1165.121778999921 1169.6979330000468 1172.605121999979 1172.8760119997896 1173.3327190000564 1181.5150029999204 1182.9271800001152 1183.327988000121 1184.845844999887 1185.8520949999802 1186.5428499998525 1186.5923109999858 1192.7996840002015 1195.3958859997801 1196.210233000107 1196.542601000052 1199.2211569999345 1201.8027510000393 1202.5782150002196 1202.620141999796 1203.403578999918 1205.031644999981 1205.2363610002212 1205.5704569998197 1207.2605079999194 1208.8207080001011 1211.2380749997683 1212.145701999776 1212.6021670000628 1213.0965430000797 1213.2013440001756 1214.9380540000275 1214.9902989999391 1215.766793999821 1218.4517069999129 1218.8289819997735 1220.14824400004 1220.168298999779 1220.678325000219 1222.0295540001243 1224.5477979998104 1225.0986569998786 1225.3503439999186 1225.5147210001014 1225.5772979999892 1228.7234930000268 1229.8287189998664 1229.9389780000784 1230.4842750001699 1232.6142879999243 1232.8813599999994 1233.103571999818 1233.1283570001833 1234.0140979997814 1234.0383819998242 1234.1610440001823 1234.81196800014 1237.1390240001492 1239.912897999864 1242.5214030002244 1244.0533839999698 1247.7129899999127 1252.905292000156 1253.5805669999681 1254.1186569998972 1254.7168109999038 1254.779041999951 1256.8576290002093 1257.9108649999835 1259.2640809998848 1259.911429000087 1260.6569329998456 1265.5658470001072 1267.0984470001422 1271.782070999965 1272.9680309998803 1275.7676240000874 1277.0613719997928 1294.5524169998243 1295.0382969998755 1296.750347000081 1302.2615649998188 1303.3806560002267 1304.0209349999204 1309.1075090002269 1316.210551999975 1319.0709959999658 1326.3950209999457

Current
Mean: 1312.410 ms
Stdev: 43.304 ms (3.3%)
Runs: 1216.0369939999655 1230.5750679997727 1232.601137000136 1251.7823370001279 1252.570439999923 1252.5880880001932 1254.3208590000868 1255.44695399981 1258.007139999885 1259.2278149998747 1259.2926630000584 1261.8121139998548 1262.5827480000444 1268.2280720002018 1268.73529099999 1269.6123600001447 1273.5387789998204 1275.4649439998902 1277.3403739999048 1280.3998580002226 1281.1024560001679 1283.0397069999017 1285.228037999943 1286.1508920001797 1286.9798989999108 1287.137211999856 1287.745775999967 1291.886582000181 1292.580943999812 1293.773165000137 1294.3157420000061 1296.2960649998859 1298.5592559999786 1298.9649950000457 1299.62852199981 1299.8448769999668 1302.0001139999367 1302.2644609999843 1303.3660430000164 1304.3112349999137 1304.3994930000044 1304.8209899999201 1305.4497309997678 1305.6462300000712 1307.4251270000823 1307.9849339998327 1308.661847999785 1308.8440979998559 1309.7592199998908 1312.180323000066 1314.7219670000486 1315.5614669998176 1315.9605660000816 1316.4337249998935 1316.8191889999434 1318.544003999792 1319.1322090001777 1321.041251000017 1321.044211000204 1321.4416919997893 1322.2830400001258 1330.312799999956 1330.6266549997963 1330.8370659998618 1332.1662909998558 1334.4303000001237 1339.746875999961 1340.839494000189 1341.7767030000687 1343.1568649997935 1347.4730150001124 1348.326185000129 1351.5920489998534 1354.3140859999694 1355.1331239999272 1364.4681669999845 1367.7769700000063 1369.0942469998263 1371.043250999879 1372.8665789999068 1378.1209410000592 1379.0767999999225 1391.5418349998072 1392.247357999906 1394.305468000006 1396.7004160000943 1397.3725729999132 1405.9523310000077 1429.6755499998108
App start runJsBundle Baseline
Mean: 845.303 ms
Stdev: 32.401 ms (3.8%)
Runs: 786 795 795 799 800 805 805 805 807 807 809 809 810 810 811 812 812 813 816 816 817 818 819 822 822 822 824 827 831 832 833 834 835 835 836 836 837 838 838 838 839 841 842 844 845 845 845 845 847 847 847 847 849 850 850 851 852 853 853 853 854 855 855 858 858 859 862 865 868 869 870 870 871 871 873 873 876 878 883 889 891 896 901 904 907 911 931 936 937

Current
Mean: 901.511 ms
Stdev: 30.936 ms (3.4%)
Runs: 846 851 854 855 858 860 861 864 864 867 868 868 869 871 871 872 872 875 875 875 877 878 880 880 880 881 881 882 882 882 884 885 885 885 887 888 888 888 891 891 892 893 896 898 898 898 899 900 900 902 902 903 903 903 908 910 912 912 913 913 913 914 915 916 916 918 918 919 919 920 921 922 923 927 930 933 936 939 941 948 948 949 953 955 958 966 968 973 976 976

Meaningless Changes To Duration

Show entries
Name Duration
App start nativeLaunch 20.735 ms → 21.163 ms (+0.428 ms, +2.1%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +7.7%)
Open Search Page TTI 631.512 ms → 622.718 ms (-8.794 ms, -1.4%)
Show details
Name Duration
App start nativeLaunch Baseline
Mean: 20.735 ms
Stdev: 1.863 ms (9.0%)
Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 25 26 26 27

Current
Mean: 21.163 ms
Stdev: 1.764 ms (8.3%)
Runs: 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 25 25 26 27
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (7.2%)
Runs: 0.012533000204712152 0.01257399981841445 0.012897999957203865 0.013061999808996916 0.013143000192940235 0.013264999724924564 0.013265000190585852 0.013305999804288149 0.013305999804288149 0.013306000269949436 0.013345999643206596 0.013346999883651733 0.01334700034931302 0.01346899988129735 0.013508999720215797 0.013508999720215797 0.013549000024795532 0.013630999717861414 0.013712000101804733 0.013712999876588583 0.01375299971550703 0.013753999955952168 0.013794000260531902 0.0138349998742342 0.013875000178813934 0.013875999953597784 0.013875999953597784 0.013915999792516232 0.013915999792516232 0.013916000258177519 0.013916000258177519 0.01399700017645955 0.014037999790161848 0.01411899970844388 0.014119000174105167 0.014119000174105167 0.014241999946534634 0.014281999785453081 0.014283000025898218 0.014322999864816666 0.014362999703735113 0.01436399994418025 0.014403999783098698 0.014403999783098698 0.014444999862462282 0.014444999862462282 0.014444999862462282 0.01444500032812357 0.01444500032812357 0.014485999941825867 0.014566999860107899 0.014567000325769186 0.014567000325769186 0.014607999939471483 0.014728999696671963 0.014730000402778387 0.014771000016480684 0.014810999855399132 0.0148930000141263 0.0148930000141263 0.014933000318706036 0.015015000011771917 0.015055999625474215 0.015056000091135502 0.01509599993005395 0.015137000009417534 0.015381000004708767 0.015422000084072351 0.015544000081717968 0.015583999920636415 0.015625 0.015625 0.015625 0.015665000304579735 0.015666000079363585 0.015705999918282032 0.01570699969306588 0.01587000023573637 0.01607199991121888 0.01607299968600273 0.016276000067591667 0.01631700014695525 0.0165200000628829 0.016846000216901302 0.0172520000487566 0.01786300027742982

Current
Mean: 0.016 ms
Stdev: 0.001 ms (6.4%)
Runs: 0.013630999717861414 0.013875000178813934 0.013915999792516232 0.013956999871879816 0.013956999871879816 0.013996999710798264 0.01399700017645955 0.014281999785453081 0.014282000251114368 0.014362999703735113 0.01436399994418025 0.014403999783098698 0.01444500032812357 0.014567000325769186 0.014607999939471483 0.014649000018835068 0.014851999934762716 0.014851999934762716 0.014891999773681164 0.0148930000141263 0.014932999853044748 0.014973999932408333 0.015056000091135502 0.01509599993005395 0.015096000395715237 0.015097000170499086 0.015135999768972397 0.015137000009417534 0.015176999848335981 0.015178000088781118 0.015217999927699566 0.015217999927699566 0.01525900000706315 0.015298999845981598 0.015300000086426735 0.015300000086426735 0.015339999925345182 0.015339999925345182 0.015381000004708767 0.015421999618411064 0.015461999922990799 0.015503000002354383 0.015544000081717968 0.015583999920636415 0.015584999695420265 0.015625 0.015625 0.015664999838918447 0.015665000304579735 0.015666000079363585 0.01570699969306588 0.015746999997645617 0.0157880000770092 0.015868999995291233 0.01587000023573637 0.015992000233381987 0.016032000072300434 0.016032000072300434 0.016032000072300434 0.01607300015166402 0.016112999990582466 0.01615400006994605 0.016193999908864498 0.016195000149309635 0.01623600022867322 0.01623600022867322 0.016276000067591667 0.016276000067591667 0.016277000308036804 0.016315999906510115 0.01631700014695525 0.01643799990415573 0.016480000223964453 0.016519999597221613 0.0165200000628829 0.0166830001398921 0.016805000137537718 0.016846000216901302 0.016927000135183334 0.01696799974888563 0.01696800021454692 0.01704900013282895 0.01733400020748377 0.017578000202775 0.017821999732404947 0.017862999811768532 0.01794400019571185 0.018025000113993883
Open Search Page TTI Baseline
Mean: 631.512 ms
Stdev: 28.532 ms (4.5%)
Runs: 593.1382659999654 597.4632979999296 598.9920660001226 599.740559999831 601.691039999947 601.71822099993 602.1501870001666 602.2514649997465 602.3529460001737 602.8851320003159 604.738201000262 605.4593509999104 606.4811200001277 606.6081550000235 606.7849929998629 606.9289560001343 606.9739589998499 607.0130610000342 607.0186360003427 607.2855630000122 608.0703940000385 608.2895510001108 608.2944339998066 608.5086269997992 609.3118900000118 609.4436039999127 610.8787439996377 610.9379879999906 611.2314050002024 612.2634689998813 613.0998129998334 613.3042399999686 614.4858400002122 615.5487470002845 616.9807949997485 617.1928710001521 617.304078000132 617.7156169996597 618.2471519997343 618.9942230000161 619.0178630002774 619.4175209999084 620.1805830001831 622.0967610003427 622.68518100027 623.4357100003399 623.9143480001949 624.8273930000141 624.8400479997508 625.2134599997662 625.2232669997029 627.2589520001784 627.6934409998357 627.8742680000141 634.2528889998794 634.6791990003549 635.4882809999399 639.0808109999634 639.1844899998978 640.5581459999084 641.1637780000456 641.6884359996766 641.7831620001234 643.0909019997343 643.8159179999493 645.433960000053 645.7635500002652 646.2727459999733 648.0931000001729 648.6489669997245 648.8805750003085 649.9332280000672 651.5288899997249 657.2677000002004 658.3422449999489 669.2112230001949 671.071777000092 673.1326900003478 673.8861490003765 679.1130379997194 682.2524010003544 682.3351640002802 692.4115400002338 692.6868080003187 693.1907970001921 693.6796059999615 699.5458990000188 701.9077150002122 703.7032059999183

Current
Mean: 622.718 ms
Stdev: 14.988 ms (2.4%)
Runs: 596.1978759998456 598.0431319996715 599.0435390002094 599.5769050000235 600.3638510000892 602.0955409999005 605.2518309997395 605.9434410003014 606.3144120001234 606.4376219999976 606.7462159995921 608.4187420001253 608.8329269997776 609.5753990001976 609.7703450000845 609.841023999732 610.8460289998911 611.2260340000503 612.7740889997222 613.0259189996868 613.3780519999564 613.5074459998868 613.5385339995846 613.5555019997992 613.8597420002334 613.8614500002004 614.1313069998287 614.9713539998047 614.9748939997517 615.3105470002629 615.775391000323 615.7771399999037 615.8716230001301 616.3404140002094 616.7781169996597 617.309326000046 617.4899900001474 617.8055430003442 617.8170579997823 617.8474940001033 618.0180260003544 618.2091069999151 618.4407149995677 619.5183109999634 620.2184649999253 620.9768880000338 621.2975269998424 621.4279789999127 621.8839520001784 622.5096439998597 622.9233399997465 623.3341479999945 623.3509929999709 623.7246509999968 623.9134120000526 624.0668539996259 624.4366859998554 624.9348959997296 625.2194829997607 626.1544189997949 626.5177820003591 628.0372309996746 628.0612800000235 628.4196779998019 630.3006190001033 630.4324139999226 630.7244470003061 630.9284270000644 631.8590899999253 632.0265299999155 633.4280199999921 635.3608809998259 637.5842290003784 638.8698740000837 640.0046390001662 642.3293869998306 642.7526449998841 643.5590420002118 645.6585699999705 647.4794120001607 650.0928549999371 650.5028079999611 652.5688070002943 657.0461830003187 659.9149170001037 663.210449999664 664.0218110000715

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.84-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@saranshbalyan-1234 saranshbalyan-1234 deleted the fix-console-error-on-open-avatar branch October 31, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants